fix(mobile): find the caret line from the absolute cursor row on a parked viewport

xterm's cursorY is relative to baseY, but _tapIsOnCaretLine read it as a screen row. With the viewport parked above the bottom (a tab switch onto a frame with trailing blank rows) a tap on a URL typed in the prompt opened it, and a URL in scrollback on the row cursorY happened to name stayed inert.
This commit is contained in:
JD committed 2026-10-16 10:37:13 -04:00
1 parent ce809eac41
commit d6d9315fb6
2 files changed
+44 -9

No files matched your search

+11 -9
View File
@@ -2356,15 +2356,17 @@ Object.assign(CodemanApp.prototype, {
if (!buffer?.getLine) return false;
const pos = this._clientPointToCell(clientX, clientY);
if (!pos) return false;
const rows = Math.max(1, this.terminal.rows || 1);
const cursorRow = Math.max(0, Math.min(rows - 1, buffer.cursorY || 0));
const tappedRow = pos.row - 1;
if (tappedRow === cursorRow) return true;
let start = cursorRow;
while (start > 0 && buffer.getLine(buffer.viewportY + start)?.isWrapped) start--;
let end = cursorRow;
while (end + 1 < rows && buffer.getLine(buffer.viewportY + end + 1)?.isWrapped) end++;
return tappedRow >= start && tappedRow <= end;
// Compare ABSOLUTE buffer lines: cursorY is baseY-relative and the tap is
// viewport-relative, so they only agree while the viewport sits at the bottom
// (a tab switch parks it above, see scrollToLastNonEmptyLine).
const cursorLine = buffer.baseY + (buffer.cursorY || 0);
const tappedLine = buffer.viewportY + pos.row - 1;
let start = cursorLine;
while (start > 0 && buffer.getLine(start)?.isWrapped) start--;
let end = cursorLine;
// Bounded by length: xterm's getLine wraps around its circular list past the end.
while (end + 1 < buffer.length && buffer.getLine(end + 1)?.isWrapped) end++;
return tappedLine >= start && tappedLine <= end;
},
/**
+33
View File
@@ -1096,6 +1096,39 @@ describe('terminal link tap', () => {
expect(sent).toHaveLength(1); // the tap still positions the caret via the mouse report
});
it('finds the caret line from the absolute cursor row while the viewport is parked above the bottom', () => {
// A tab switch parks the viewport above baseY when the frame keeps trailing blank
// rows (scrollToLastNonEmptyLine). cursorY is baseY-relative, so read as a screen
// row it points 2 rows too high here: at the history URL, not the composer.
const history = 'docs at https://example.com/guide';
const composer = '❯ summarize https://example.com/typed for me';
const lines = ['', '', '', 'older', 'old', history, 'more', composer, '', ''];
const { app, windowRef } = linkHarness(lines);
Object.assign(app.terminal, { rows: 4 });
Object.assign(app.terminal.buffer.active, { baseY: 6, viewportY: 4, cursorY: 1 });
// Screen row 3 is absolute line 7, the composer: the typed URL stays editable.
expect(app._handleMobileTerminalTap(at(composer.indexOf('https'), 3), true, 'history')).toBe('history');
expect(windowRef.open).not.toHaveBeenCalled();
// Screen row 1 is absolute line 5, scrollback: its URL opens.
expect(app._handleMobileTerminalTap(at(history.indexOf('https'), 1), true, 'history')).toBe('link');
expect(windowRef.open).toHaveBeenCalledWith('https://example.com/guide', '_blank', 'noopener,noreferrer');
});
it('stops the caret-line wrap walk at the buffer end even when every row is wrapped', () => {
// xterm's getLine indexes its circular list modulo capacity, so past the last row it
// returns earlier rows again; with all of them soft-wrapped an unbounded walk never ends.
const { app } = linkHarness(['❯ a', 'b', 'c'], 2);
let reads = 0;
app.terminal.buffer.active.getLine = (row: number) => {
if (++reads > 1000) throw new Error('wrap walk did not stop');
return { isWrapped: true, translateToString: () => ['❯ a', 'b', 'c'][((row % 3) + 3) % 3] };
};
expect(app._tapIsOnCaretLine(at(0, 2).clientX, at(0, 2).clientY)).toBe(true);
});
it('activates a link in a plain shell session, where every tap classifies as input', () => {
// A shell has no TUI to own taps, so _classifyMobileTerminalTap short-circuits to
// 'input' for the whole screen — gating link taps on the intent would leave every URL