BitSquare/Codeman
2
0 Fork 0
mirror of https://github.com/Ark0N/Codeman.git synced 2026-11-14 02:29:33 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(story-mode): two open endings the last words missed

Browse Source 
From a recall sample of clean finishes: "the box hasn't answered yet" is
something not done, and "One thing worth flagging: …" is a heads-up.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Codeman maintainer committed 2026-10-18 16:52:37 +02:00
1 parent 9ffe57709e
commit 2859b3a207
2 files changed
+4 -2
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/story-mode.ts
+2 -2
View File
@@ -291,7 +291,7 @@ const KEY_KINDS: Array<[StoryKeyKind, RegExp]> = [
[
'problem',
// "bug-fixing" and "cron-broken-network" are names, and a bare "warning" is often one too.
/\b(problems?|bugs?(?!-| fix)|(?<!-)broken(?!-)|known (issue|quirk)s?|quirks?|caveats?|(?<![#/])limitations?|heads up|warning sign|be warned|watch out|unfixed|left unfixed|still (fails?|failing|broken)|(won't|doesn't|does not|will not) (work|fix)|(isn't|is not|not) fixed|never (moves|runs|loads|works|starts|shows))\b/i,
/\b(problems?|bugs?(?!-| fix)|(?<!-)broken(?!-)|known (issue|quirk)s?|quirks?|caveats?|(?<![#/])limitations?|heads up|warning sign|be warned|watch out|worth flagging|i want to flag|unfixed|left unfixed|still (fails?|failing|broken)|(won't|doesn't|does not|will not) (work|fix)|(isn't|is not|not) fixed|never (moves|runs|loads|works|starts|shows))\b/i,
],
[
'offer',
@@ -304,7 +304,7 @@ const KEY_KINDS: Array<[StoryKeyKind, RegExp]> = [
[
'pending',
// "Left out" is open work, unless Claude chose it ("left out on purpose", "rather than guessed").
/(?<!(deliberately|intentionally|purposely) )\bleft (out|open)\b(?! (on purpose|deliberately|intentionally|rather))|\b(not yet|haven't|have not|can't tell|isn't (confirmed|committed|pushed|tested|done|checked)|not (checked|tested|verified|confirmed|committed|pushed|opened|run)|still (running|working|open(?!\s+(the|a|an|in|on|it|them)\b)|missing)|didn't (open|try|check|test|run|verify) it)\b/i,
/(?<!(deliberately|intentionally|purposely) )\bleft (out|open)\b(?! (on purpose|deliberately|intentionally|rather))|\b(not yet|haven't|have not|(hasn't|has not) (answered|replied|finished|started|run|been (run|tested|checked|merged|pushed))|can't tell|isn't (confirmed|committed|pushed|tested|done|checked)|not (checked|tested|verified|confirmed|committed|pushed|opened|run)|still (running|working|open(?!\s+(the|a|an|in|on|it|them)\b)|missing)|didn't (open|try|check|test|run|verify) it)\b/i,
],
// A step that failed, not a description of failure ("1 for a failed operation").
['failed', /(?<!\b(a|the|any|on) )\b(failed|fails)\b/i],
test/story-mode.test.ts
+2
View File
@@ -1046,6 +1046,8 @@ describe('buildStoryPage', () => {
expect(keyKindOf('The old menu used to break when the list was empty.')).toBeUndefined();
expect(keyKindOf('JSON files still open the live log viewer, as intended.')).toBeUndefined();
expect(keyKindOf('Two reviews are still open.')).toBe('pending');
expect(keyKindOf("I sent the request, but the box hasn't answered yet.")).toBe('pending');
expect(keyKindOf('One thing worth flagging: the PR went conflicting because of my push.')).toBe('problem');
// "Left out" is open work, unless Claude chose it.
expect(keyKindOf('The README update is left out for now.')).toBe('pending');
expect(