Files
Codeman/test/session-swipe-gesture.test.ts
T
Codeman maintainer 4da6aee660 fix: apply the review items for #682 at merge
docs: architecture-invariants (arrow-key walk section) names the phone swipe beside the arrow keys as following the drawn order
docs: root CLAUDE.md (Owner tab layouts) carves the phone swipe out of "every other order consumer reads sessionOrder"
test: pin the grouped-tree branch of _stripSessionOrder() (sorted rail, header and web tab skipped, groups not interleaved)
test: the step-in case uses a drawn order (homelab, w1, w2) that master's canonical walk and the old arithmetic cannot satisfy

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-24 14:05:05 +02:00

313 lines
15 KiB
TypeScript

// Port: none (pure logic in a vm context: no browser, no server).
//
// The session swipe (SwipeHandler, mobile-handlers.js) shares every gesture with
// the terminal's own touch handler (terminal-ui.js), which runs first. A swipe
// used to switch sessions even when the terminal had taken the same drag as a
// scroll or a pan, and the terminal took a sideways flick as a TAP on the
// session being left. The terminal now publishes the axis it locked
// (`app._terminalGestureAxis`) and the swipe stands aside for 'y' and 'x'.
//
// Lives outside test/mobile/ because that suite is Playwright-driven and not in
// the CI gate (same reasoning as test/viewport-shape-change.test.ts).
import { readFileSync } from 'node:fs';
import { resolve } from 'node:path';
import vm from 'node:vm';
import { describe, expect, it, vi } from 'vitest';
const SOURCE = readFileSync(resolve(import.meta.dirname, '../src/web/public/mobile-handlers.js'), 'utf8');
const TERMINAL_SOURCE = readFileSync(resolve(import.meta.dirname, '../src/web/public/terminal-ui.js'), 'utf8');
type Touch = { clientX: number; clientY: number };
type Swipe = {
onTouchStart(e: unknown): void;
onTouchMove(e: unknown): void;
onTouchEnd(e: unknown): void;
maxSwipeTime: number;
maxVerticalDrift: number;
startTime: number;
};
function load(appOverrides: Record<string, unknown> = {}) {
const app = {
nextSession: vi.fn(),
prevSession: vi.fn(),
_terminalGestureAxis: null as string | null,
...appOverrides,
};
const context = vm.createContext({
console,
app,
navigator: { userAgent: 'iPhone', maxTouchPoints: 5 },
window: { addEventListener: () => {}, matchMedia: () => ({ matches: true }) },
document: { querySelector: () => null },
setTimeout: () => 0,
clearTimeout: () => {},
});
vm.runInContext(`${SOURCE}\nglobalThis.__swipe = SwipeHandler;`, context);
const swipe = (context as unknown as { __swipe: Swipe }).__swipe;
const target = (ignored = false) => ({
closest: (sel: string) => (ignored && sel !== '.session-sidebar' ? {} : null),
});
// `axis` is what the terminal's touchmove publishes mid-gesture (after the
// touchstart, which resets it); `consumed` a touchend the terminal
// preventDefault'ed.
const gesture = (
from: Touch,
to: Touch,
opts: { ms?: number; ignored?: boolean; via?: Touch; axis?: string | null; consumed?: boolean } = {}
) => {
swipe.onTouchStart({ target: target(opts.ignored), touches: [from] });
if (opts.axis !== undefined) app._terminalGestureAxis = opts.axis;
if (opts.ms) swipe.startTime -= opts.ms;
if (opts.via) swipe.onTouchMove({ touches: [opts.via] });
swipe.onTouchMove({ touches: [to] });
swipe.onTouchEnd({ changedTouches: [to], defaultPrevented: !!opts.consumed });
};
return { app, swipe, gesture };
}
describe('session swipe', () => {
it('switches on a clean horizontal swipe', () => {
const { app, gesture } = load();
gesture({ clientX: 300, clientY: 400 }, { clientX: 150, clientY: 405 });
expect(app.nextSession).toHaveBeenCalledTimes(1);
gesture({ clientX: 100, clientY: 400 }, { clientX: 260, clientY: 400 });
expect(app.prevSession).toHaveBeenCalledTimes(1);
});
it('accepts an unhurried swipe up to 500ms, not past it', () => {
const { app, gesture } = load();
gesture({ clientX: 300, clientY: 400 }, { clientX: 150, clientY: 400 }, { ms: 450 });
expect(app.nextSession).toHaveBeenCalledTimes(1);
gesture({ clientX: 300, clientY: 400 }, { clientX: 150, clientY: 400 }, { ms: 600 });
expect(app.nextSession).toHaveBeenCalledTimes(1);
});
it('cancels when the finger drifted vertically mid-gesture, even if it came back', () => {
const { app, gesture } = load();
gesture({ clientX: 300, clientY: 400 }, { clientX: 150, clientY: 400 }, { via: { clientX: 220, clientY: 470 } });
expect(app.nextSession).not.toHaveBeenCalled();
});
it('stands aside when the terminal took the drag as a scroll or a pan', () => {
for (const axis of ['y', 'x']) {
const { app, gesture } = load();
gesture({ clientX: 300, clientY: 400 }, { clientX: 150, clientY: 400 }, { axis });
expect(app.nextSession, axis).not.toHaveBeenCalled();
}
const { app, gesture } = load();
gesture({ clientX: 300, clientY: 400 }, { clientX: 150, clientY: 400 }, { axis: 'swipe' });
expect(app.nextSession).toHaveBeenCalledTimes(1);
});
it('forgets the axis a previous gesture left behind, so a swipe from home works after a terminal scroll', () => {
// The terminal resets the axis only for a touch that starts on it; a swipe
// over the home screen starts elsewhere in `.main`.
const { app, gesture } = load({ _terminalGestureAxis: 'y' });
gesture({ clientX: 300, clientY: 400 }, { clientX: 150, clientY: 400 });
expect(app.nextSession).toHaveBeenCalledTimes(1);
});
it('stands aside when the terminal consumed the lift (a long-press selection gesture)', () => {
// A long-press on blank space sets _touchSelecting, finds no word, and the
// terminal clears the flag synchronously in its own touchend before this
// handler runs; the preventDefault it leaves behind is the signal.
const { app, gesture } = load();
gesture({ clientX: 300, clientY: 400 }, { clientX: 150, clientY: 400 }, { consumed: true });
expect(app.nextSession).not.toHaveBeenCalled();
});
it('never switches during a touch selection or on a surface with its own controls', () => {
for (const flag of ['_touchSelecting', '_touchSelectionActive']) {
const { app, gesture } = load({ [flag]: true });
gesture({ clientX: 300, clientY: 400 }, { clientX: 150, clientY: 400 });
expect(app.nextSession, flag).not.toHaveBeenCalled();
}
const { app, gesture } = load();
gesture({ clientX: 300, clientY: 400 }, { clientX: 150, clientY: 400 }, { ignored: true });
expect(app.nextSession).not.toHaveBeenCalled();
});
it('ignores every lift after a second finger joined, the first finger lifting first included', () => {
// Finger A starts the gesture, B joins (a pinch), A lifts, then B lifts
// 150 px from A's start within the time limit: neither lift is a swipe.
const { app, swipe } = load();
const a = { clientX: 300, clientY: 400 };
const b = { clientX: 100, clientY: 400 };
swipe.onTouchStart({ target: { closest: () => null }, touches: [a] });
swipe.onTouchStart({ target: { closest: () => null }, touches: [a, b] });
swipe.onTouchEnd({ changedTouches: [{ clientX: 200, clientY: 400 }] });
swipe.onTouchEnd({ changedTouches: [{ clientX: 150, clientY: 400 }] });
expect(app.nextSession).not.toHaveBeenCalled();
});
});
describe('terminal touch handler hands sideways drags to the swipe', () => {
it('locks a dominant sideways drag as a swipe unless the terminal can pan', () => {
expect(TERMINAL_SOURCE).toContain("panAxis = travelX > travelY ? (canPanHorizontally() ? 'x' : 'swipe') : 'y';");
expect(TERMINAL_SOURCE).toContain('this._terminalGestureAxis = panAxis;');
// A 'swipe' is neither a scroll nor (didScroll is set) a tap.
expect(TERMINAL_SOURCE).toContain("if (panAxis === 'swipe') {");
});
it("hands a 'swipe' drag back to the scroll once it passes the swipe's own drift limit", () => {
// A thumb arc whose first move leans sideways (+9 px across, +5 px down) locks
// as 'swipe'; SwipeHandler drops it past maxVerticalDrift, so without the
// handback the 300 px of downward travel that follows would do nothing.
const start = TERMINAL_SOURCE.indexOf("if (panAxis === 'swipe') {");
const block = TERMINAL_SOURCE.slice(start, TERMINAL_SOURCE.indexOf("if (panAxis === 'x') {", start));
expect(block).toContain('SwipeHandler.maxVerticalDrift');
expect(block).toContain('if (Math.abs(touchY - touchStartY) <= drift) return;');
expect(block).toContain("panAxis = 'y';");
expect(block).toContain("this._terminalGestureAxis = 'y';");
// The terminal reads the swipe's limit by name; its fallback is the same value.
expect(load().swipe.maxVerticalDrift).toBe(50);
});
});
describe('the swipe walks the order the strip draws', () => {
type Proto = Record<string, (this: Record<string, unknown>, ...args: unknown[]) => unknown>;
function loadAppProto() {
const document = {
addEventListener: vi.fn(),
documentElement: { dataset: {} },
getElementById: (_id: string): unknown => null,
};
const context = vm.createContext({
console,
setInterval: vi.fn(),
clearInterval: vi.fn(),
setTimeout,
clearTimeout,
requestAnimationFrame: vi.fn(),
// A row stub's `cssOrder` stands in for the flex `order` a sorted rail paints.
getComputedStyle: (el: { cssOrder?: number }) => ({ order: String(el.cssOrder ?? 0) }),
HTMLCanvasElement: class HTMLCanvasElement {},
WebSocket: { OPEN: 1 },
fetch: vi.fn(),
URLSearchParams,
document,
localStorage: { length: 0, key: vi.fn(), getItem: vi.fn(), setItem: vi.fn(), removeItem: vi.fn() },
window: { addEventListener: vi.fn(), removeEventListener: vi.fn() },
MobileDetection: { isTouchDevice: () => true, isHandheldDevice: () => true, getDeviceType: () => 'mobile' },
});
const read = (f: string) => readFileSync(resolve(import.meta.dirname, '../src/web/public', f), 'utf8');
vm.runInContext(`${read('constants.js')}\n${read('app.js')}\nglobalThis.__App = CodemanApp;`, context);
return { proto: (context as unknown as { __App: { prototype: Proto } }).__App.prototype, document };
}
/** The real next/prev over a strip drawn as `rows` (ids; 'web' is a web tab) with `active` selected. */
function walk(rows: string[], active: string | null) {
const row = (id: string) =>
id === 'web' ? { dataset: { webviewId: 'web' } } : { dataset: { id }, classList: { contains: () => false } };
return drive(
{
getAttribute: () => 'tablist',
classList: { contains: () => false },
querySelectorAll: () => rows.map(row),
},
active
);
}
/** The real next/prev over `strip` (a stub of #sessionTabs) with `active` selected. */
function drive(strip: unknown, active: string | null, sorted = false) {
const { proto, document } = loadAppProto();
const selected: string[] = [];
const app: Record<string, unknown> = {
sessionOrder: ['w1', 'w2', 'homelab', 'w3'],
sessions: new Map(['w1', 'w2', 'homelab', 'w3'].map((id) => [id, {}])),
activeSessionId: active,
isTabRailSorted: () => sorted,
selectSession: (id: string) => selected.push(id),
};
for (const name of ['_visibleTabRows', '_tabTreeItems', '_stripSessionOrder', 'nextSession', 'prevSession']) {
app[name] = proto[name];
}
document.getElementById = () => strip;
const next = (o?: unknown) => (app.nextSession as (o?: unknown) => void).call(app, o);
const prev = (o?: unknown) => (app.prevSession as (o?: unknown) => void).call(app, o);
return { selected, next, prev };
}
it('follows the case boxes, not the creation order', () => {
// Created w1, w2, homelab, w3; the 'case' layout boxes md-viewer's tabs together.
const { selected, next, prev } = walk(['w1', 'w2', 'w3', 'web', 'homelab'], 'w3');
next({ visual: true });
prev({ visual: true });
next();
// Visual: w3 -> homelab (next), w3 -> w2 (prev). Canonical (no option) keeps sessionOrder: w3 -> w1.
expect(selected).toEqual(['homelab', 'w2', 'w1']);
});
it('walks the grouped tree: group by group, sorted inside each, headers and web tabs skipped', () => {
// A rail sorted by activity with a named group "ops" (homelab, a web tab, w3) above
// Ungrouped (w1, w2); the DOM keeps sessionOrder inside each group. The tree sorts
// INSIDE each group, so it draws w3, homelab, web | w1, w2, where one sort over the
// whole list (the flat walk) would interleave the groups as w3, w1, homelab, w2.
const tab = (id: string, cssOrder: number) => ({
dataset: id === 'web' ? { webviewId: 'web' } : { id },
cssOrder,
classList: { contains: (c: string) => c === 'session-tab' },
closest: () => null,
});
const header = { dataset: { tabGroupHeader: 'ops' }, classList: { contains: () => false } };
const section = (head: unknown, rows: unknown[]) => ({
classList: { contains: () => false },
querySelector: () => head,
querySelectorAll: () => rows,
});
const ops = [tab('homelab', 2), tab('web', 9999), tab('w3', 0)];
// The Ungrouped heading is aria-hidden, not a treeitem, so the section has none.
const ungrouped = [tab('w1', 1), tab('w2', 3)];
const sections = [section(header, ops), section(null, ungrouped)];
const strip = {
getAttribute: (name: string) => (name === 'role' ? 'tree' : null),
classList: { contains: () => false },
querySelectorAll: (sel: string) =>
sel === '.tab-layout-group' ? sections : sel.includes('.tab-cluster') ? [] : [...ops, ...ungrouped],
};
const { selected, next, prev } = drive(strip, 'homelab', true);
next({ visual: true });
prev({ visual: true });
// Tree: homelab -> w1 (past the web tab, into the next group), homelab -> w3.
// The flat walk would give w2 / w1, the canonical order w3 / w2.
expect(selected).toEqual(['w1', 'w3']);
});
it('steps in at the first or last drawn row when the active session is not drawn', () => {
// A filter hid the active tab (or nothing is active on the home screen). The drawn
// order differs from sessionOrder's ends (w1 ... w3), so the canonical walk from w3
// (w1 / homelab) cannot pass for this, and nor can the old arithmetic on the drawn
// order, which put previous on the second to last row (w1).
const { selected, next, prev } = walk(['homelab', 'w1', 'w2'], 'w3');
next({ visual: true });
prev({ visual: true });
expect(selected).toEqual(['homelab', 'w2']);
});
it('reaches a lone drawn row that is not the active one, and goes nowhere from a lone active one', () => {
const lone = walk(['w2'], 'w3');
lone.next({ visual: true });
expect(lone.selected).toEqual(['w2']);
const self = walk(['w3'], 'w3');
self.next({ visual: true });
self.prev({ visual: true });
expect(self.selected).toEqual([]);
});
it('goes nowhere when every row is filtered out, instead of falling back to a hidden session', () => {
const { selected, next, prev } = walk([], 'w3');
next({ visual: true });
prev({ visual: true });
expect(selected).toEqual([]);
});
it('the swipe asks for the visual order', () => {
const { app, gesture } = load();
gesture({ clientX: 300, clientY: 400 }, { clientX: 150, clientY: 400 });
expect(app.nextSession).toHaveBeenCalledWith({ visual: true });
});
});