mirror of
https://github.com/Ark0N/Codeman.git
synced 2026-11-14 02:29:33 +01:00
The fixes #529's review asked for, each with a test. - No inline handler. The button quoted the path inside onclick="...decodeURIComponent('<path>')", and encodeURIComponent leaves ' alone, so a file named x'-alert(1)-'.txt ran script in Codeman's origin and it's.txt was a syntax error. It is now bound in the existing .file-tree-item loops from the row's escaped data-path. - Symbolic links are refused, never followed. validateSessionFilePath() returns the realpath, so deleting AGENTS.md -> CLAUDE.md deleted CLAUDE.md and left the link dangling. The path as named is lstat'ed, a link answers 400, and the inode is compared again before the unlink. - The edit route's confinement whole: validateLocalSessionFilePath() behind withGuardedOutsideWorktree(), so an absolute path in a followed outside worktree obeys the same rules, and the sensitive, blocked and .git checks run on both the realpath and the path as named. - Adopted sessions are refused like remote ones (the /tmp exception of the older file surfaces is not copied to a new one); Docker workspaces are allowed, as on the edit route. The workspace is probed bounded first (#516). Errors are thrown with their status. - Deleting from search results re-runs the search, the row buttons stay visible on touch screens, the confirm and toasts have zh-CN text, and no button is drawn for remote or adopted sessions. - Docs: CLAUDE.md, architecture-invariants, api-reference and the Working With Files wiki page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
142 lines
4.3 KiB
TypeScript
142 lines
4.3 KiB
TypeScript
/**
|
|
* @fileoverview Common/shared type definitions.
|
|
*
|
|
* Base types used across multiple domains. No dependencies on other domain modules.
|
|
*
|
|
* Key exports:
|
|
* - Disposable — interface for objects requiring explicit cleanup (timers, watchers)
|
|
* - BufferConfig — size-limited storage config (terminal: 2MB, text: 1MB)
|
|
* - CleanupRegistration / CleanupResourceType — entries for the centralized CleanupManager
|
|
* - NiceConfig / DEFAULT_NICE_CONFIG — process priority settings for `nice`/`ionice`
|
|
* - ProcessStats — memory/CPU/child-count snapshot for resource monitoring
|
|
* - FilesystemBrowseData — bounded path-picker directory listing returned to the web UI
|
|
*/
|
|
|
|
/**
|
|
* Interface for objects that hold resources requiring explicit cleanup.
|
|
* Implementing classes should release timers, watchers, and other resources in dispose().
|
|
*/
|
|
export interface Disposable {
|
|
/** Release all held resources. Safe to call multiple times. */
|
|
dispose(): void;
|
|
/** Whether this object has been disposed */
|
|
readonly isDisposed: boolean;
|
|
}
|
|
|
|
/**
|
|
* Configuration for buffer accumulator instances.
|
|
* Used for terminal buffers, text output, and other size-limited string storage.
|
|
*/
|
|
export interface BufferConfig {
|
|
/** Maximum buffer size in bytes before trimming */
|
|
maxSize: number;
|
|
/** Size to trim to when maxSize is exceeded */
|
|
trimSize: number;
|
|
/** Optional callback invoked when buffer is trimmed */
|
|
onTrim?: (trimmedBytes: number) => void;
|
|
}
|
|
|
|
/**
|
|
* Resource types that can be registered for cleanup.
|
|
*/
|
|
/**
|
|
* Configuration for process priority using `nice`.
|
|
* Lower priority reduces CPU contention with other processes.
|
|
*/
|
|
export interface NiceConfig {
|
|
/** Whether nice priority is enabled */
|
|
enabled: boolean;
|
|
/** Nice value (-20 to 19, default: 10 = lower priority) */
|
|
niceValue: number;
|
|
}
|
|
|
|
export const DEFAULT_NICE_CONFIG: NiceConfig = {
|
|
enabled: false,
|
|
niceValue: 10,
|
|
};
|
|
|
|
/**
|
|
* Process resource statistics
|
|
*/
|
|
export interface ProcessStats {
|
|
/** Memory usage in megabytes */
|
|
memoryMB: number;
|
|
/** CPU usage percentage */
|
|
cpuPercent: number;
|
|
/** Number of child processes */
|
|
childCount: number;
|
|
/** Timestamp of stats collection */
|
|
updatedAt: number;
|
|
}
|
|
|
|
/** A selectable entry returned by the filesystem path-picker API. */
|
|
export type FilesystemPreviewKind = 'image' | 'text' | 'document';
|
|
|
|
export interface FilesystemBrowseEntry {
|
|
name: string;
|
|
path: string;
|
|
type: 'file' | 'directory';
|
|
size?: number;
|
|
/** Last-modified time (ms since epoch) of the entry's target; lets the picker sort by date. */
|
|
mtimeMs?: number;
|
|
symlink?: boolean;
|
|
previewKind?: FilesystemPreviewKind;
|
|
}
|
|
|
|
/** A named root the path picker may browse without escaping its allowlist. */
|
|
export interface FilesystemBrowseRoot {
|
|
label: string;
|
|
path: string;
|
|
}
|
|
|
|
/** Response payload for `GET /api/filesystem/browse`. */
|
|
export interface FilesystemBrowseData {
|
|
path: string;
|
|
parent: string | null;
|
|
root: string;
|
|
roots: FilesystemBrowseRoot[];
|
|
entries: FilesystemBrowseEntry[];
|
|
truncated: boolean;
|
|
}
|
|
|
|
/** Response payload for `PUT /api/sessions/:id/file-content` (File Viewer edit mode). */
|
|
export interface FileWriteData {
|
|
/** Workspace-relative path as submitted */
|
|
path: string;
|
|
/** Size of the written content in bytes */
|
|
size: number;
|
|
/** mtime of the file after the write */
|
|
mtimeMs: number;
|
|
/** sha256 hex of the written bytes — the client's next baseHash */
|
|
hash: string;
|
|
/** Line count of the written content */
|
|
totalLines: number;
|
|
/** Line-ending style that was applied */
|
|
eol: 'lf' | 'crlf';
|
|
}
|
|
|
|
/** Response payload for `DELETE /api/sessions/:id/files?path=` (the Files panel's delete button). */
|
|
export interface FileDeleteData {
|
|
/** The path as submitted (workspace-relative, or absolute inside the session's outside worktree) */
|
|
path: string;
|
|
}
|
|
|
|
export type CleanupResourceType = 'timer' | 'interval' | 'watcher' | 'listener' | 'stream';
|
|
|
|
/**
|
|
* Registration entry for a cleanup resource.
|
|
* Used by CleanupManager to track and dispose resources.
|
|
*/
|
|
export interface CleanupRegistration {
|
|
/** Unique identifier for this registration */
|
|
id: string;
|
|
/** Type of resource */
|
|
type: CleanupResourceType;
|
|
/** Human-readable description for debugging */
|
|
description: string;
|
|
/** Cleanup function to call on dispose */
|
|
cleanup: () => void;
|
|
/** Timestamp when registered */
|
|
registeredAt: number;
|
|
}
|