mirror of
https://github.com/Ark0N/Codeman.git
synced 2026-11-16 19:29:33 +01:00
fix(settings): case sync asks and merges only while it is on
- session-ui.js: no GET /api/settings on a tab return unless this device's cached syncCaseState is true - system-routes.ts: caseSettings is merged only while syncCaseState is true (as stored or set by the same PUT) - sync-case-state tests cover both; wiki notes the stored options stay when sync is turned off
This commit is contained in:
1 parent
a50d0db283
commit
f8ff431d30
5 files changed
+24
-6
No files matched your search
@@ -64,6 +64,17 @@ describe('shared case options', () => {
|
||||
expect(readSettings().caseSettings).toEqual({ alpha: on, beta: off, gamma: on });
|
||||
});
|
||||
|
||||
it('ignores a caseSettings PUT while syncCaseState is off, and takes one that turns it on', async () => {
|
||||
seed({ syncCaseState: false, caseSettings: { kept: off } });
|
||||
expect((await send('PUT', '/api/settings', { caseSettings: { alpha: on } })).status).toBe(200);
|
||||
expect(readSettings().caseSettings).toEqual({ kept: off });
|
||||
seed({});
|
||||
await send('PUT', '/api/settings', { caseSettings: { alpha: on } });
|
||||
expect(readSettings().caseSettings).toBeUndefined();
|
||||
await send('PUT', '/api/settings', { syncCaseState: true, caseSettings: { alpha: on } });
|
||||
expect(readSettings().caseSettings).toEqual({ alpha: on });
|
||||
});
|
||||
|
||||
it('keeps the other cases when one is saved again, and every other setting', async () => {
|
||||
seed({ syncCaseState: true, lastUsedCase: 'x', caseSettings: { alpha: on, beta: off } });
|
||||
await send('PUT', '/api/settings', { caseSettings: { alpha: off } });
|
||||
|
||||
Reference in new issue
Block a user