mirror of
https://github.com/Ark0N/Codeman.git
synced 2026-11-20 04:59:34 +01:00
Merge #825: proxied dashboards render in a web tab (dsh token, relative base, dynamic imports)
The DeepSeek Harness web tab trades the dsh web launch token for its session cookie, a relative <base href> resolves against the document's own directory, and root-absolute import("/...") inside scripts is rewritten onto the proxy prefix.
# Conflicts:
# src/web/routes/webview-routes.ts
# test/routes/webview-routes.test.ts
This commit is contained in:
commit
f25e94141f
12 files changed
+1405
-29
No files matched your search
@@ -288,6 +288,39 @@ dsh fences its `/api` behind a browser-trust check on the request authority, and
|
||||
Codeman web tab reaches it through Codeman's own origin via the webview proxy, not
|
||||
directly. Without it the page renders and every API call fails.
|
||||
|
||||
Since dsh's browser-auth gate, the index is not public either: boot prints
|
||||
`dsh web: http://127.0.0.1:<port>/?token=<one-time token>` and only a request
|
||||
carrying that token is answered with the `dsh-auth-*` cookie that authorizes
|
||||
everything after it. The saved tab deliberately keeps the clean URL, so the
|
||||
browser can never present that token, and the tab used to open on dsh's 401 page.
|
||||
`src/deepseek-web-server.ts` now reads the token out of the captured boot output,
|
||||
trades it for the cookie once at startup, and `webview-routes.ts` presents that
|
||||
cookie on both the HTTP and WebSocket legs — scoped to the exact loopback
|
||||
authority it was minted for, so a repointed or stale tab cannot carry it
|
||||
elsewhere. The reader scans every `dsh web:` line (dsh prints diagnostics such as
|
||||
`dsh web: loading profiles` under the same prefix before the banner) and only
|
||||
complete lines, so a banner split across two output chunks is waited for rather
|
||||
than parsed truncated. Before the token URL is fetched it must name `127.0.0.1`
|
||||
on the port the supervisor just spawned, so a banner cannot aim the server-side
|
||||
request at another host or local service. A dsh without the gate prints a
|
||||
token-less banner and keeps working unchanged. If a token is printed but the
|
||||
exchange still fails, the server keeps running (its page serves, just 401) and is
|
||||
marked unusable for reuse: the next start request stops and respawns it, which is
|
||||
the "restart `dsh web`" the warning asks the user to perform.
|
||||
|
||||
The cookie is also bound to a person, not to a URL. `managed` is accepted from the
|
||||
client on `POST/PATCH /api/webviews` and `GET /api/deepseek/web` publishes the live
|
||||
port, so a saved record pointing at that port is not an entitlement by itself: the
|
||||
proxy presents the cookie only when the tab's owner holds the same
|
||||
privileged-commands grant `POST /api/deepseek/web` requires, and in multi-user mode
|
||||
only to the owner whose request started that process. A different owner's start
|
||||
request restarts the server rather than reusing a cookie that is not theirs, which
|
||||
is why the shared instance is effectively single-user at a time. On a trusted
|
||||
managed tab the cookie is sent ahead of whatever cookies dsh itself set in the
|
||||
browser, rather than replacing them; leading matters because a `Cookie` header can
|
||||
name the same cookie twice and the first value is the one the dashboard parses, so
|
||||
a stale browser copy must not shadow the one the running process minted.
|
||||
|
||||
## 7. Docker and remote cases
|
||||
|
||||
Docker cases work: the agent image installs `dsh` and bootstraps a `dsh-tui`
|
||||
|
||||
+24
-2
@@ -144,9 +144,21 @@ per-device (`localStorage`), since that is workspace layout rather than config.
|
||||
Worth knowing, because it is where this feature does its least obvious work. Three
|
||||
layers cooperate so a dashboard talking to its own backend just works:
|
||||
|
||||
1. `<base href>` handles relative URLs in the markup.
|
||||
1. `<base href>` handles relative URLs in the markup. A page that ships its own
|
||||
**relative** base (`<base href="./">`, what a Vite build emits) has it resolved
|
||||
against the document's own directory inside the proxy prefix first, so a
|
||||
document at `/webview/<cap>/app/page.html` gets `/webview/<cap>/app/` rather
|
||||
than the proxy root: the page's URL is masked a few paragraphs below, a base is
|
||||
resolved against that URL, so `./` would otherwise point at Codeman's root and
|
||||
404 every module script behind an otherwise-painted page.
|
||||
2. Attribute rewriting handles root-absolute `src`/`href`/`action` in the page the
|
||||
proxy serves.
|
||||
proxy serves — and root-absolute dynamic `import("/...")` specifiers inside
|
||||
`<script>` bodies. The import is the one URL no other layer can reach: `<base>`
|
||||
does not apply to a `/`-rooted specifier and it is not a `fetch()`. SvelteKit's
|
||||
inline bootstrap is exactly this shape; without the rewrite the module loads
|
||||
from Codeman's root, 404s, and the app sits on its own loading spinner forever.
|
||||
Visible text is left alone: a `<pre>import("/x")</pre>` example is not a
|
||||
loader and is not rewritten.
|
||||
3. A small injected script rebases URLs built at **runtime**, which the first two
|
||||
cannot see: `fetch('/api/data')` and `new WebSocket('/live')`, but equally
|
||||
`card.innerHTML = '<img src="/api/hero">'`, `img.src = '/api/slide'`, and
|
||||
@@ -190,6 +202,16 @@ then every API call fails, which looks like the dashboard being broken.
|
||||
EventSource, normal markup, the DOM sinks a page uses to build markup at runtime,
|
||||
and `url()` inside stylesheets. Something that constructs requests by an unusual
|
||||
route can still slip through. Symptom: the page renders but a panel stays empty.
|
||||
- **Root-absolute URLs the proxy never sees.** Only the HTML is rewritten, and only
|
||||
literal `/`-rooted specifiers in it. Still escape: an `import()` built at runtime
|
||||
(`import('/' + name)`), an import written inside an external `.js`, a static
|
||||
`import x from "/x"` in an inline script, `navigator.serviceWorker.register("/sw.js")`,
|
||||
and `url(/img.png)` inside an external stylesheet. They cannot be relayed either —
|
||||
the masked frame's `Referer` carries no capability — so the failure is quiet: a
|
||||
blank page, or a spinner that never resolves. Codeman now logs
|
||||
`[Webview] <path> escaped the proxy` (once per path per five minutes) when such a
|
||||
request reaches its 404, which is the fastest way to tell this class apart from a
|
||||
dashboard that is genuinely broken.
|
||||
- **A root-absolute `url()` inside an inline `<style>` is not rescued.** Masking the
|
||||
page's URL (layer 5) trades away the `Referer` safety net of layer 4 for
|
||||
requests the shim cannot see, and only HTML is rewritten server-side. An
|
||||
|
||||
Reference in new issue
Block a user