fix: apply the review items for #711 at merge

- terminal-ui.js _applyKeyboardClip(): read container.clientHeight only while rows are held, so the release path and the setting-off path skip the forced layout on every render and cursor move
- constants.js keyboardClipPx JSDoc: drop the stray "ponytail:" marker, the note reads as plain text
- src/web/CLAUDE.md "Per-device vs synced settings": list keyboardHoldsRows among the per-device keys SettingsUpdateSchema does not declare

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Codeman maintainer committed 2026-10-27 01:21:51 +01:00
1 parent 3e334357e8
commit e8f66c6446
3 files changed
+4 -4

No files matched your search

+2 -2
View File
@@ -3389,8 +3389,8 @@ const KEYBOARD_CLIP_CURSOR_REACH = 2;
* - Reading history: the offset follows the scroll position, so the top of the
* scrollback is reachable and scrolling stays continuous.
*
* ponytail: recomputed on every render with no hysteresis; add some if a TUI's
* mid-redraw frames ever make the view jitter.
* Recomputed on every render with no hysteresis; add some if a TUI's mid-redraw
* frames ever make the view jitter.
*
* @param {{rows: number, cellHeight: number, viewHeight: number, cursorRow: number,
* lastContentRow: number, following: boolean, viewportY: number, baseY: number}} input
+1 -1
View File
@@ -6638,7 +6638,7 @@ Object.assign(CodemanApp.prototype, {
if (!container) return;
const rows = this._keyboardHeldRowsActive() ? this.terminal.rows : 0;
const cellHeight = rows ? this.terminal._core?._renderService?.dimensions?.css?.cell?.height : 0;
const viewHeight = container.clientHeight;
const viewHeight = rows ? container.clientHeight : 0;
let clip = 0;
if (cellHeight && viewHeight) {
const buffer = this.terminal.buffer.active;