fix(cli): a running server notices a CLI the installer just added

A running Codeman remembers a missing CLI for up to 5 minutes, so a status
poll never spawns a login shell, and its Run button reads that same memory.
So "Run fails, add the agent, Run again" kept saying the CLI was not
installed, right after the app had said it was ready.

install.sh now touches `cli-installed` in the data dir once a CLI has landed,
and resolve() leaves the backoff when that file's mtime changes. It is one
stat, inside the backoff branch, and buys one run of the chain, so a resolved
CLI never pays for it and a CLI that is still missing goes back to waiting.
Re-walking PATH during the backoff would have found hand installs too, but it
would put a synchronous stat of every PATH entry on the request path, where
one dead network mount freezes the server (#516), and execute candidates that
were already refused.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Codeman maintainer committed 2026-11-06 14:25:34 +01:00
1 parent 1157aa9ecd
commit d6226385c0
10 files changed
+198 -15

No files matched your search

+6 -5
View File
@@ -220,12 +220,13 @@ and the Dock icon bounces.
## Known limits
- **A new agent can take a few minutes to show up in a running Codeman.** The
server remembers that a CLI is missing, for up to 5 minutes after it last looked
- **A new agent can take a few minutes to show up in an older Codeman.** The server
remembers that a CLI is missing, for up to 5 minutes after it last looked
(`cliResolveRetryDelayMs`), so that a status poll never spawns a login shell. The
app cannot clear that from outside, so the screen after *Add a coding agent* says
so. An open Codeman page also needs a reload, because the list of installed
agents is part of the page.
installer's `cli-installed` marker ends that at once, but only for a server that
knows the marker, so the screen after *Add a coding agent* still mentions it. An
open Codeman page always needs a reload, because the list of installed agents is
part of the page.
- **Agents the app can add are the ones `--no-admin` can install.** OMP's macOS
install is Homebrew, so it is not offered, also on a Mac that has Homebrew.
- **Agents that install with npm use whichever Node.js the login shell finds.**
+1 -1
View File
@@ -1140,7 +1140,7 @@
: 'This app cannot install a coding agent on this Mac.'],
installing: ['Installing ' + name, installingLead],
added: [name === 'a coding agent' ? 'The coding agent is installed' : name + ' is installed',
'Codeman notices it within a few minutes: reload Codeman if it does not show up. You sign in the first time you start it.'],
'If Codeman does not list it yet, reload it, or give it a few minutes. You sign in the first time you start it.'],
failed: ['The install stopped', 'Its output is below. Try again, or follow the instructions on the agent’s own site.']
}[step] : {
preparing: ['Looking at this Mac', 'Getting the installer and checking what is already here.'],