fix: apply the review items for #681 at merge

_notePaneHistory JSDoc names the responses it skips (an error envelope on any path, a refresh that lost its owner, a pull whose select generation moved)
selectSession records the pane count only for a non-error envelope (capture.json?.success !== false), pinned in the static guard of test/pane-history-memory.test.ts; the two invariant paragraphs now name the tab switch beside the refresh and the pull

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Codeman maintainer committed 2026-10-24 14:02:21 +02:00
1 parent 84adb701d7
commit d41ad16818
3 files changed
+14 -5

No files matched your search

+4 -1
View File
@@ -78,7 +78,7 @@ describe('every terminal response feeds it (static guard)', () => {
expect(methodSource(APP, '_maybeRefetchFullHistory')).toContain('this._notePaneHistory?.(sessionId, payload);');
});
it('the refresh records the pane only once it still owns the terminal, and neither it nor the pull records an error envelope', () => {
it('the refresh records the pane only once it still owns the terminal, and no caller records an error envelope', () => {
// A refresh that lost its owner is older than what the switch back read; an
// error envelope has no count, and forgetting on it would hand a scroll back
// to the paging fallback (see _maybePageCliTranscript).
@@ -87,6 +87,9 @@ describe('every terminal response feeds it (static guard)', () => {
expect(ownerCheck).toBeGreaterThan(-1);
expect(refresh.indexOf('this._notePaneHistory?.(sessionId, data);')).toBeGreaterThan(ownerCheck);
expect(refresh).toContain('capture.json?.success !== false) this._notePaneHistory?.(sessionId, data);');
expect(methodSource(APP, 'selectSession')).toContain(
'capture.json?.success !== false) this._notePaneHistory?.(sessionId, data);'
);
expect(methodSource(APP, '_maybeRefetchFullHistory')).toContain(
'capture.json?.success !== false) this._notePaneHistory?.(sessionId, payload);'
);