mirror of
https://github.com/Ark0N/Codeman.git
synced 2026-11-17 11:49:33 +01:00
fix(settings): Apply cannot keep a later Save open, refreshes only after a saved PUT (review)
- Split the one-shot keep-open intent from the in-flight guard and consume it before the first await, so a Save clicked while an Apply is in flight closes the modal. - Refresh the dependent groups only when the settings PUT returned ok (_apiPut answers null or a non-ok response instead of throwing), and also when only the webhook save failed. - Find the 'Apply or Save' hint by a data marker, not its English text; add zh-CN strings for the new toast and title. - Tests run the real saveAppSettings() (Apply then Save mid-flight, a failed PUT, a webhook-only failure, a plain Save). - Narrow the changeset and JSDoc to MCP sync and CLI management; touch the tray comment, the architecture note and the wiki.
This commit is contained in:
1 parent
9c63c41283
commit
c75d62ce04
7 files changed
+157
-31
No files matched your search
@@ -3552,7 +3552,7 @@ html:is([data-skin="paper-gray"], [data-skin="solarized-light"], [data-skin="cat
|
||||
}
|
||||
|
||||
/* Save + Close are the two ways out of the sheet (save-and-close vs
|
||||
discard-and-close), hit in the same corner with the same thumb, so here —
|
||||
discard-and-close; Apply saves but keeps the sheet open), hit in the same corner with the same thumb, so here —
|
||||
and only here, since Save is header-only below 860px — they share a
|
||||
recessed tray and matching pill geometry instead of reading as a fat
|
||||
accent pill parked beside a stray × glyph. Tray colors come from skin
|
||||
|
||||
Reference in new issue
Block a user