mirror of
https://github.com/Ark0N/Codeman.git
synced 2026-11-20 04:59:34 +01:00
fix(tmux): read a one-binding key table from the full listing
A tmux built from master (`tmux -V`: next-3.7) prints nothing, exit 0, for `list-keys -T <table>` when the table holds exactly one binding. tmux 3.4 prints the line. One binding is the shape restrictTmuxPrefixTable leaves behind (`<prefix> send-prefix`), so on that tmux the reduced table read as needing a reset and every session create reset it again. `codeman tui` read its prefix table the same way, so readPrefixBinding called a bound key free and readDetachKey found no detach key. A blank answer is now read from the full `list-keys` listing, keeping only that table's lines. The parsers already match on `-T <table>`. Tests: recorded-command cases for the blank answer (reduced table kept, stray binding still reset) and TuiClient cases for both reads. The real-tmux helper reads tables through the same fallback, and the escaped `C-\` check accepts the unescaped form the full listing prints.
This commit is contained in:
1 parent
e99b42c387
commit
c497869ee5
6 files changed
+111
-9
No files matched your search
@@ -153,6 +153,16 @@ export function restrictTmuxPrefixTable(tmux: string, run: TmuxRunner = defaultR
|
||||
let listing: string | null;
|
||||
try {
|
||||
listing = run(`${tmux} list-keys -T prefix`);
|
||||
// ⚠️ Some tmux builds (a `next-3.7` development build) print NOTHING for
|
||||
// `list-keys -T prefix` when the table holds exactly one binding, which is the
|
||||
// shape this function leaves behind: read blank as "ask the full listing" and keep
|
||||
// only its prefix-table lines, or every call would reset an already-reduced table.
|
||||
if (!listing.trim()) {
|
||||
listing = run(`${tmux} list-keys`)
|
||||
.split('\n')
|
||||
.filter((line) => PREFIX_LINE.test(line.trim()))
|
||||
.join('\n');
|
||||
}
|
||||
} catch {
|
||||
listing = null; // an empty table makes list-keys fail on some tmux builds
|
||||
}
|
||||
|
||||
+15
-4
@@ -991,6 +991,19 @@ export class TuiClient {
|
||||
return null;
|
||||
}
|
||||
|
||||
/**
|
||||
* One key table as `list-keys` prints it. ⚠️ Some tmux builds (seen on a `next-3.7`
|
||||
* development build) print NOTHING for `list-keys -T <table>` when the table holds
|
||||
* exactly one binding, which is the shape Codeman reduces the prefix table to. So a
|
||||
* blank answer is retried as the full listing: every line there names its table,
|
||||
* and both parsers already filter on it.
|
||||
*/
|
||||
private async listKeyTable(table: TuiKeyTable): Promise<string> {
|
||||
const { stdout } = await this.exec('tmux', ['-L', this.socket, 'list-keys', '-T', table]);
|
||||
if (stdout.trim()) return stdout;
|
||||
return (await this.exec('tmux', ['-L', this.socket, 'list-keys'])).stdout;
|
||||
}
|
||||
|
||||
/**
|
||||
* The key that detaches, straight from tmux's own key table. Key tables are
|
||||
* server-global, so unlike the prefix this takes no session. A failure is
|
||||
@@ -998,8 +1011,7 @@ export class TuiClient {
|
||||
*/
|
||||
async readDetachKey(): Promise<string | null> {
|
||||
try {
|
||||
const { stdout } = await this.exec('tmux', ['-L', this.socket, 'list-keys', '-T', 'prefix']);
|
||||
return parseDetachKey(stdout);
|
||||
return parseDetachKey(await this.listKeyTable('prefix'));
|
||||
} catch {
|
||||
return null;
|
||||
}
|
||||
@@ -1012,8 +1024,7 @@ export class TuiClient {
|
||||
*/
|
||||
async readPrefixBinding(key: string, table: TuiKeyTable = 'prefix'): Promise<string | null> {
|
||||
try {
|
||||
const { stdout } = await this.exec('tmux', ['-L', this.socket, 'list-keys', '-T', table]);
|
||||
return parsePrefixBinding(stdout, key, table);
|
||||
return parsePrefixBinding(await this.listKeyTable(table), key, table);
|
||||
} catch {
|
||||
return null;
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user