From c1fde8e6394304f843a18e51babc70c076a2b89f Mon Sep 17 00:00:00 2001 From: Codeman maintainer Date: Tue, 13 Oct 2026 17:23:25 +0200 Subject: [PATCH] test(file-preview): give the stubbed harnesses rendersAsPage() Three suites load panels-ui.js without constants.js and stub the globals it uses (escapeHtml, CodemanBase). openFilePreview() now asks rendersAsPage() from constants.js, so those stubs need it too; none of their files is an HTML page, so it answers false. Co-Authored-By: Claude Opus 5.5 (1M context) --- test/file-preview-detach.test.ts | 2 ++ test/file-preview-media.test.ts | 2 ++ test/spreadsheet-preview.test.ts | 2 ++ 3 files changed, 6 insertions(+) diff --git a/test/file-preview-detach.test.ts b/test/file-preview-detach.test.ts index 9f80537c..6e3fce42 100644 --- a/test/file-preview-detach.test.ts +++ b/test/file-preview-detach.test.ts @@ -40,6 +40,8 @@ function loadApp() { escapeHtml: (s: string) => String(s), // Reverse-proxy route builder from constants.js (not loaded here); identity at root. CodemanBase: { base: '', url: (p: string) => p }, + // Also from constants.js: no file in this suite renders as an HTML page. + rendersAsPage: () => false, document: { getElementById: () => null, addEventListener: vi.fn() }, window: windowStub, setTimeout, diff --git a/test/file-preview-media.test.ts b/test/file-preview-media.test.ts index 33af4591..752b276e 100644 --- a/test/file-preview-media.test.ts +++ b/test/file-preview-media.test.ts @@ -66,6 +66,8 @@ function loadApp(media: FakeMedia[]) { escapeHtml: (s: string) => String(s), // Reverse-proxy route builder from constants.js (not loaded here); identity at root. CodemanBase: { base: '', url: (p: string) => p }, + // Also from constants.js: no file in this suite renders as an HTML page. + rendersAsPage: () => false, document: { getElementById: () => null, addEventListener: vi.fn() }, window: { addEventListener: vi.fn() }, setTimeout, diff --git a/test/spreadsheet-preview.test.ts b/test/spreadsheet-preview.test.ts index e6c904a2..882db214 100644 --- a/test/spreadsheet-preview.test.ts +++ b/test/spreadsheet-preview.test.ts @@ -594,6 +594,8 @@ describe('file-preview overlay spreadsheet wiring', () => { console, escapeHtml: (value: unknown) => String(value ?? ''), CodemanBase: { base: '', url: (p: string) => p }, + // From constants.js (not loaded here): a workbook never renders as an HTML page. + rendersAsPage: () => false, fetch: fetchMock, setTimeout, clearTimeout,