From af682d77ae9033f69531a386ef3ffb255a7d8fc9 Mon Sep 17 00:00:00 2001 From: Codeman maintainer Date: Sat, 24 Oct 2026 14:41:32 +0200 Subject: [PATCH] fix: address the release-prep review of #699 terminal-ui.js: the _maybePageCliTranscript JSDoc names PAGE_KEY_NOTCH_DEBT_MS as the stretched gap after a notch-sized opener terminal-scroll-routing.test.ts: the notch-opener test comment uses the real numbers (36 rows, 14 rows owed) Co-Authored-By: Claude Opus 5.5 (1M context) --- src/web/public/terminal-ui.js | 5 +++-- test/terminal-scroll-routing.test.ts | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/web/public/terminal-ui.js b/src/web/public/terminal-ui.js index 9b5dd1ca..3dac785a 100644 --- a/src/web/public/terminal-ui.js +++ b/src/web/public/terminal-ui.js @@ -6076,8 +6076,9 @@ Object.assign(CodemanApp.prototype, { * never sent a key at all. That page is pre-paid: the travel it skipped is * owed back by the rest of the gesture, so the rate stays one page per * `perPage` rows. A new touch contact (`ev.touchId`), a pause outside a contact - * (PAGE_KEY_GESTURE_GAP_MS, or PAGE_KEY_DEBT_MS while a same-direction page is - * still owed), a reversal after the gap or a tab switch starts a new gesture; + * (PAGE_KEY_GESTURE_GAP_MS; while a same-direction page is still owed, + * PAGE_KEY_DEBT_MS, or PAGE_KEY_NOTCH_DEBT_MS when a notch-sized opener pre-paid + * it), a reversal after the gap or a tab switch starts a new gesture; * one contact is never split by time, and a quick reversal never pre-pays. A * mouse-wheel notch pages at once too, and its debt (PAGE_KEY_NOTCH_DEBT_MS) is repaid by the * notches after it, so a mouse pages once per `perPage` rows of travel with the diff --git a/test/terminal-scroll-routing.test.ts b/test/terminal-scroll-routing.test.ts index 8be908e7..9f30dbe5 100644 --- a/test/terminal-scroll-routing.test.ts +++ b/test/terminal-scroll-routing.test.ts @@ -695,8 +695,9 @@ describe('pageKeysForGesture, the pure gesture rules both panes share', () => { }); it('pages a notch-sized opening event at once, and the notches after it repay it', () => { - // Five 4-row notches 400 ms apart: the first pays the page, the next four (16 of the 15 rows - // owed on 38 rows) repay it, and none of them pages again. + // Five 4-row notches 400 ms apart: the first pays the page, the next four (16 rows of travel + // against the 14 owed on 36 rows, half a screen less the opener's 4) repay it, and none of them + // pages again. const steps = run([ [-4, 0], [-4, 400],