From 9442ea8cf45cee5eac16bab641e6a092eed0a6e6 Mon Sep 17 00:00:00 2001 From: Codeman maintainer Date: Fri, 6 Nov 2026 08:20:39 +0100 Subject: [PATCH] fix: remove the em-dashes this release added (release review) 105 new em-dashes sat in comments, test names and one test fixture from the foreign tmux adoption work. Replaced by hand with commas, colons or parentheses, one reading at a time. The fixture now quotes the real refusal text, which says "It may still be running, try again." Co-Authored-By: Claude Opus 5.5 --- src/foreign-tmux-discovery.ts | 10 ++-- src/foreign-tmux.ts | 54 ++++++++++----------- src/reboot-restore.ts | 2 +- src/remote-files.ts | 2 +- src/session.ts | 4 +- src/tmux-manager.ts | 6 +-- src/types/foreign-tmux.ts | 8 +-- src/types/session.ts | 6 +-- src/web/public/app.js | 2 +- src/web/public/foreign-sessions.js | 26 +++++----- src/web/public/mobile-overview.js | 2 +- src/web/public/mobile.css | 2 +- src/web/public/styles.css | 2 +- src/web/public/terminal-ui.js | 2 +- src/web/routes/mux-routes.ts | 6 +-- src/web/routes/ralph-routes.ts | 2 +- src/web/routes/respawn-routes.ts | 6 +-- src/web/routes/session-routes.ts | 4 +- src/web/server.ts | 4 +- src/web/session-wait-registry.ts | 2 +- test/docker-adopted-container.test.ts | 2 +- test/foreign-adoption-guards.test.ts | 4 +- test/foreign-sessions-ui.test.ts | 6 +-- test/foreign-tmux.test.ts | 22 ++++----- test/mocks/mock-route-context.ts | 2 +- test/mocks/mock-session.ts | 2 +- test/routes/foreign-adoption-routes.test.ts | 8 +-- 27 files changed, 99 insertions(+), 99 deletions(-) diff --git a/src/foreign-tmux-discovery.ts b/src/foreign-tmux-discovery.ts index 5bfbfa38..17d2662a 100644 --- a/src/foreign-tmux-discovery.ts +++ b/src/foreign-tmux-discovery.ts @@ -9,7 +9,7 @@ * * The home screen shows LOCAL results automatically, so a local scan runs on a * TTL cache: N browser tabs polling every few seconds still trigger at most one - * scan per `FOREIGN_CACHE_TTL_MS`. Docker and remote are ON DEMAND only — + * scan per `FOREIGN_CACHE_TTL_MS`. Docker and remote are ON DEMAND only: * opening the home page must never fan out one ssh connection per saved host. * * ## ⚠️ The probe must not cross an extra shell @@ -18,7 +18,7 @@ * expand. Local and docker therefore spawn with an argv array, where no outer * shell exists to eat them first. Remote is the exception: the ssh * command line is a string like every other ssh call in this codebase, so the - * script is wrapped in SINGLE quotes there — which is exactly why + * script is wrapped in SINGLE quotes there, which is exactly why * `buildForeignProbeScript()` may not contain one. * * This was measured, not reasoned: running the probe through `execSync` (which @@ -316,7 +316,7 @@ export function foreignDockerProbeArgv(target: DockerTargetInfo): string[] { * Scan the containers behind the caller's docker cases. On demand only. * * Read-only by construction: one `docker exec` running the probe. Never inspects - * lifecycle, never starts anything — a stopped or missing container simply + * lifecycle, never starts anything: a stopped or missing container simply * contributes a note, mirroring `probeAdoptableContainer`'s "engine unreachable * degrades to an empty list" rule. */ @@ -372,7 +372,7 @@ export function foreignRemoteProbeCommand(host: RemoteHost): string { } /** - * Scan saved ssh hosts. On demand only — this is the expensive one. + * Scan saved ssh hosts. On demand only: this is the expensive one. * * ⚠️ The ssh command is a STRING (as every ssh call in this codebase is), so the * probe crosses one extra shell and must be single-quoted. `shellescape` does @@ -416,7 +416,7 @@ export async function discoverRemoteForeign(hosts: RemoteHost[]): Promise '