mirror of
https://github.com/Ark0N/Codeman.git
synced 2026-11-20 04:59:34 +01:00
fix(deepseek): only exchange a banner for the spawned loopback port
The launch URL comes from the child's output but fetching it is a request made by the Codeman server, so a banner naming another host or another local service could aim it. Require 127.0.0.1 and the port just spawned before the exchange runs, and mark the server as unusable for reuse if the check fails.
This commit is contained in:
1 parent
b1bcd1e3af
commit
7f729ee87b
4 files changed
+92
-6
No files matched your search
@@ -209,6 +209,24 @@ export function parseLaunchUrl(output: string): string | null {
|
||||
return new URL(href).searchParams.get('token') ? href : null;
|
||||
}
|
||||
|
||||
/**
|
||||
* Whether a launch URL names the loopback port this supervisor just spawned.
|
||||
*
|
||||
* The URL is read from the child's output, but fetching it is a request made by
|
||||
* the SERVER. A banner naming another host, or another local service's port, must
|
||||
* not turn that exchange into an SSRF primitive, so the target is required to be
|
||||
* the exact origin the token was minted for.
|
||||
*/
|
||||
export function launchUrlTargetsServer(launchUrl: string, port: number): boolean {
|
||||
try {
|
||||
const url = new URL(launchUrl);
|
||||
const effectivePort = Number(url.port || (url.protocol === 'https:' ? 443 : 80));
|
||||
return url.hostname === '127.0.0.1' && effectivePort === port;
|
||||
} catch {
|
||||
return false;
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Trade the launch URL for the `dsh-auth-*` cookie the proxy will present.
|
||||
*
|
||||
@@ -257,6 +275,13 @@ async function captureSessionCookie(running: RunningServer): Promise<{ cookie: s
|
||||
const complete = banner.slice(0, banner.lastIndexOf('\n') + 1);
|
||||
const launchUrl = parseLaunchUrl(complete);
|
||||
if (launchUrl) {
|
||||
if (!launchUrlTargetsServer(launchUrl, running.port)) {
|
||||
console.warn(
|
||||
'[DeepSeek web] the printed launch URL does not name the loopback port this server was started on; ' +
|
||||
'not fetching it'
|
||||
);
|
||||
return { cookie: null, failed: true };
|
||||
}
|
||||
const cookie = await exchangeLaunchToken(launchUrl);
|
||||
// The URL is a credential: never log it, only the fact that it did not work.
|
||||
if (!cookie) {
|
||||
|
||||
Reference in new issue
Block a user