From 70dc42b248be767060a6e32f150aabc24b14d95a Mon Sep 17 00:00:00 2001 From: Codeman maintainer Date: Tue, 10 Nov 2026 23:52:14 +0100 Subject: [PATCH] feat(local-model): a library of models, with one in use The local model window could hold one model. A second install was refused (409 already-installed), and a model a Remove kept could never be freed from the window again. The store can now hold several models, and exactly one of them is the model in use: the one the endpoint record lists, the runtime is started for and a session may be launched on. Server - LocalModelStateFile.library lists every model that passed the check (id, label, context, digest, size, coding agent). The service writes the entry when verify passes; the reducer carries it and remove drops it. An installed file of an earlier build counts its one model. - POST /api/local-model/install is allowed from installed: it adds a model, and the earlier one stays. A replaced job no longer deletes a model of the library, only an unchecked or partial download. - POST /api/local-model/use switches to a checked model: a job of the two steps verify and connect. The stored digest is compared before anything is loaded (model-changed otherwise). Nothing is downloaded. - DELETE /api/local-model/models deletes one model by its name, through the runtime's own delete, never by a path, never the model in use. - Adding and switching answer 409 sessions-open while a live session uses the endpoint. Until such a job ends installed, a session start is refused with the new code job-unfinished. - The view carries library (the state's entries joined with what the running runtime lists: ready, changed, missing, unverified) and store (the size of the blob folder). Both are cached and refreshed in the background, never read on the one-second poll. - With nothing installed, remove is offered while the store still holds models an earlier Remove kept. Window - The installed screen lists the models on this Mac with the context each was checked with, its state and its size on disk, with Use and Delete per row (Delete asks once, in the row) and Add a model. - In the chooser a model that is on this Mac already says so and is switched to without a download or a confirm screen. - A paused or failed job that has a checked model beside it shows the way back to that model. Every route is admin only in multi-user mode, like the existing ones. Not run on a Mac: the tests use fakes and the fake runtime, and the listing, store size and delete were checked against a real Ollama 0.13.0 on Linux, not the pinned 0.40.15 build for macOS. Co-Authored-By: Claude Fable 5.2 --- src/local-model/install-job.ts | 761 ++++++++++++++++++++--- src/local-model/runtime.ts | 39 ++ src/local-model/state-store.ts | 39 ++ src/types/local-model-install.ts | 157 ++++- src/types/local-model.ts | 6 + src/web/public/i18n.js | 45 +- src/web/public/local-model-ui.js | 375 ++++++++++- src/web/public/mobile.css | 60 ++ src/web/public/styles.css | 206 ++++++ src/web/routes/local-model-routes.ts | 47 +- src/web/schemas.ts | 6 + test/fixtures/fake-ollama.ts | 132 ++-- test/local-model-install-e2e.test.ts | 150 ++++- test/local-model-install-job.test.ts | 481 +++++++++++++- test/local-model-install-service.test.ts | 718 ++++++++++++++++++++- test/local-model-runtime.test.ts | 54 ++ test/local-model-state-store.test.ts | 83 +++ test/local-model-ui.browser.test.ts | 173 +++++- test/local-model-ui.test.ts | 563 ++++++++++++++++- test/routes/local-model-routes.test.ts | 194 +++++- 20 files changed, 4088 insertions(+), 201 deletions(-) diff --git a/src/local-model/install-job.ts b/src/local-model/install-job.ts index 77efab96..66cba2e1 100644 --- a/src/local-model/install-job.ts +++ b/src/local-model/install-job.ts @@ -6,6 +6,14 @@ * runtime, model, verify, agent, connect; `agent` is left out when the coding agent is * installed). Its state is one of five (`LocalModelInstallState`), stored in the state file. * + * A LIBRARY with ONE model in use. The store can hold several models; exactly one of them is + * the model in use: the one the saved endpoint record lists, the runtime is started for and a + * session may be launched on. `LocalModelStateFile.library` lists every model that passed the + * check through Codeman. A job makes its model the one in use when it ends: an install (also + * from `installed`, which adds a model and keeps the earlier ones) or a switch (`use`, the two + * steps `USE_JOB_STEPS`: nothing is downloaded, the model is loaded and checked again and its + * digest must still be the stored one). + * * The state table. "On disk" names what lies under the local model folder; the two writes * outside it belong to the `connect` step. * @@ -17,12 +25,15 @@ * | | the current step has written so far | same step; nothing resumes | the same step | | * | | (see the step table) | without a click | | | * | `paused` | as `installing` at that step, nothing in | stays `paused` | refused (409) | resume, install (another | - * | | flight | | | choice), remove | + * | | flight | | | choice), use (a checked model), | + * | | | | | delete a model, remove | * | `failed` | as `installing` at that step, nothing in | stays `failed`, same error | refused (409) | resume (try again), install | - * | | flight | | | (another choice), remove | + * | | flight | | | (another choice), use, delete a | + * | | | | | model, remove | * | `installed` | the runtime, the private home, the model | stays `installed`; the | refused (409) | start a session, start or stop | - * | | | runtime is started again | | the runtime, remove | - * | | | when it was not stopped | | | + * | | in use and every other model of the | runtime is started again | | the runtime, install (add a | + * | | library | when it was not stopped | | model), use, delete a model, | + * | | | | | remove | * * The step table. Every step is IDEMPOTENT, so Resume and "Try again" re-enter the step the * job stopped in; they first make sure the runtime runs when the step needs it. @@ -62,10 +73,23 @@ * `mutateLocalModelState()` and never change the state. * - A job read as `installing` at boot was interrupted by the restart: the service applies * the event `restart` before anything else, so it is `paused` and waits for a click. - * - A new install from `paused` or `failed` REPLACES the job. When it names another model, - * what the old job left of its model is deleted from the store first: the model through the - * runtime when it was downloaded whole, and the partial blobs of a download that was - * interrupted (the runtime knows no model for those, so they are deleted as files). + * - A new install or a switch from `paused` or `failed` REPLACES the job. When it names another + * model, what the old job left of its model is deleted from the store first: the model + * through the runtime when it was downloaded whole, and the partial blobs of a download that + * was interrupted (the runtime knows no model for those, so they are deleted as files). A + * model of the library is never deleted that way: it was checked, and it stays until the + * person deletes it. + * - Installing another model and switching change which model the runtime holds (it holds + * one), and often its context. Both are refused (409 `sessions-open`) while live sessions + * use the endpoint, like Stop: their coding agents were started with the other model's name. + * - While a job that started from `installed` is not finished (`installing`, `paused`, + * `failed`), no session is started: the launch check wants the state `installed`. `use` on + * the earlier model is the way back. + * - A model is deleted ONLY through the runtime (`deleteModel()`), by a name that is in the + * server's own listing (the library or the runtime's tags), never by a path. The model of + * the installation or of the current job is refused (`model-active`): switch first, or + * Remove. Deleting moves no state: it is not an event of the reducer, and whether a state + * allows it is the `delete-model` action of its row in `INSTALL_STATE_TABLE`. * - Install is checked before anything is downloaded: admin only in multi-user mode; the * model, the context and the coding agent must be a row the current recommendation offers; * the coding agent must be a harness row of the catalogue; `acknowledgedBytes` must be the @@ -106,6 +130,10 @@ * process runs no job, which is what a restart leaves too. * - Stop and "Use another port" are refused (409 `sessions-open`) while live sessions use * the model: their coding agents were given the address when they started. + * - The view's `library` joins the state file's checked models with what the running runtime + * lists, and `store` is the disk use of the blob folder. Neither is asked for on every + * one-second poll: both are cached (`TAGS_RECHECK_MS`, `STORE_RECHECK_MS`), refreshed in the + * background, and thrown away by every verb and step that changes them. */ import { appendAdminAudit } from '../web/admin-audit.js'; @@ -120,7 +148,7 @@ import { } from '../cli-install-runner.js'; import { getCli } from '../config/cli-registry/registry.js'; import { getDataDir } from '../config/instance.js'; -import { getLocalModelCatalog } from '../config/local-model-catalog.js'; +import { getLocalModelCatalog, LOCAL_MODEL_ID_PATTERN } from '../config/local-model-catalog.js'; import { readCustomModelHosts } from '../custom-model-hosts.js'; import { getErrorMessage, @@ -135,6 +163,7 @@ import { type LocalModelAction, type LocalModelCatalog, type LocalModelConflict, + type LocalModelDeleteRequest, type LocalModelDeveloperTools, type LocalModelErrorCode, type LocalModelInstallError, @@ -143,6 +172,9 @@ import { type LocalModelInstallState, type LocalModelInstallStep, type LocalModelInstallView, + type LocalModelLibraryAction, + type LocalModelLibraryEntry, + type LocalModelLibraryRow, type LocalModelNextStep, type LocalModelProgress, type LocalModelRemoveRequest, @@ -150,6 +182,7 @@ import { type LocalModelRuntimePin, type LocalModelRuntimeRequest, type LocalModelStateFile, + type LocalModelUseRequest, type Recommendation, type RecommendOptions, } from '../types.js'; @@ -177,10 +210,12 @@ import { getRuntimeVersion, listOpenAiModels, listRunning, + listTags, pullModel, readModelDigest, verifyModel, type OllamaPsModel, + type OllamaTagModel, type OllamaTarget, type PullOptions, type PullResult, @@ -193,6 +228,7 @@ import { createRuntimeSupervisor, ensureRuntimeInstalled, isRuntimeInstalled, + measureModelStore, OLLAMA_RUNTIME_PIN, removeLocalModelFiles, removePartialModelBlobs, @@ -224,7 +260,9 @@ export interface InstallStateRow { /** * Every action a client may take in this state. The view's `actions` is this list narrowed * by what is live (`allowedActions()`): `start` only while the runtime is down, `stop` and - * `start-session` only while it runs, `start-session` only when nothing blocks a session. + * `start-session` only while it runs, `start-session` only when nothing blocks a session, + * `use` and `delete-model` only while a row of the library offers them, and in `idle` + * `remove` only while the model store still holds something. */ actions: readonly LocalModelAction[]; } @@ -238,7 +276,7 @@ export const INSTALL_STATE_TABLE: Readonly entry.id === model.id)) { + entries.unshift({ + id: model.id, + label: model.label, + context: model.context, + digest: model.digest, + ...(model.pullBytes ? { bytes: model.pullBytes } : {}), + ...(state.cli ? { cli: state.cli } : {}), + }); + } + return entries; +} + +/** `library` with `entry` in the place of the one with its id, or at the end. Pure. */ +export function upsertLibraryEntry( + library: readonly LocalModelLibraryEntry[], + entry: LocalModelLibraryEntry +): LocalModelLibraryEntry[] { + const index = library.findIndex((existing) => existing.id === entry.id); + if (index === -1) return [...library, entry]; + const next = [...library]; + next[index] = entry; + return next; +} + +/** + * The model whose leftovers a new job for `nextId` deletes from the store first: the model of + * the job it replaces when that is another model, else one that was already waiting to be + * deleted. Never a model of the library (it was checked and stays until the person deletes + * it), and never the model that is wanted now. Pure. + */ +function replacedModelFor( + current: LocalModelStateFile, + nextId: string, + library: readonly LocalModelLibraryEntry[] +): string | undefined { + const checked = (id: string): boolean => library.some((entry) => entry.id === id); + const replaced = + current.model && current.model.id !== nextId && !checked(current.model.id) ? current.model.id : undefined; + const pending = replaced ?? current.replacedModelId; + return pending !== undefined && pending !== nextId && !checked(pending) ? pending : undefined; +} + /** The steps a job runs, in order: all of `LOCAL_MODEL_INSTALL_STEPS`, without `agent` when the coding agent is installed. Pure. */ export function jobSteps(input: { agentInstalled: boolean }): LocalModelInstallStep[] { return LOCAL_MODEL_INSTALL_STEPS.filter((step) => step !== 'agent' || !input.agentInstalled); @@ -446,12 +551,13 @@ const isByteCount = (value: number): boolean => Number.isSafeInteger(value) && v /** * The state file after `event`. Pure: no IO, no clock (`updatedAt` is the state store's * business). Refuses an event the transition table does not list for the current state by - * returning `current` itself. Keeps `runtime` and `connection` across a new install, because - * what they record is still on disk; `remove` drops everything. + * returning `current` itself. Keeps `runtime`, `connection` and `library` across a new install + * or a switch, because what they record is still on disk; `remove` drops everything. * * An event that is listed but cannot be applied is refused the same way: an `install` whose - * steps are not a job's, a `progress` that is not two byte counts, a `step-done` on a state - * without a step, and a last `step-done` on a job that has no runtime recorded. + * steps are not a job's, a `use` of a model that is not in the library or on a state without a + * runtime, a `progress` that is not two byte counts, a `step-done` on a state without a step, + * and a last `step-done` on a job that has no runtime recorded. */ export function reduceInstallJob(current: LocalModelStateFile, event: InstallJobEvent): LocalModelStateFile { if (INSTALL_TRANSITIONS[current.state][event.type] === undefined) return current; @@ -465,9 +571,10 @@ export function reduceInstallJob(current: LocalModelStateFile, event: InstallJob ) { return current; } - // What the replaced job left of ANOTHER model is deleted before the new one is pulled. - const pending = current.model && current.model.id !== event.model.id ? current.model.id : current.replacedModelId; - const replacedModelId = pending !== undefined && pending !== event.model.id ? pending : undefined; + // What the replaced job left of ANOTHER model is deleted before the new one is pulled, + // unless that model is one of the library. + const library = libraryOf(current); + const replacedModelId = replacedModelFor(current, event.model.id, library); return { schema: 1, state: 'installing', @@ -477,6 +584,30 @@ export function reduceInstallJob(current: LocalModelStateFile, event: InstallJob ...(replacedModelId ? { replacedModelId } : {}), cli: { id: event.cli.id, label: event.cli.label }, ...(current.runtime ? { runtime: current.runtime } : {}), + ...(library.length > 0 ? { library } : {}), + ...(current.connection ? { connection: current.connection } : {}), + }; + } + case 'use': { + const library = libraryOf(current); + // Only a checked model can be switched to, and only where a runtime was set up. + if (!current.runtime || !library.some((entry) => entry.id === event.model.id)) return current; + const replacedModelId = replacedModelFor(current, event.model.id, library); + return { + schema: 1, + state: 'installing', + step: USE_JOB_STEPS[0], + steps: [...USE_JOB_STEPS], + model: { + id: event.model.id, + label: event.model.label, + context: event.model.context, + digest: event.model.digest, + }, + ...(replacedModelId ? { replacedModelId } : {}), + cli: { id: event.cli.id, label: event.cli.label }, + runtime: current.runtime, + library, ...(current.connection ? { connection: current.connection } : {}), }; } @@ -501,6 +632,7 @@ export function reduceInstallJob(current: LocalModelStateFile, event: InstallJob cli: current.cli, runtime: current.runtime, ...(current.loaded ? { loaded: current.loaded } : {}), + ...(current.library ? { library: current.library } : {}), ...(current.connection ? { connection: current.connection } : {}), }; } @@ -553,6 +685,16 @@ export interface InstallLiveFacts { pin: LocalModelRuntimePin; /** `LocalModelPaths.root`, for the "where it goes" line. */ folder: string; + /** + * What the RUNNING runtime lists on disk (`/api/tags`), as last read. Absent while the + * runtime is down or before the first read: the library then shows the state file's entries + * as they were recorded, and offers no delete. + */ + tags?: readonly { name: string; size: number; digest: string }[]; + /** What the model store takes on disk (`measureModelStore()`), once measured. */ + storeBytes?: number; + /** The catalogue's label per model id, for a model the runtime lists and the state file does not know. */ + labels?: Readonly>; } /** An error code with its sentence, its slots and its one next step. Pure. */ @@ -604,12 +746,96 @@ export function installedBlocker( return undefined; } -/** The actions the server accepts right now: the state row's list narrowed by what is live. Pure. */ -export function allowedActions(state: LocalModelStateFile, live: InstallLiveFacts): LocalModelAction[] { +/** + * The models on this Mac, for the view: the checked models of the state file joined with what + * the running runtime lists. The model in use first, then the other checked models in the + * order they were checked, then what the runtime lists beside them, by name. Pure. + * + * What a row offers: + * - `use`: a checked model the runtime does not contradict (`ready`), in a state whose row of + * `INSTALL_STATE_TABLE` lists `use`, unless it is the model of the installation (in use + * already) or of the stopped job (Resume goes on with that one). + * - `delete`: any model the running runtime lists, in a state that lists `delete-model`, + * unless it is the model of the installation or of the current job, and unless its name is + * not a plain `name:tag` (`LOCAL_MODEL_ID_PATTERN`): the delete route takes no other name. + * A checked model the runtime no longer lists (`missing`) can be deleted too: that drops + * its entry. + */ +export function buildLibraryRows(state: LocalModelStateFile, live: InstallLiveFacts): LocalModelLibraryRow[] { + if (state.state === 'idle') return []; + const stateActions = INSTALL_STATE_TABLE[state.state].actions; + const tags = live.running ? live.tags : undefined; + const jobModelId = state.model?.id; + const canDelete = (id: string): boolean => + stateActions.includes('delete-model') && tags !== undefined && id !== jobModelId && LOCAL_MODEL_ID_PATTERN.test(id); + const sized = (bytes: number | undefined): Pick => + bytes !== undefined && bytes > 0 ? { sizeBytes: bytes, sizeGb: formatGb(bytes) } : {}; + + const rows: LocalModelLibraryRow[] = []; + const entries = libraryOf(state); + for (const entry of entries) { + const tag = tags?.find((listed) => listed.name === entry.id); + const active = state.state === 'installed' && entry.id === jobModelId; + let status: LocalModelLibraryRow['status'] = 'ready'; + if (tags !== undefined) { + if (!tag) status = 'missing'; + else if (compareModelDigest(entry.digest, tag.digest) === 'changed') status = 'changed'; + } + // The model in use is compared on its own schedule too: what blocks a session says so here. + if (active && live.digest === 'changed') status = 'changed'; + const actions: LocalModelLibraryAction[] = []; + // The model of the installation is in use already, and the model of a stopped job is + // what Resume goes on with: a switch is offered to every OTHER checked model. + if (stateActions.includes('use') && status === 'ready' && entry.id !== jobModelId) actions.push('use'); + if (canDelete(entry.id)) actions.push('delete'); + rows.push({ + id: entry.id, + label: entry.label, + context: entry.context, + ...sized(tag && tag.size > 0 ? tag.size : entry.bytes), + active, + verified: true, + status, + actions, + }); + } + rows.sort((a, b) => Number(b.active) - Number(a.active)); + + const others = (tags ?? []) + .filter((listed) => !entries.some((entry) => entry.id === listed.name)) + .sort((a, b) => (a.name < b.name ? -1 : a.name > b.name ? 1 : 0)); + for (const listed of others) { + rows.push({ + id: listed.name, + label: + live.labels?.[listed.name] ?? (listed.name === jobModelId && state.model ? state.model.label : listed.name), + ...sized(listed.size), + active: false, + verified: false, + status: 'unverified', + actions: canDelete(listed.name) ? ['delete'] : [], + }); + } + return rows; +} + +/** + * The actions the server accepts right now: the state row's list narrowed by what is live. + * `rows` is `buildLibraryRows()` of the same two arguments, for a caller that has it. Pure. + */ +export function allowedActions( + state: LocalModelStateFile, + live: InstallLiveFacts, + rows: readonly LocalModelLibraryRow[] = buildLibraryRows(state, live) +): LocalModelAction[] { const actions = INSTALL_STATE_TABLE[state.state].actions; - if (state.state !== 'installed') return [...actions]; const blocked = installedBlocker(state, live) !== undefined; return actions.filter((action) => { + if (action === 'use') return rows.some((row) => row.actions.includes('use')); + if (action === 'delete-model') return rows.some((row) => row.actions.includes('delete')); + // From idle a Remove only clears what an earlier one kept: offered while there is something. + if (state.state === 'idle') return action !== 'remove' || (live.storeBytes ?? 0) > 0; + if (state.state !== 'installed') return true; if (action === 'start') return !live.running; if (action === 'stop') return live.running; if (action === 'start-session') return live.running && !blocked; @@ -640,6 +866,7 @@ function buildProgress( /** The `install` object of the GET. Pure: every size text comes from `formatGb()`, every sentence from `LOCAL_MODEL_INSTALL_LABELS`. */ export function buildInstallView(state: LocalModelStateFile, live: InstallLiveFacts): LocalModelInstallView { const runtimeDownload = live.runtimeInstalled ? 0 : live.pin.bytes; + const library = buildLibraryRows(state, live); const view: LocalModelInstallView = { state: state.state, running: live.running, @@ -652,7 +879,9 @@ export function buildInstallView(state: LocalModelStateFile, live: InstallLiveFa unpackedGb: formatGb(live.pin.unpackedBytes), }, folder: live.folder, - actions: allowedActions(state, live), + library, + ...(live.storeBytes !== undefined ? { store: { bytes: live.storeBytes, gb: formatGb(live.storeBytes) } } : {}), + actions: allowedActions(state, live, library), }; if (state.state === 'idle') return view; @@ -699,6 +928,28 @@ export function buildInstallView(state: LocalModelStateFile, live: InstallLiveFa return view; } +/** + * `recommendation` with every row marked that is a checked model of the library at the row's + * context (`Candidate.library`): `active` for the model in use, `ready` for one a switch can + * take. The chooser then says the model is on this Mac and switches without a download. A + * recommendation with nothing to mark is handed back as it is. Pure. + */ +export function markLibraryCandidates(recommendation: Recommendation, view: LocalModelInstallView): Recommendation { + const mark = (candidate: Candidate): Candidate => { + const row = view.library.find( + (entry) => entry.verified && entry.id === candidate.modelId && entry.context === candidate.context + ); + if (!row) return candidate; + if (row.active) return { ...candidate, library: 'active' }; + return row.actions.includes('use') ? { ...candidate, library: 'ready' } : candidate; + }; + if (view.library.length === 0 || !recommendation.pick) return recommendation; + const pick = mark(recommendation.pick); + const alternatives = recommendation.alternatives.map(mark); + const changed = pick !== recommendation.pick || alternatives.some((row, i) => row !== recommendation.alternatives[i]); + return changed ? { ...recommendation, pick, alternatives } : recommendation; +} + /** A sentence of the install as plain English text, its slots filled. For an API error message and the log. Pure. */ export function formatInstallMessage(message: LocalModelInstallMessage): string { const vars = message.vars ?? {}; @@ -718,8 +969,11 @@ export interface LocalModelActor { /** How a verb ended: the view after it, a refusal with its sentence, or a 409 with its conflict. */ export type LocalModelVerbResult = | { ok: true; view: LocalModelInstallView } - /** 400: the request is not something the server offers. 507: nothing could be started because the disk is full. */ - | { ok: false; status: 400 | 507; message: LocalModelInstallMessage } + /** + * 400: the request is not something the server offers. 507: nothing could be started because + * the disk is full. 500: the runtime answered a delete with an error. + */ + | { ok: false; status: 400 | 500 | 507; message: LocalModelInstallMessage } | { ok: false; status: 409; conflict: LocalModelConflict }; /** @@ -759,8 +1013,12 @@ export interface LocalModelServiceDeps { listRunning: (target: OllamaTarget, signal?: AbortSignal) => Promise; getRuntimeVersion: (target: OllamaTarget, signal?: AbortSignal) => Promise; deleteModel: (target: OllamaTarget, modelId: string, signal?: AbortSignal) => Promise; + /** The models the runtime has on disk, with their sizes and digests: the library's live half. */ + listTags: (target: OllamaTarget, signal?: AbortSignal) => Promise; /** `removePartialModelBlobs()` of src/local-model/runtime.ts: what an interrupted download left in the model store. Resolves with the bytes freed. */ removePartialModelBlobs: (paths?: LocalModelPaths) => Promise; + /** `measureModelStore()` of src/local-model/runtime.ts: what the model store takes on disk, in bytes. */ + measureModelStore: (paths?: LocalModelPaths) => Promise; // src/local-model/developer-tools.ts checkDeveloperTools: () => Promise; // src/cli-install-runner.ts @@ -800,9 +1058,11 @@ export interface LocalModelService { /** * Whether a session may be started on the saved endpoint `endpointId` right now. `undefined`: * yes, which is also the answer for every endpoint that is not this feature's. Otherwise the - * error that refuses the launch. While the runtime child Codeman started is not alive - * (whatever answers on the port then is not ours), the reason is the one that is known: - * `port-in-use`, `runtime-stopped`, `runtime-start-failed`, else `runtime-not-running`. + * error that refuses the launch. While a job that changes the model in use is running or + * stopped (any state but `installed` that holds a connection of ours) it is `job-unfinished`. + * While the runtime child Codeman started is not alive (whatever answers on the port then + * is not ours), the reason is the one that is known: `port-in-use`, `runtime-stopped`, + * `runtime-start-failed`, else `runtime-not-running`. * While it runs, the digest is read again: `model-changed` when it is not the stored one or * the model is gone. Every path that starts a coding agent on the managed endpoint asks * this first (see the file header for the list). Never throws. @@ -817,8 +1077,34 @@ export interface LocalModelService { launchRefusalMessage(endpointId: string, modelId: string): Promise; /** What the GET passes to `recommend()`: the stored measured total and the runtime download that is still needed. */ recommendOptions(): Promise; - /** `POST /api/local-model/install`. Answers once the job is STARTED; the job runs on in the server. */ - install(request: LocalModelInstallRequest, actor: LocalModelActor): Promise; + /** + * `POST /api/local-model/install`. Answers once the job is STARTED; the job runs on in the + * server. From `installed` it adds a model: the earlier ones stay in the library, and the new + * one becomes the model in use when the job ends. `liveSessionNames` as for `remove()`: not + * empty answers 409 `sessions-open` while a connection of ours exists. + */ + install( + request: LocalModelInstallRequest, + actor: LocalModelActor, + liveSessionNames?: readonly string[] + ): Promise; + /** + * `POST /api/local-model/use`: switch to a checked model of the library. Answers once the + * job (`USE_JOB_STEPS`) is STARTED. Nothing is downloaded. `liveSessionNames` as for + * `remove()`. + */ + use( + request: LocalModelUseRequest, + actor: LocalModelActor, + liveSessionNames?: readonly string[] + ): Promise; + /** + * `DELETE /api/local-model/models`: delete one model from the store, through the runtime. + * The name must be in the server's own listing (the library or the runtime's tags). Refused + * for the model of the installation or of the current job, while a job runs and while the + * runtime is down. + */ + deleteLibraryModel(request: LocalModelDeleteRequest, actor?: LocalModelActor): Promise; /** `POST /api/local-model/cancel`. Answers once the step in flight was interrupted. */ cancel(): Promise; /** @@ -872,6 +1158,12 @@ const PROGRESS_FLUSH_MS = 5_000; const DIGEST_RECHECK_MS = 30_000; /** How long a read of the runtime's listings may take. */ const RUNTIME_READ_TIMEOUT_MS = 5_000; +/** How long the runtime's list of models stays good for the view. Every verb and step that changes the store throws it away. */ +const TAGS_RECHECK_MS = 5_000; +/** How long a measurement of the model store stays good for the view. */ +const STORE_RECHECK_MS = 30_000; +/** How long the view waits for the FIRST listing and measurement. Later ones are read in the background. */ +const FIRST_LISTING_WAIT_MS = 300; /** The window a download speed is measured over when the source reports none. */ const SPEED_WINDOW_MS = 5_000; /** How much of an installer's output is kept as the error detail. */ @@ -899,6 +1191,8 @@ function conflict( 'size-changed': LOCAL_MODEL_INSTALL_LABELS.conflictSizeChanged, 'sessions-open': LOCAL_MODEL_INSTALL_LABELS.conflictSessionsOpen, 'wrong-state': LOCAL_MODEL_INSTALL_LABELS.conflictWrongState, + 'model-active': LOCAL_MODEL_INSTALL_LABELS.conflictModelActive, + 'runtime-not-running': LOCAL_MODEL_INSTALL_LABELS.errRuntimeNotRunning, }[reason]; return { ok: false, status: 409, conflict: { reason, message: { text, ...(vars ? { vars } : {}) }, ...extra } }; } @@ -960,6 +1254,12 @@ class LocalModelServiceImpl implements LocalModelService { private startFailed: { detail?: string } | undefined; private digestStatus: 'same' | 'changed' | 'unknown' | undefined; private digestCheckedAt = 0; + /** What the runtime on `port` last listed on disk, and when. Thrown away whenever the store may have changed. */ + private tagsCache: { at: number; port: number; tags: OllamaTagModel[] } | undefined; + private tagsRefresh: Promise | undefined; + /** What the model store last took on disk, and when. */ + private storeCache: { at: number; bytes: number } | undefined; + private storeRefresh: Promise | undefined; constructor(deps: Partial) { const pin = deps.pin ?? OLLAMA_RUNTIME_PIN; @@ -983,7 +1283,9 @@ class LocalModelServiceImpl implements LocalModelService { listRunning, getRuntimeVersion, deleteModel, + listTags, removePartialModelBlobs, + measureModelStore, checkDeveloperTools: () => checkDeveloperTools(), stockInstallCommand, tryBeginCliInstall, @@ -1346,6 +1648,86 @@ class LocalModelServiceImpl implements LocalModelService { }).catch(() => {}); } + // ---------- The library's live half ---------- + + /** The store changed, or may have: the next view reads the runtime's list and the disk again. */ + private forgetStore(): void { + this.tagsCache = undefined; + this.storeCache = undefined; + } + + /** + * Reads what the running runtime lists on disk. A runtime that does not answer leaves the + * last list in place: "it has no models" and "it said nothing" must not look alike, or every + * checked model would read as missing for a moment. Never throws. + */ + private refreshTags(state: LocalModelStateFile): Promise { + const port = state.runtime?.port; + if (port === undefined || !this.deps.supervisor.status().running) { + this.tagsCache = undefined; + return Promise.resolve(); + } + this.tagsRefresh ??= (async () => { + try { + const target = baseUrlOf(port); + const version = await this.deps.getRuntimeVersion(target, AbortSignal.timeout(RUNTIME_READ_TIMEOUT_MS)); + if (version === undefined) return; + const tags = await this.deps.listTags(target, AbortSignal.timeout(RUNTIME_READ_TIMEOUT_MS)); + this.tagsCache = { at: this.deps.now(), port, tags }; + } catch { + /* the last list stays */ + } finally { + this.tagsRefresh = undefined; + } + })(); + return this.tagsRefresh; + } + + /** Measures the model store on disk. Never throws. */ + private refreshStore(): Promise { + this.storeRefresh ??= (async () => { + try { + const bytes = await this.deps.measureModelStore(this.paths()); + this.storeCache = { at: this.deps.now(), bytes }; + } catch { + /* the last figure stays */ + } finally { + this.storeRefresh = undefined; + } + })(); + return this.storeRefresh; + } + + /** + * Keeps the two caches of the view current WITHOUT making the one-second poll wait for the + * runtime or the disk: a stale figure is refreshed in the background, and only a figure that + * was never read is waited for, briefly. + */ + private async freshenListings(state: LocalModelStateFile): Promise { + const now = this.deps.now(); + const first: Promise[] = []; + if (!this.storeCache || now - this.storeCache.at >= STORE_RECHECK_MS) { + const run = this.refreshStore(); + if (!this.storeCache) first.push(run); + } + const port = state.runtime?.port; + if (port === undefined || !this.deps.supervisor.status().running) { + this.tagsCache = undefined; + } else if (!this.tagsCache || this.tagsCache.port !== port || now - this.tagsCache.at >= TAGS_RECHECK_MS) { + const known = this.tagsCache?.port === port; + const run = this.refreshTags(state); + if (!known) first.push(run); + } + if (first.length === 0) return; + let timer: NodeJS.Timeout | undefined; + const waited = new Promise((resolve) => { + timer = setTimeout(resolve, FIRST_LISTING_WAIT_MS); + timer.unref(); + }); + await Promise.race([Promise.all(first), waited]); + clearTimeout(timer); + } + // ---------- The view ---------- private async liveFacts(state: LocalModelStateFile): Promise { @@ -1358,14 +1740,18 @@ class LocalModelServiceImpl implements LocalModelService { } let nextModel: InstallLiveFacts['nextModel']; const nextModelId = state.error?.nextModelId; - if (nextModelId) { - try { - const entry = this.deps.getCatalog().models.find((model) => model.id === nextModelId); - if (entry) nextModel = { modelId: entry.id, modelLabel: entry.label }; - } catch { - /* no model is offered then */ - } + let labels: Record | undefined; + try { + const models = this.deps.getCatalog().models; + const entry = nextModelId ? models.find((model) => model.id === nextModelId) : undefined; + if (entry) nextModel = { modelId: entry.id, modelLabel: entry.label }; + labels = Object.fromEntries(models.map((model) => [model.id, model.label])); + } catch { + /* no model is offered then, and a model the state file does not know keeps its name */ } + const port = state.runtime?.port; + const tags = + status.running && port !== undefined && this.tagsCache?.port === port ? this.tagsCache.tags : undefined; return { running: status.running, gaveUp: status.gaveUp, @@ -1378,6 +1764,9 @@ class LocalModelServiceImpl implements LocalModelService { ...(nextModel ? { nextModel } : {}), pin: this.deps.pin, folder: this.paths().root, + ...(tags ? { tags } : {}), + ...(this.storeCache ? { storeBytes: this.storeCache.bytes } : {}), + ...(labels ? { labels } : {}), }; } @@ -1403,6 +1792,7 @@ class LocalModelServiceImpl implements LocalModelService { this.digestCheckedAt = this.deps.now(); void this.refreshDigest(state).catch(() => {}); } + await this.freshenListings(state); return buildInstallView(state, await this.liveFacts(state)); } catch (err) { console.warn(`[local-model] Could not build the install view: ${getErrorMessage(err)}`); @@ -1440,7 +1830,10 @@ class LocalModelServiceImpl implements LocalModelService { // A record with the reserved id that this feature did not write is not ours to judge. if (state.connection?.endpointId !== endpointId) return undefined; const status = this.deps.supervisor.status(); - if (state.state !== 'installed' || !state.runtime || !state.model || !status.running) { + // A job that changes the model in use runs or stopped: the record may still name the + // earlier model, and nothing is started on it until a job ended `installed` again. + if (state.state !== 'installed') return buildInstallError('job-unfinished'); + if (!state.runtime || !state.model || !status.running) { if (this.portInUse) return buildInstallError('port-in-use', { vars: this.errorVars('port-in-use', state) }); if (status.gaveUp) return buildInstallError('runtime-stopped'); if (this.startFailed) return buildInstallError('runtime-start-failed', { next: 'start' }); @@ -1493,12 +1886,26 @@ class LocalModelServiceImpl implements LocalModelService { return { ok: true, view: await this.view() }; } - install(request: LocalModelInstallRequest, actor: LocalModelActor): Promise { + install( + request: LocalModelInstallRequest, + actor: LocalModelActor, + liveSessionNames: readonly string[] = [] + ): Promise { return this.exclusive(async () => { await this.settle(); const state = await this.currentState(); if (state.state === 'installing') return conflict('job-running'); - if (state.state === 'installed') return conflict('already-installed'); + // The model in use at the context it runs with: there is nothing to install. + if ( + state.state === 'installed' && + state.model?.id === request.modelId && + state.model.context === request.context + ) { + return conflict('already-installed'); + } + // Another model takes the runtime (it holds one) and often restarts it for its context. + const open = this.sessionsOpen(state, liveSessionNames); + if (open) return open; // Everything below is checked against what the server itself offers right now, before // anything is downloaded. @@ -1548,6 +1955,7 @@ class LocalModelServiceImpl implements LocalModelService { steps: jobSteps({ agentInstalled: harness.installed }), }); if (refused) return refused; + this.forgetStore(); void this.deps .audit({ admin: actor.username, @@ -1561,15 +1969,145 @@ class LocalModelServiceImpl implements LocalModelService { }); } + use( + request: LocalModelUseRequest, + actor: LocalModelActor, + liveSessionNames: readonly string[] = [] + ): Promise { + return this.exclusive(async () => { + await this.settle(); + const state = await this.currentState(); + if (state.state === 'installing') return conflict('job-running'); + if (INSTALL_TRANSITIONS[state.state].use === undefined) return conflict('wrong-state'); + const entry = libraryOf(state).find((candidate) => candidate.id === request.modelId); + if (!entry) { + return { ok: false, status: 400, message: { text: LOCAL_MODEL_INSTALL_LABELS.refusedNotInLibrary } }; + } + if (state.state === 'installed' && state.model?.id === entry.id) return conflict('already-installed'); + const open = this.sessionsOpen(state, liveSessionNames); + if (open) return open; + + // The coding agent of the switch: the one this model was checked with, else the one of + // the state, whichever is on this Mac now. A job that stopped while it installed another + // agent leaves the state naming one that may not be there. + const agents = [entry.cli, state.cli].filter( + (cli, index, all): cli is { id: string; label: string } => + cli !== undefined && all.findIndex((other) => other?.id === cli.id) === index + ); + let cli: { id: string; label: string } | undefined; + for (const agent of agents) { + if (await this.deps.recheckCliInstalled(agent.id).catch(() => false)) { + cli = agent; + break; + } + } + if (!cli) { + return { + ok: false, + status: 400, + message: { text: LOCAL_MODEL_INSTALL_LABELS.refusedAgentMissing, vars: { cli: agents[0]?.label ?? '' } }, + }; + } + + const refused = await this.beginJob(actor, { + type: 'use', + model: { id: entry.id, label: entry.label, context: entry.context, digest: entry.digest }, + cli, + }); + if (refused) return refused; + this.forgetStore(); + void this.deps + .audit({ + admin: actor.username, + action: 'local_model_use', + target: entry.id, + ...(actor.ip ? { ip: actor.ip } : {}), + detail: { cli: cli.id, context: entry.context }, + }) + .catch(() => {}); + return this.answer(); + }); + } + + deleteLibraryModel(request: LocalModelDeleteRequest, actor?: LocalModelActor): Promise { + return this.exclusive(async () => { + await this.settle(); + const state = await this.currentState(); + if (state.state === 'installing') return conflict('job-running'); + if (!INSTALL_STATE_TABLE[state.state].actions.includes('delete-model') || !state.runtime) { + return conflict('wrong-state'); + } + const id = request.modelId; + // Never a path, and never another registry's name: the same shape a catalogue id has. + if (!LOCAL_MODEL_ID_PATTERN.test(id)) { + return { ok: false, status: 400, message: { text: LOCAL_MODEL_INSTALL_LABELS.refusedNotOnThisMac } }; + } + const entry = libraryOf(state).find((candidate) => candidate.id === id); + if (state.model?.id === id) return conflict('model-active', {}, { model: state.model.label }); + + // Only the runtime deletes a model, and only its answer says what is on disk. + const target = baseUrlOf(state.runtime.port); + let version: string | undefined; + if (this.deps.supervisor.status().running) { + try { + version = await this.deps.getRuntimeVersion(target, AbortSignal.timeout(RUNTIME_READ_TIMEOUT_MS)); + } catch { + version = undefined; + } + } + if (version === undefined) return conflict('runtime-not-running'); + const listed = (await this.deps.listTags(target, AbortSignal.timeout(RUNTIME_READ_TIMEOUT_MS))).find( + (model) => model.name === id + ); + if (!entry && !listed) { + return { ok: false, status: 400, message: { text: LOCAL_MODEL_INSTALL_LABELS.refusedNotOnThisMac } }; + } + // Asked of the runtime also for a checked model it did not list just now: its answer + // (deleted, or "not found") is what says the model is gone, never an empty listing. + let gone = false; + try { + gone = await this.deps.deleteModel(target, id, AbortSignal.timeout(RUNTIME_READ_TIMEOUT_MS)); + } catch { + gone = false; + } + if (!gone) { + return { + ok: false, + status: 500, + message: { text: LOCAL_MODEL_INSTALL_LABELS.deleteFailed, vars: { model: entry?.label ?? id } }, + }; + } + if (entry) { + await this.record((current) => { + const library = libraryOf(current).filter((candidate) => candidate.id !== id); + return { ...current, library }; + }); + } + this.forgetStore(); + if (actor) { + void this.deps + .audit({ + admin: actor.username, + action: 'local_model_delete', + target: id, + ...(actor.ip ? { ip: actor.ip } : {}), + detail: { verified: entry !== undefined, bytes: listed?.size ?? entry?.bytes ?? 0 }, + }) + .catch(() => {}); + } + return this.answer(); + }); + } + /** - * Writes the event that starts a job (`install` or `resume`) and starts the job. `undefined`: + * Writes the event that starts a job (`install`, `use` or `resume`) and starts the job. `undefined`: * started. A state file that cannot be written for lack of space is not a 500: the job did * not start, and the view says `disk-full` with its "Try again" (a first install, which has * no job to show it on, is answered with that sentence). */ private async beginJob( actor: LocalModelActor, - event: Extract + event: Extract ): Promise { this.jobStarting = true; try { @@ -1700,6 +2238,7 @@ class LocalModelServiceImpl implements LocalModelService { }); this.portInUse = false; this.startFailed = undefined; + this.forgetStore(); await this.record((current) => current.runtime ? { ...current, runtime: { ...current.runtime, enabled: false } } : undefined ); @@ -1721,6 +2260,7 @@ class LocalModelServiceImpl implements LocalModelService { state = await this.deps.readState(); const started = await this.startRuntime(state); if (started.ok) await this.refreshDigest(await this.deps.readState()); + this.forgetStore(); return this.answer(); }); } @@ -1755,6 +2295,7 @@ class LocalModelServiceImpl implements LocalModelService { this.portInUse = false; this.startFailed = undefined; this.digestStatus = undefined; + this.forgetStore(); if (actor) { void this.deps .audit({ @@ -1868,6 +2409,8 @@ class LocalModelServiceImpl implements LocalModelService { // A step that finished stays finished, also when Cancel arrived while it ran. Its // download figures go first, so the next step is never shown with them. this.clearProgress(); + // A model arrived, was checked or was connected: the library is read again. + this.forgetStore(); await this.dispatch({ type: 'step-done' }); continue; } @@ -1992,28 +2535,8 @@ class LocalModelServiceImpl implements LocalModelService { if (!running.runtime) return { kind: 'fail', code: 'internal', detail: 'The runtime has no port.' }; const target = baseUrlOf(running.runtime.port); - // What a replaced job left of another model goes first, so two models never share the store. - if (running.replacedModelId) { - try { - await this.deps.deleteModel(target, running.replacedModelId, signal); - } catch { - /* a leftover is not a reason to stop: Remove with the models deletes it */ - } - if (signal.aborted) return CANCELLED; - // A download that was interrupted left partial blobs and no model: the runtime answers - // "not found" for it and deletes nothing. No download is in flight here, so every - // partial file in the store is a dead one. - try { - const freed = await this.deps.removePartialModelBlobs(this.paths()); - if (freed > 0) console.log(`[local-model] Deleted ${formatGb(freed)} GB a replaced download had left.`); - } catch { - /* as above */ - } - await this.record((current) => { - const { replacedModelId: _replaced, ...rest } = current; - return rest; - }); - } + // What a replaced job left of another model goes first, so no unchecked leftover stays in the store. + if (await this.dropReplacedModel(running, target, signal)) return CANCELLED; const pulled = await this.deps.pullModel(target, state.model.id, { signal, @@ -2047,6 +2570,40 @@ class LocalModelServiceImpl implements LocalModelService { return DONE; } + /** + * Deletes what a replaced job left of ANOTHER model (`replacedModelId`): the model through + * the runtime when it was downloaded whole, and the partial blobs of an interrupted download. + * A no-op without one. True when the job was cancelled meanwhile. + */ + private async dropReplacedModel( + running: LocalModelStateFile, + target: OllamaTarget, + signal: AbortSignal + ): Promise { + if (!running.replacedModelId) return false; + try { + await this.deps.deleteModel(target, running.replacedModelId, signal); + } catch { + /* a leftover is not a reason to stop: Remove with the models deletes it */ + } + if (signal.aborted) return true; + // A download that was interrupted left partial blobs and no model: the runtime answers + // "not found" for it and deletes nothing. No download is in flight here, so every + // partial file in the store is a dead one. + try { + const freed = await this.deps.removePartialModelBlobs(this.paths()); + if (freed > 0) console.log(`[local-model] Deleted ${formatGb(freed)} GB a replaced download had left.`); + } catch { + /* as above */ + } + await this.record((current) => { + const { replacedModelId: _replaced, ...rest } = current; + return rest; + }); + this.forgetStore(); + return false; + } + private async stepVerify(state: LocalModelStateFile, signal: AbortSignal): Promise { if (!state.model) return { kind: 'fail', code: 'internal', detail: 'The job has no model.' }; const blocked = await this.needRuntime(signal); @@ -2056,6 +2613,26 @@ class LocalModelServiceImpl implements LocalModelService { const target = baseUrlOf(running.runtime.port); const { id, context } = state.model; + // A switch has no download step, so the leftovers of the job it replaced go here. + if (await this.dropReplacedModel(running, target, signal)) return CANCELLED; + + // A switch names the digest the model was checked with (`use`). Another one under the + // same name is other weights or another template: it is not loaded, let alone connected. + const expected = state.model.digest; + if (expected) { + const before = await this.deps.readModelDigest(target, id, signal); + if (signal.aborted) return CANCELLED; + if (compareModelDigest(expected, before) !== 'same') { + return { + kind: 'fail', + code: 'model-changed', + detail: before + ? 'The runtime reports another digest for the model.' + : 'The runtime no longer lists the model.', + }; + } + } + const verified = await this.deps.verifyModel(target, id, context, signal); if (!verified.ok) { if (verified.code === 'cancelled') return CANCELLED; @@ -2098,10 +2675,46 @@ class LocalModelServiceImpl implements LocalModelService { detail: 'The runtime reports no digest for the model.', }; } + if (expected && compareModelDigest(expected, digest) !== 'same') { + return { kind: 'fail', code: 'model-changed', detail: 'The runtime reports another digest for the model.' }; + } const loaded = verified.loaded; - await this.record((current) => - current.model ? { ...current, model: { ...current.model, digest }, loaded: { ...loaded } } : undefined - ); + // The model is one of the library from here on: checked, with the digest a later switch + // must find again, its size on disk and the coding agent of this job. + let bytes: number | undefined; + try { + bytes = (await this.deps.listTags(target, AbortSignal.timeout(RUNTIME_READ_TIMEOUT_MS))).find( + (model) => model.name === id + )?.size; + } catch { + bytes = undefined; + } + let verifiedAt: string | undefined; + try { + verifiedAt = new Date(this.deps.now()).toISOString(); + } catch { + verifiedAt = undefined; + } + await this.record((current) => { + if (!current.model) return undefined; + const known = (current.library ?? []).find((entry) => entry.id === id); + const size = bytes && bytes > 0 ? bytes : (current.model.pullBytes ?? known?.bytes); + const entry: LocalModelLibraryEntry = { + id, + label: current.model.label, + context, + digest, + ...(size ? { bytes: size } : {}), + ...(current.cli ? { cli: current.cli } : {}), + ...(verifiedAt ? { verifiedAt } : {}), + }; + return { + ...current, + model: { ...current.model, digest }, + loaded: { ...loaded }, + library: upsertLibraryEntry(current.library ?? [], entry), + }; + }); this.digestStatus = 'same'; this.digestCheckedAt = this.deps.now(); return DONE; diff --git a/src/local-model/runtime.ts b/src/local-model/runtime.ts index eaf281d5..c7e31345 100644 --- a/src/local-model/runtime.ts +++ b/src/local-model/runtime.ts @@ -808,6 +808,45 @@ export async function removePartialModelBlobs(paths?: LocalModelPaths): Promise< return freed; } +/** How many files of the blob folder are counted at most: a store holds a few dozen, and a walk must end. */ +const STORE_MEASURE_MAX_FILES = 20_000; + +/** + * What the model store takes on disk: the sizes of the regular files directly in + * `/blobs`, summed. That folder is flat (one file per layer, plus the partial files of + * a download), so this is the store's real disk use, shared layers counted once, an + * interrupted download included. The manifests beside it are a few kilobytes and are left out. + * + * One `readdir` and one `lstat` per file, at most `STORE_MEASURE_MAX_FILES` of them. Nothing is + * followed: a `root`, a model store or a blob folder that is a symbolic link counts as empty, + * and so does a link in the place of a file. Never outside `LocalModelPaths.root`. Resolves 0 + * when there is no store. Never throws. + */ +export async function measureModelStore(paths?: LocalModelPaths): Promise { + let total = 0; + try { + const resolved = paths ?? localModelPaths(OLLAMA_RUNTIME_PIN.version); + const blobs = join(resolved.modelsDir, 'blobs'); + if (!isInsideLocalModelRoot(blobs, resolved.root)) return 0; + for (const folder of [resolved.root, resolved.modelsDir, blobs]) { + const info = await lstat(folder); + if (info.isSymbolicLink() || !info.isDirectory()) return 0; + } + const names = await readdir(blobs); + for (const name of names.slice(0, STORE_MEASURE_MAX_FILES)) { + try { + const info = await lstat(join(blobs, name)); + if (info.isFile()) total += info.size; + } catch { + // Gone between the listing and the look: a download or a delete is under way. + } + } + } catch { + // No model store yet. + } + return total; +} + // ---------- Port ---------- /** Whether nothing holds `port` on 127.0.0.1, decided by binding it and letting go again. */ diff --git a/src/local-model/state-store.ts b/src/local-model/state-store.ts index 434a686e..d184ff6f 100644 --- a/src/local-model/state-store.ts +++ b/src/local-model/state-store.ts @@ -26,6 +26,7 @@ import { type LocalModelErrorCode, type LocalModelInstallState, type LocalModelInstallStep, + type LocalModelLibraryEntry, type LocalModelStateFile, } from '../types.js'; import { OLLAMA_RUNTIME_PIN } from './runtime.js'; @@ -153,6 +154,41 @@ function parseConnection(value: unknown): LocalModelStateFile['connection'] { : undefined; } +/** How many checked models a state file may list: far more than one Mac holds, and a bound on what a damaged file can cost. */ +const MAX_LIBRARY_ENTRIES = 64; + +/** + * The checked models of a file. An entry without its id, label, context or digest is dropped + * (it could never be switched to), and so is a second entry for an id. `undefined` for a file + * that has no list, which is what an earlier build wrote. + */ +function parseLibrary(value: unknown): LocalModelLibraryEntry[] | undefined { + if (!Array.isArray(value)) return undefined; + const entries: LocalModelLibraryEntry[] = []; + for (const item of value) { + if (entries.length >= MAX_LIBRARY_ENTRIES) break; + if (!isRecord(item)) continue; + const id = text(item.id, 200); + const label = text(item.label, 200); + const context = count(item.context); + const digest = text(item.digest, 200); + if (!id || !label || !context || !digest || entries.some((entry) => entry.id === id)) continue; + const bytes = count(item.bytes); + const cli = parseCli(item.cli); + const verifiedAt = text(item.verifiedAt, 64); + entries.push({ + id, + label, + context, + digest, + ...(bytes ? { bytes } : {}), + ...(cli ? { cli } : {}), + ...(verifiedAt ? { verifiedAt } : {}), + }); + } + return entries; +} + /** * The state a file's text stands for. Pure and total: text that is not a JSON object of * `schema: 1` with a known `state` is `IDLE_LOCAL_MODEL_STATE`. Members it does not know are @@ -180,6 +216,7 @@ export function parseLocalModelState(raw: string): LocalModelStateFile { const connection = parseConnection(parsed.connection); const updatedAt = text(parsed.updatedAt, 64); const replacedModelId = text(parsed.replacedModelId, 200); + const library = parseLibrary(parsed.library); if (!model || !cli) return IDLE_LOCAL_MODEL_STATE; if (state === 'installed') { @@ -192,6 +229,7 @@ export function parseLocalModelState(raw: string): LocalModelStateFile { cli, runtime, ...(loaded ? { loaded } : {}), + ...(library ? { library } : {}), ...(connection ? { connection } : {}), ...(updatedAt ? { updatedAt } : {}), }; @@ -215,6 +253,7 @@ export function parseLocalModelState(raw: string): LocalModelStateFile { ...(runtime ? { runtime } : {}), ...(progress ? { progress } : {}), ...(loaded ? { loaded } : {}), + ...(library ? { library } : {}), ...(connection ? { connection } : {}), ...(replacedModelId ? { replacedModelId } : {}), ...(updatedAt ? { updatedAt } : {}), diff --git a/src/types/local-model-install.ts b/src/types/local-model-install.ts index 2fdd8f2b..6ac649a5 100644 --- a/src/types/local-model-install.ts +++ b/src/types/local-model-install.ts @@ -24,7 +24,11 @@ * | `GET /api/local-model` | none | none (a failed probe is an answer) | * | `POST /api/local-model/install` | `LocalModelInstallRequest` | 400 not a row the server offers, or a saved endpoint | * | | | already has the reserved id; 409 `job-running`, | - * | | | `already-installed`, `size-changed` | + * | | | `already-installed` (this model at this context is | + * | | | the one in use), `size-changed`, `sessions-open` | + * | `POST /api/local-model/use` | `LocalModelUseRequest` | 400 not a checked model of the library, or no coding | + * | | | agent for it is installed; 409 `job-running`, | + * | | | `wrong-state`, `already-installed`, `sessions-open` | * | `POST /api/local-model/cancel` | none | 409 `wrong-state` (no job is running) | * | `POST /api/local-model/resume` | `LocalModelResumeRequest` | 409 `job-running`, `wrong-state` (not paused or | * | | | failed), `sessions-open` (another port while live | @@ -33,6 +37,9 @@ * | | | `sessions-open` (stop, or another port, while live | * | | | sessions use the model) | * | `DELETE /api/local-model` | `LocalModelRemoveRequest` | 409 `job-running`, `sessions-open` | + * | `DELETE /api/local-model/models` | `LocalModelDeleteRequest` | 400 not a model of this Mac; 409 `job-running`, | + * | | | `wrong-state`, `model-active`, `runtime-not-running`; | + * | | | 500 the runtime did not delete it | * * A 409 is the error envelope plus `data: LocalModelConflict`: * `{ success: false, error, errorCode: 'CONFLICT', data: { reason, message, ... } }`. A 409 @@ -141,7 +148,10 @@ export const LOCAL_MODEL_INSTALL_STEPS: readonly LocalModelInstallStep[] = [ * | `harness-failed` | the coding agent's install command failed, or its binary is still missing | * | `endpoint-id-taken` | a saved endpoint with our id exists that this feature did not write | * | `connect-failed` | the endpoint record or the settings flag could not be written | - * | `model-changed` | installed: the model's digest is not the one stored at install time | + * | `model-changed` | installed: the model's digest is not the one stored at install time. A | + * | | switch: the model's digest is not the one it was checked with | + * | `job-unfinished` | a job that changes the model in use is running or stopped. Only a | + * | | refused session start says it: nothing is started until the job ended | * | `internal` | anything unexpected (the exception text is in `detail`) | */ export type LocalModelErrorCode = @@ -164,6 +174,7 @@ export type LocalModelErrorCode = | 'endpoint-id-taken' | 'connect-failed' | 'model-changed' + | 'job-unfinished' | 'internal'; /** @@ -192,12 +203,25 @@ export type LocalModelNextStep = 'retry' | 'other-port' | 'next-model' | 'start' * - `cancel`: `POST /api/local-model/cancel`. * - `resume`: `POST /api/local-model/resume`. * - `start` and `stop`: `POST /api/local-model/runtime`. - * - `remove`: `DELETE /api/local-model`. + * - `remove`: `DELETE /api/local-model`. In `idle` it is listed only while the model store + * still holds something (models an earlier Remove kept): it is then what frees that space. * - `start-session`: not a route of this feature: the window starts a session on the endpoint * `endpointId` with the coding agent `cli`. Offered only while the runtime runs and nothing * blocks a session. + * - `use`: `POST /api/local-model/use`. Listed only while a row of `library` offers it. + * - `delete-model`: `DELETE /api/local-model/models`. Listed only while a row of `library` + * offers it. */ -export type LocalModelAction = 'install' | 'cancel' | 'resume' | 'start' | 'stop' | 'remove' | 'start-session'; +export type LocalModelAction = + | 'install' + | 'cancel' + | 'resume' + | 'start' + | 'stop' + | 'remove' + | 'start-session' + | 'use' + | 'delete-model'; /** Whether the Mac has the developer tools (git, Python) a coding agent calls. */ export type LocalModelDeveloperTools = @@ -225,7 +249,9 @@ export type LocalModelDeveloperTools = * | `errHarnessFailed` | `cli`: the coding agent's label | * | `errEndpointIdTaken` | `id`: the endpoint id this feature uses | * | `refusedAgentNotInstallable` | `cli`: the coding agent's label | - * | `refusedOtherModel` | `model`: the label of the model that is installed | + * | `refusedOtherModel` | `model`: the label of the model that is in use | + * | `refusedAgentMissing` | `cli`: the coding agent's label | + * | `conflictModelActive`, `deleteFailed` | `model`: the model's label | * | `conflictSizeChanged` | `size`: the server's own total as decimal GB | * | `conflictSessionsOpen` | `sessions`: the session names, joined with ', ' | * @@ -259,16 +285,23 @@ export const LOCAL_MODEL_INSTALL_LABELS = { 'A saved model connection named {id} already exists and was not created here. Rename or delete it in App Settings, then try again.', errConnectFailed: 'Codeman could not save the connection to the model.', errModelChanged: 'The model on this Mac changed since it was installed. Remove it and install it again.', + errJobUnfinished: + 'The model on this Mac is being changed and is not ready. Finish or undo that in the local model window first.', errInternal: 'The install stopped on an unexpected error.', conflictJobRunning: 'An install is already running.', - conflictAlreadyInstalled: 'A model is already installed on this Mac. Remove it first.', + conflictAlreadyInstalled: 'This model is already in use on this Mac.', + conflictModelActive: '{model} is the model in use. Switch to another model first, or remove the local model.', conflictSizeChanged: 'The download is {size} GB now. Check the sizes and confirm again.', conflictSessionsOpen: 'Sessions are still using this model: {sessions}. Close them first.', conflictWrongState: 'That is not possible in the current state.', refusedModelNotOffered: 'This model at this context is not offered for this Mac right now.', refusedAgentNotOffered: 'This coding agent is not offered for this model.', refusedAgentNotInstallable: '{cli} is not installed and cannot be installed from here.', - refusedOtherModel: 'Only {model} is installed on this Mac. Remove it and install another model first.', + refusedOtherModel: 'Only {model} is in use on this Mac. Switch models in the local model window first.', + refusedNotInLibrary: 'This model is not one of the checked models on this Mac.', + refusedNotOnThisMac: 'This model is not on this Mac.', + deleteFailed: '{model} could not be deleted from this Mac.', + refusedAgentMissing: '{cli} is not installed on this Mac. Install this model again to choose a coding agent.', endpointManaged: 'This endpoint belongs to the model Codeman runs on this Mac. Change or remove it in the local model window.', endpointIdReserved: 'This endpoint id is reserved for the model Codeman runs on this Mac. Pick another id.', @@ -307,6 +340,7 @@ export const LOCAL_MODEL_ERROR_LABELS: Record 0 && !steps.includes('model'); +} + +/** The rows of `install.library`: the models on this Mac. A payload without the list has none. */ +function localModelLibrary(install) { + return (Array.isArray(install.library) ? install.library : []).filter((row) => row && typeof row.id === 'string'); +} + +/** What a library row's state is called, and the tag class that colours it. */ +function localModelLibraryTag(row) { + if (row.active === true) return { text: localModelT('In use'), kind: 'inuse' }; + if (row.status === 'ready') return { text: localModelT('Ready'), kind: 'ready' }; + if (row.status === 'changed') return { text: localModelT('Changed'), kind: 'changed' }; + if (row.status === 'missing') return { text: localModelT('Missing'), kind: 'missing' }; + return { text: localModelT('Not checked'), kind: 'unverified' }; +} + /** * The coding agents a row can run with. A payload without the list means the one agent of the * row's flat fields. @@ -516,6 +554,11 @@ Object.assign(CodemanApp.prototype, { /** The Remove question is open, and whether the downloaded model goes too. */ confirmRemove: false, removeModel: true, + /** + * The Delete question of one row is open: that row's model id, or `LOCAL_MODEL_STORE_KEY` + * for the downloaded models an earlier Remove kept. + */ + confirmDelete: null, /** * The install finished while this window was open: the screen that ends it shows * "Start a session" alone. Stop and Remove belong to the window opened later. @@ -543,9 +586,10 @@ Object.assign(CodemanApp.prototype, { const install = localModelInstall(this._localModelStatus); const selection = this._localModelSelection(); if (install.state === 'installing') return 'progress'; - if (install.state === 'installed') return 'installed'; const canInstall = install.actions.includes('install') && !!selection; + // The chooser is also where a second model is added to an installed one. if (canInstall && (ui.view === 'choose' || ui.view === 'confirm')) return ui.view; + if (install.state === 'installed') return 'installed'; if (install.state === 'paused') return 'paused'; if (install.state === 'failed') return 'failed'; return selection ? 'choose' : 'none'; @@ -572,6 +616,7 @@ Object.assign(CodemanApp.prototype, { notice: null, expected: null, confirmRemove: false, + confirmDelete: null, justInstalled: false, }); this._forgetLocalModelPaint(); @@ -690,10 +735,10 @@ Object.assign(CodemanApp.prototype, { this.renderLocalModel(); }, - /** Back to the chooser (from the confirm screen, or to pick another model after a stop). */ + /** Back to the chooser (from the confirm screen, to pick another model after a stop, or to add one). */ chooseLocalModel(modelId) { const ui = this._localModelWindowState(); - Object.assign(ui, { view: 'choose', notice: null, expected: null, confirmRemove: false }); + Object.assign(ui, { view: 'choose', notice: null, expected: null, confirmRemove: false, confirmDelete: null }); if (typeof modelId === 'string') { ui.modelId = modelId; ui.cli = null; @@ -749,6 +794,57 @@ Object.assign(CodemanApp.prototype, { this.renderLocalModel(); }, + /** + * "Use": switch to a model that is on this Mac already. Nothing is downloaded, so there is + * no confirm screen: the server loads and checks the model again and connects it. + */ + async useLocalModel(modelId) { + const ui = this._localModelWindowState(); + ui.confirmDelete = null; + const result = await this._localModelVerb('POST', '/api/local-model/use', { modelId }); + // Started, or refused with the server's sentence: either way the state's own screen says it. + if (result.ok || result.conflict) ui.view = 'auto'; + this.renderLocalModel(); + }, + + /** "Delete" of one row: first the question in the row, then (with `confirmed`) the delete. */ + async deleteLocalModelEntry(modelId, { confirmed = false } = {}) { + const ui = this._localModelWindowState(); + if (!confirmed) { + Object.assign(ui, { confirmDelete: modelId, confirmRemove: false, notice: null }); + this.renderLocalModel(); + // On the safe answer, whatever had the focus (a click does not move it in every browser). + this._focusLocalModelWindow('delete-no'); + return; + } + await this._localModelVerb('DELETE', '/api/local-model/models', { modelId }); + ui.confirmDelete = null; + this.renderLocalModel(); + }, + + /** "Delete them": the downloaded models an earlier Remove kept, while nothing is installed. */ + async deleteLocalModelStore({ confirmed = false } = {}) { + const ui = this._localModelWindowState(); + if (!confirmed) { + Object.assign(ui, { confirmDelete: LOCAL_MODEL_STORE_KEY, notice: null }); + this.renderLocalModel(); + this._focusLocalModelWindow('delete-no'); + return; + } + await this._localModelVerb('DELETE', '/api/local-model', { removeModel: true }); + ui.confirmDelete = null; + this.renderLocalModel(); + }, + + /** Leave a Delete question without deleting. The focus goes back to the button that asked. */ + keepLocalModelEntry() { + const ui = this._localModelWindowState(); + const asked = ui.confirmDelete; + Object.assign(ui, { confirmDelete: null, notice: null }); + this.renderLocalModel(); + if (asked) this._focusLocalModelWindow(asked === LOCAL_MODEL_STORE_KEY ? 'store-delete' : `delete:${asked}`); + }, + cancelLocalModelInstall() { return this._localModelVerb('POST', '/api/local-model/cancel'); }, @@ -767,7 +863,7 @@ Object.assign(CodemanApp.prototype, { async removeLocalModel({ confirmed = false } = {}) { const ui = this._localModelWindowState(); if (!confirmed) { - Object.assign(ui, { confirmRemove: true, notice: null }); + Object.assign(ui, { confirmRemove: true, confirmDelete: null, notice: null }); this.renderLocalModel(); return; } @@ -829,9 +925,20 @@ Object.assign(CodemanApp.prototype, { const status = this._localModelStatus; const install = localModelInstall(status); const model = install.model ? String(install.model.label || install.model.id || '') : ''; - if (install.state === 'installing') return localModelT('Installing {model}', { model }); - if (install.state === 'paused') return localModelT('The install of {model} is paused', { model }); - if (install.state === 'failed') return localModelT('The install of {model} stopped', { model }); + const switching = localModelIsSwitch(install); + if (install.state === 'installing') { + return switching ? localModelT('Switching to {model}', { model }) : localModelT('Installing {model}', { model }); + } + if (install.state === 'paused') { + return switching + ? localModelT('The switch to {model} is paused', { model }) + : localModelT('The install of {model} is paused', { model }); + } + if (install.state === 'failed') { + return switching + ? localModelT('The switch to {model} stopped', { model }) + : localModelT('The install of {model} stopped', { model }); + } if (install.state === 'installed') { if (install.running) return localModelT('{model} is running', { model }); return localModelT('{model} is installed and stopped', { model }); @@ -917,6 +1024,8 @@ Object.assign(CodemanApp.prototype, { foot && tail && tail.classList && (tail.classList.contains('lm-foot') || tail.classList.contains('lm-remove')); body.dataset.screen = screen; body.replaceChildren(...(actions ? parts.slice(0, -1) : parts)); + // A screen that carries the list of models starts at the top and scrolls (see styles.css). + body.dataset.long = body.querySelector('.lm-library') ? 'true' : 'false'; if (foot) foot.replaceChildren(...(actions ? [tail] : [])); body.scrollTop = scrolled; this._settleLocalModelBars(body); @@ -1031,6 +1140,12 @@ Object.assign(CodemanApp.prototype, { tag.classList.add(`lm-tag-${candidate.tag.kind}`); tagSlot.appendChild(tag); } + // Already on this Mac: choosing it switches to it, and nothing is downloaded. + if (candidate.library === 'active') { + tagSlot.appendChild(localModelEl('span', 'lm-tag lm-tag-inuse', localModelT('In use'))); + } else if (candidate.library === 'ready') { + tagSlot.appendChild(localModelEl('span', 'lm-tag lm-tag-ready', localModelT('On this Mac'))); + } row.appendChild(tagSlot); const speed = localModelEl('span', 'lm-model-speed', localModelSpeedText(candidate)); const gauge = localModelEl( @@ -1153,6 +1268,10 @@ Object.assign(CodemanApp.prototype, { if (hints.length) runs.appendChild(localModelEl('span', 'lm-runs-hint', hints.join(' '))); parts.push(runs); + // Nothing is installed, and an earlier Remove kept its downloads: what they take, and the way to free it. + const leftovers = this._localModelStoreEl(install); + if (leftovers) parts.push(leftovers); + const notice = this._localModelNoticeEl(); if (notice) parts.push(notice); @@ -1160,13 +1279,25 @@ Object.assign(CodemanApp.prototype, { const promise = localModelT('No account and no API key. The model runs only on this Mac.'); foot.appendChild(localModelEl('p', 'lm-foot-note', promise)); const buttons = localModelEl('div', 'lm-buttons'); - // Reached from a paused or stopped install: the way back to it. + // Reached from a paused or stopped install, or from an installed model: the way back to it. if (install.state !== 'idle') { buttons.appendChild( localModelButton(localModelT('Back'), { key: 'back', onClick: () => this.leaveLocalModelChooser() }) ); } - if (install.actions.includes('install')) { + if (candidate.library === 'active') { + // The model that runs now: nothing to do with it here. + buttons.appendChild(localModelButton(localModelT('In use'), { key: 'primary', primary: true, disabled: true })); + } else if (candidate.library === 'ready' && install.actions.includes('use')) { + buttons.appendChild( + localModelButton(localModelT('Use this model'), { + key: 'primary', + primary: true, + disabled: ui.busy, + onClick: () => void this.useLocalModel(candidate.modelId), + }) + ); + } else if (install.actions.includes('install')) { buttons.appendChild( localModelButton(localModelT('Install on this Mac'), { key: 'primary', @@ -1181,6 +1312,189 @@ Object.assign(CodemanApp.prototype, { return parts; }, + /** + * The models on this Mac: one row per model of `install.library` with its name, the context + * it was checked with, its state, its size on disk and what the server offers for it. A row + * whose Delete was pressed is followed by the question, once, in place. `null` when there is + * no row, or (with `onlyWithActions`, for a paused or failed job) no row offers anything. + */ + _localModelLibraryEl(install, { onlyWithActions = false } = {}) { + const ui = this._localModelWindowState(); + const rows = localModelLibrary(install); + const offers = (row, action) => Array.isArray(row.actions) && row.actions.includes(action); + if (!rows.length) return null; + if (onlyWithActions && !rows.some((row) => offers(row, 'use') || offers(row, 'delete'))) return null; + + const section = localModelEl('div', 'lm-library'); + const list = localModelEl('div', 'lm-lib-list'); + list.setAttribute('role', 'list'); + list.setAttribute('aria-labelledby', 'localModelLibraryLabel'); + const caption = localModelEl('div', 'lm-lib-caption'); + const label = localModelEl('span', 'lm-lib-caption-label', localModelT('Models on this Mac')); + label.id = 'localModelLibraryLabel'; + caption.appendChild(label); + caption.appendChild(localModelEl('span', 'lm-lib-caption-size', localModelT('On disk'))); + list.appendChild(caption); + + for (const row of rows) { + const name = String(row.label || row.id); + const item = localModelEl('div', row.active === true ? 'lm-lib-row lm-lib-row-on' : 'lm-lib-row'); + item.setAttribute('role', 'listitem'); + const what = localModelEl('div', 'lm-lib-name'); + what.appendChild(localModelEl('span', 'lm-lib-label', name)); + if (Number.isFinite(row.context)) { + what.appendChild( + localModelEl( + 'span', + 'lm-lib-meta', + localModelT('{context} tokens', { context: localModelCount(row.context) }) + ) + ); + } + item.appendChild(what); + const tag = localModelLibraryTag(row); + const tagSlot = localModelEl('span', 'lm-lib-tag'); + tagSlot.appendChild(localModelEl('span', `lm-tag lm-tag-${tag.kind}`, tag.text)); + item.appendChild(tagSlot); + item.appendChild(localModelEl('span', 'lm-lib-size', row.sizeGb ? localModelGb(row.sizeGb) : '')); + + const asking = ui.confirmDelete === row.id && offers(row, 'delete'); + const actions = localModelEl('span', 'lm-lib-actions'); + // While the row's question is open its buttons keep their place and are out of reach, + // so the column of sizes does not move when the question opens. + if (asking) { + actions.classList.add('lm-lib-actions-away'); + actions.setAttribute('aria-hidden', 'true'); + } + if (offers(row, 'use')) { + const use = localModelButton(localModelT('Use'), { + key: `use:${row.id}`, + disabled: ui.busy || asking, + onClick: () => void this.useLocalModel(row.id), + }); + use.classList.add('lm-btn-row'); + use.setAttribute('aria-label', localModelT('Use {model}', { model: name })); + actions.appendChild(use); + } + if (offers(row, 'delete')) { + const remove = localModelButton(localModelT('Delete'), { + key: `delete:${row.id}`, + disabled: ui.busy || asking, + onClick: () => void this.deleteLocalModelEntry(row.id), + }); + remove.classList.add('lm-btn-row'); + remove.setAttribute('aria-label', localModelT('Delete {model}', { model: name })); + actions.appendChild(remove); + } + item.appendChild(actions); + list.appendChild(item); + + if (asking) { + list.appendChild( + this._localModelAskEl({ + question: localModelT('Delete {model} from this Mac?', { model: name }), + detail: row.sizeGb ? localModelT('This frees {size} GB.', { size: row.sizeGb }) : '', + onYes: () => void this.deleteLocalModelEntry(row.id, { confirmed: true }), + }) + ); + } + } + section.appendChild(list); + + const foot = localModelEl('div', 'lm-lib-foot'); + const notes = localModelEl('div', 'lm-lib-notes'); + const store = install.store; + if (store && Number(store.bytes) > 0 && store.gb) { + notes.appendChild( + localModelEl('p', 'lm-aside', localModelT('Downloaded models use {size} GB on this Mac.', { size: store.gb })) + ); + } + // Only the runtime deletes a model: with it stopped, the rows offer none, and this says why. + if (install.state === 'installed' && install.running !== true && rows.length > 1) { + notes.appendChild(localModelEl('p', 'lm-aside', localModelT('Press Start to delete a single model.'))); + } + if (notes.childElementCount) foot.appendChild(notes); + if (install.state === 'installed' && install.actions.includes('install') && this._localModelSelection()) { + const add = localModelButton(localModelT('Add a model'), { + key: 'add', + disabled: ui.busy, + onClick: () => this.chooseLocalModel(), + }); + add.classList.add('lm-btn-row'); + foot.appendChild(add); + } + if (foot.childElementCount) section.appendChild(foot); + return section; + }, + + /** A Delete question in place: the question, what it frees, Cancel and the red Delete. */ + _localModelAskEl({ question, detail, onYes }) { + const ui = this._localModelWindowState(); + const ask = localModelEl('div', 'lm-lib-ask'); + ask.setAttribute('role', 'group'); + const text = localModelEl('div', 'lm-lib-ask-text'); + text.appendChild(localModelEl('p', 'lm-lead', question)); + if (detail) text.appendChild(localModelEl('p', 'lm-aside', detail)); + ask.appendChild(text); + const buttons = localModelEl('div', 'lm-lib-actions'); + const no = localModelButton(localModelT('Cancel'), { + key: 'delete-no', + disabled: ui.busy, + onClick: () => this.keepLocalModelEntry(), + }); + no.classList.add('lm-btn-row'); + const yes = localModelButton(localModelT('Delete'), { + key: 'delete-yes', + danger: true, + disabled: ui.busy, + onClick: onYes, + }); + yes.classList.add('lm-btn-row'); + buttons.appendChild(no); + buttons.appendChild(yes); + ask.appendChild(buttons); + return ask; + }, + + /** + * Nothing is installed and the model store still holds downloads (an earlier Remove kept + * them): what they take on disk and "Delete them", asked once in place. `null` unless the + * server offers that removal. + */ + _localModelStoreEl(install) { + const ui = this._localModelWindowState(); + const store = install.store; + if (install.state !== 'idle' || !install.actions.includes('remove')) return null; + if (!store || !(Number(store.bytes) > 0) || !store.gb) return null; + if (ui.confirmDelete === LOCAL_MODEL_STORE_KEY) { + const box = localModelEl('div', 'lm-leftovers'); + box.appendChild( + this._localModelAskEl({ + question: localModelT('Delete the downloaded models from this Mac?'), + detail: localModelT('This frees {size} GB.', { size: store.gb }), + onYes: () => void this.deleteLocalModelStore({ confirmed: true }), + }) + ); + return box; + } + const box = localModelEl('div', 'lm-leftovers lm-lib-foot'); + box.appendChild( + localModelEl( + 'p', + 'lm-aside', + localModelT('Models from an earlier install still use {size} GB on this Mac.', { size: store.gb }) + ) + ); + const remove = localModelButton(localModelT('Delete them'), { + key: 'store-delete', + disabled: ui.busy, + onClick: () => void this.deleteLocalModelStore(), + }); + remove.classList.add('lm-btn-row'); + box.appendChild(remove); + return box; + }, + /** Arrow keys, Home and End move the selection of the radio group, and the focus with it. */ _onLocalModelListKey(event) { const selection = this._localModelSelection(); @@ -1397,9 +1711,18 @@ Object.assign(CodemanApp.prototype, { const paused = screen === 'paused'; const model = install.model ? String(install.model.label || install.model.id || '') : ''; const parts = []; - const title = paused - ? localModelT('The install of {model} is paused', { model }) - : localModelT('Installing {model}', { model }); + // A switch to a model that is on this Mac already downloads nothing, and says so in its name. + const switching = localModelIsSwitch(install); + let title; + if (switching) { + title = paused + ? localModelT('The switch to {model} is paused', { model }) + : localModelT('Switching to {model}', { model }); + } else { + title = paused + ? localModelT('The install of {model} is paused', { model }) + : localModelT('Installing {model}', { model }); + } parts.push(localModelEl('p', 'lm-title', title)); // The download bar takes the place of the memory bar, for as long as something downloads. @@ -1414,19 +1737,26 @@ Object.assign(CodemanApp.prototype, { return parts; } - // What waits or goes on is the download while there is one, the install after it. + // What waits or goes on is the download while there is one, the install (or the switch) after it. const downloading = !!meter; let note; - if (paused) { + if (paused && switching) { + note = localModelT('The switch waits until you continue.'); + } else if (paused) { note = downloading ? localModelT('The download waits until you continue.') : localModelT('The install waits until you continue.'); + } else if (switching) { + note = localModelT('You can close this window. The switch continues while Codeman is running.'); } else { note = downloading ? localModelT('You can close this window. The download continues while Codeman is running.') : localModelT('You can close this window. The install continues while Codeman is running.'); } parts.push(localModelEl('p', 'lm-aside', note)); + // A paused job that has a checked model beside it: the way back to that model. + const library = paused ? this._localModelLibraryEl(install, { onlyWithActions: true }) : null; + if (library) parts.push(library); const notice = this._localModelNoticeEl(); if (notice) parts.push(notice); @@ -1548,6 +1878,9 @@ Object.assign(CodemanApp.prototype, { parts.push(this._localModelRemoveEl()); return parts; } + // A checked model beside the one that stopped: the way back to it. + const library = this._localModelLibraryEl(install, { onlyWithActions: true }); + if (library) parts.push(library); const notice = this._localModelNoticeEl(); if (notice) parts.push(notice); @@ -1641,13 +1974,17 @@ Object.assign(CodemanApp.prototype, { const tools = this._localModelDeveloperToolsEl(); if (tools) parts.push(tools); const notice = this._localModelNoticeEl(); - if (notice) parts.push(notice); const can = (action) => install.actions.includes(action); const next = error ? this._localModelNextButton(install, error) : null; // The screen that ends an install has one button. Stop and Remove are for the window // opened later (or for this one once anything else was said in it). const ending = ui.justInstalled === true && can('start-session') && !error && !notice; + // Everything that is on this Mac, what it takes on disk, and the way to another model. + // Not on the screen that ends an install: that one says one thing. + const library = ending ? null : this._localModelLibraryEl(install); + if (library) parts.push(library); + if (notice) parts.push(notice); const foot = localModelEl('div', 'lm-foot'); const buttons = localModelEl('div', 'lm-buttons'); if (!ending && can('remove') && error?.next !== 'remove') { @@ -1703,6 +2040,8 @@ Object.assign(CodemanApp.prototype, { if (hw) parts.push(hw); const reason = localModelMessage(status.recommendation.headline); if (reason) parts.push(localModelEl('p', 'lm-reason', reason)); + const leftovers = this._localModelStoreEl(localModelInstall(status)); + if (leftovers) parts.push(leftovers); const notice = this._localModelNoticeEl(); if (notice) parts.push(notice); const foot = localModelEl('div', 'lm-foot'); diff --git a/src/web/public/mobile.css b/src/web/public/mobile.css index 9a8c3a38..56fe902e 100644 --- a/src/web/public/mobile.css +++ b/src/web/public/mobile.css @@ -1887,6 +1887,11 @@ html.mobile-init .file-browser-panel { justify-content: flex-end; } + /* A screen with the list of models scrolls from its top. */ + .local-model-window > .lm-body[data-long='true'] { + justify-content: flex-start; + } + /* Ralph wizard responsive */ .modal-wizard { display: flex; @@ -4339,6 +4344,61 @@ html[data-session-list="sidebar"] .session-sidebar .session-tab .tab-close { grid-column: 3; } + /* The models on this Mac: the name and its size, then the state and what can be done. */ + .lm-lib-list { + grid-template-columns: minmax(0, 1fr) auto; + column-gap: 0.7rem; + } + + .lm-lib-caption-label { + grid-column: 1; + } + + .lm-lib-caption-size { + grid-column: 2; + } + + .lm-lib-row { + row-gap: 0.15rem; + padding-top: 0.45rem; + padding-bottom: 0.45rem; + } + + .lm-lib-name { + grid-row: 1; + grid-column: 1; + padding: 0; + } + + .lm-lib-size { + grid-row: 1; + grid-column: 2; + } + + .lm-lib-tag { + grid-row: 2; + grid-column: 1; + } + + .lm-lib-actions { + grid-row: 2; + grid-column: 2; + } + + .lm-lib-ask { + margin-inline: 0.7rem; + } + + .lm-lib-foot { + flex-wrap: wrap; + } + + /* A row's buttons keep their own size: they sit in the row, not under the thumb. */ + .local-model-window .wt-btn.lm-btn.lm-btn-row { + min-height: 36px; + font-size: 0.8rem; + } + .lm-foot { flex-direction: column; align-items: stretch; diff --git a/src/web/public/styles.css b/src/web/public/styles.css index af663547..2c952ce2 100644 --- a/src/web/public/styles.css +++ b/src/web/public/styles.css @@ -22467,6 +22467,13 @@ html[data-skin='rose-pine-dawn'] { padding-bottom: 2.2rem; } +/* A screen that carries the list of models is no short screen: it starts at the + top and scrolls, or its first lines would be cut off above the frame. */ +.local-model-window > .lm-body[data-long='true'] { + justify-content: flex-start; + padding-bottom: 1.2rem; +} + /* The foot of the frame: the buttons of the screen (or the Remove question), outside the part that scrolls. */ .local-model-window > .lm-foot-slot { @@ -22808,7 +22815,9 @@ html[data-skin='rose-pine-dawn'] { .lm-model-tag { display: flex; + flex-wrap: wrap; justify-content: flex-start; + gap: 0.25rem; } /* A tag says one thing about a row, in the colour of what it says. */ @@ -22844,6 +22853,29 @@ html[data-skin='rose-pine-dawn'] { color: var(--lm-orange); } +/* The states of a model that is on this Mac: in use takes the feature's own + colour, ready is good, a changed or missing one is a warning. A model that + was never checked keeps the quiet tag. */ +.lm-tag-inuse { + background: color-mix(in srgb, var(--lm-brand) 20%, transparent); + color: var(--lm-brand); +} + +.lm-tag-ready { + background: color-mix(in srgb, var(--lm-good) 15%, transparent); + color: var(--lm-good); +} + +.lm-tag-changed { + background: color-mix(in srgb, var(--lm-amber) 15%, transparent); + color: var(--lm-amber); +} + +.lm-tag-missing { + background: color-mix(in srgb, var(--lm-orange) 15%, transparent); + color: var(--lm-orange); +} + .lm-model-speed, .lm-model-size { text-align: end; @@ -23218,6 +23250,176 @@ html[data-skin='rose-pine-dawn'] { accent-color: var(--lm-brand); } +/* ── the models on this Mac ───────────────────────────────────────── */ +/* Name with its context, state, size on disk, and what can be done with the + row. One grid like the chooser's, so the sizes line up down the list. The + model in use wears the chooser's selected look: it is the one that runs. */ +.lm-library { + display: flex; + flex-direction: column; + gap: 0.55rem; +} + +.lm-lib-list { + display: grid; + grid-template-columns: minmax(0, max-content) minmax(0, 1fr) auto auto; + column-gap: 0.75rem; + row-gap: 0.1rem; + margin-inline: calc(-0.7rem - 2px) -0.7rem; +} + +.lm-lib-caption, +.lm-lib-row { + display: grid; + grid-column: 1 / -1; + grid-template-columns: subgrid; + align-items: center; + padding: 0 0.7rem; + border-inline-start: 2px solid transparent; +} + +.lm-lib-caption { + padding-bottom: 0.3rem; + font-size: 0.7rem; + color: var(--text-dim); +} + +.lm-lib-caption-label { + grid-column: 1 / span 2; +} + +.lm-lib-caption-size { + grid-column: 3; + text-align: end; +} + +.lm-lib-row { + min-height: 2.9rem; + border-radius: 9px; +} + +.lm-lib-row-on { + border-inline-start-color: var(--lm-brand); + background: linear-gradient( + 90deg, + color-mix(in srgb, var(--lm-brand) 17%, transparent), + color-mix(in srgb, var(--lm-brand) 4%, transparent) + ); +} + +.lm-lib-name { + display: flex; + flex-direction: column; + min-width: 0; + padding: 0.35rem 0; +} + +.lm-lib-label { + font-size: 0.86rem; + font-weight: 600; + line-height: 1.35; + color: var(--text); + overflow-wrap: anywhere; +} + +.lm-lib-meta { + font-size: 0.7rem; + line-height: 1.4; + color: var(--text-dim); + font-variant-numeric: tabular-nums; +} + +.lm-lib-tag { + display: flex; + justify-content: flex-start; +} + +.lm-lib-size { + text-align: end; + white-space: nowrap; + font-size: 0.8rem; + font-weight: 560; + color: var(--text); + font-variant-numeric: tabular-nums; +} + +.lm-lib-actions { + display: flex; + flex-shrink: 0; + justify-content: flex-end; + gap: 0.35rem; +} + +/* While a row's Delete question is open its buttons keep their room, unseen: + the sizes above and below must not jump sideways. */ +.lm-lib-actions-away { + visibility: hidden; +} + +/* The buttons of a row are a size smaller than the buttons of the screen. */ +.local-model-window .wt-btn.lm-btn.lm-btn-row { + padding: 0.28rem 0.65rem; + font-size: 0.74rem; +} + +/* The Delete question of one row, in place under it: the row is what it is about. */ +.lm-lib-ask { + display: flex; + grid-column: 1 / -1; + flex-wrap: wrap; + align-items: center; + justify-content: space-between; + gap: 0.5rem 1rem; + margin: 0.1rem 0.7rem 0.4rem; + padding: 0.6rem 0.75rem; + border: 1px solid var(--border); + border-radius: 9px; +} + +.lm-lib-ask-text { + display: flex; + flex-direction: column; + gap: 0.1rem; + min-width: 0; +} + +/* Under the list: what all downloads take on disk, and the way to another model. */ +.lm-lib-foot { + display: flex; + align-items: center; + justify-content: space-between; + gap: 0.5rem 1rem; +} + +.lm-lib-notes { + display: flex; + flex-direction: column; + gap: 0.15rem; + min-width: 0; +} + +/* Nothing installed, and an earlier Remove kept its downloads. */ +.lm-leftovers .lm-lib-ask { + margin-inline: 0; +} + +/* A browser without subgrid: fixed tracks keep the columns in line. */ +@supports not (grid-template-columns: subgrid) { + .lm-lib-list { + display: block; + } + + .lm-lib-caption, + .lm-lib-row { + grid-template-columns: minmax(0, 12rem) minmax(0, 1fr) 4.5rem minmax(0, auto); + column-gap: 0.75rem; + } + + .lm-lib-row { + margin-top: 0.1rem; + } +} + /* ── the foot: one promise on the left, the action on the right ──── */ .lm-foot { display: flex; @@ -23293,6 +23495,10 @@ html[data-skin='rose-pine-dawn'] { min-height: 2.9rem; } + .local-model-window .wt-btn.lm-btn.lm-btn-row { + min-height: 36px; + } + .lm-select { min-height: 36px; } diff --git a/src/web/routes/local-model-routes.ts b/src/web/routes/local-model-routes.ts index 2cd8bc6a..f7d63a4c 100644 --- a/src/web/routes/local-model-routes.ts +++ b/src/web/routes/local-model-routes.ts @@ -6,15 +6,19 @@ * |----------------------------------|-----------------------------|------------------------------------------------| * | `GET /api/local-model` | none | `{ hardware, recommendation, catalogUpdated, install }` | * | `POST /api/local-model/install` | `LocalModelInstallRequest` | the install view; 400, 409 | + * | `POST /api/local-model/use` | `LocalModelUseRequest` | the install view; 400, 409 | * | `POST /api/local-model/cancel` | none | the install view; 409 | * | `POST /api/local-model/resume` | `LocalModelResumeRequest` | the install view; 409 | * | `POST /api/local-model/runtime` | `LocalModelRuntimeRequest` | the install view; 409 | * | `DELETE /api/local-model` | `LocalModelRemoveRequest` | the install view; 409 | + * | `DELETE /api/local-model/models` | `LocalModelDeleteRequest` | the install view; 400, 409, 500 | * * The GET is built from the hardware probe, the catalogue, the harness facts and the pure * `recommend()`, plus the `install` object of the install service - * (`LocalModelService.view()`). Nothing is reformatted here: every size text and every - * sentence in the payload was chosen by the modules that produced it. There is no SSE event: + * (`LocalModelService.view()`). The one thing joined here: a row of the recommendation that is + * a checked model of the library is marked (`Candidate.library`, by `markLibraryCandidates()`). + * Nothing is reformatted: every size text and every sentence in the payload was chosen by the + * modules that produced it. There is no SSE event: * the window polls the GET once a second while it is open. * * EXPERIMENTAL (docs/versioning-policy.md, "Experimental local model routes"): the routes and @@ -45,9 +49,12 @@ * or of the endpoint store that was refused (a file that does not parse) is a 409 without * `data`, with the fix. * - The verbs do the work in the install service; this file only gates, parses and maps. - * `DELETE`, `runtime` and `resume` look at the live sessions: they hand their names to the - * service, which refuses a removal, a stop and a change of port while one of them still - * uses the model. + * `DELETE /api/local-model`, `runtime`, `resume`, `install` and `use` look at the live + * sessions: they hand their names to the service, which refuses a removal, a stop, a change + * of port, another model and a switch while one of them still uses the model. + * - `DELETE /api/local-model/models` takes a model NAME in its body, never a path: the schema + * admits only `name:tag`, and the service deletes only a name of its own listing, through + * the runtime. * - Every dependency is injected (`LocalModelRouteDeps`), so a route test spawns nothing and * does not need a Mac: it passes its own hardware, harness facts and service. */ @@ -83,16 +90,19 @@ import { buildHarnessFacts } from '../../local-model/harness-facts.js'; import { formatInstallMessage, getLocalModelService, + markLibraryCandidates, type LocalModelActor, type LocalModelService, type LocalModelVerbResult, } from '../../local-model/install-job.js'; import { recommend } from '../../local-model/recommend.js'; import { + LocalModelDeleteSchema, LocalModelInstallSchema, LocalModelRemoveSchema, LocalModelResumeSchema, LocalModelRuntimeSchema, + LocalModelUseSchema, } from '../schemas.js'; import { SettingsWriteRefusedError, settingsWriteErrorResponse } from '../settings-writer.js'; @@ -156,7 +166,7 @@ export interface LocalModelConflictResponse { data: LocalModelConflict; } -/** The 400 (or 507) of a verb the service refused with a sentence: the error envelope plus that sentence as `data`. */ +/** The 400 (or 500, or 507) of a verb the service refused with a sentence: the error envelope plus that sentence as `data`. */ export interface LocalModelRefusalResponse { success: false; /** The sentence in English, its slots filled. */ @@ -251,8 +261,12 @@ export function registerLocalModelRoutes( // The measured budget once the runtime reported it, and the runtime download that an // install would still add: what turns the estimate into the figures of the consent. const options = await service.recommendOptions(); - const recommendation = resolved.recommend(hardware, catalog, harnessFacts, options); const install = await service.view(); + // A row that is already a checked model on this Mac says so: choosing it is a switch. + const recommendation = markLibraryCandidates( + resolved.recommend(hardware, catalog, harnessFacts, options), + install + ); return { success: true, data: { hardware, recommendation, catalogUpdated: catalog.updated, install } }; } catch (err) { reply.code(500); @@ -268,7 +282,17 @@ export function registerLocalModelRoutes( const denied = adminOnly(req, reply); if (denied) return denied; const body = parseBody(LocalModelInstallSchema, req.body); - return runVerb(reply, () => resolved.service().install(body, actorOf(req))); + // Asked at the moment of the request: another model takes the runtime from a live session. + const sessionNames = sessionNamesUsingEndpoint(ctx.sessions.values()); + return runVerb(reply, () => resolved.service().install(body, actorOf(req), sessionNames)); + }); + + app.post('/api/local-model/use', async (req, reply): Promise => { + const denied = adminOnly(req, reply); + if (denied) return denied; + const body = parseBody(LocalModelUseSchema, req.body); + const sessionNames = sessionNamesUsingEndpoint(ctx.sessions.values()); + return runVerb(reply, () => resolved.service().use(body, actorOf(req), sessionNames)); }); app.post('/api/local-model/cancel', async (req, reply): Promise => { @@ -303,4 +327,11 @@ export function registerLocalModelRoutes( const sessionNames = sessionNamesUsingEndpoint(ctx.sessions.values()); return runVerb(reply, () => resolved.service().remove(body, sessionNames, actorOf(req))); }); + + app.delete('/api/local-model/models', async (req, reply): Promise => { + const denied = adminOnly(req, reply); + if (denied) return denied; + const body = parseBody(LocalModelDeleteSchema, req.body); + return runVerb(reply, () => resolved.service().deleteLibraryModel(body, actorOf(req))); + }); } diff --git a/src/web/schemas.ts b/src/web/schemas.ts index 5fb327c3..33c2063e 100644 --- a/src/web/schemas.ts +++ b/src/web/schemas.ts @@ -2505,6 +2505,12 @@ export const LocalModelRuntimeSchema = z /** DELETE /api/local-model. The body may be empty. */ export const LocalModelRemoveSchema = z.object({ removeModel: z.boolean().optional() }).strict(); +/** POST /api/local-model/use: a checked model of the library to switch to. */ +export const LocalModelUseSchema = z.object({ modelId: localModelId }).strict(); + +/** DELETE /api/local-model/models: one model of the store, by its name. Never a path. */ +export const LocalModelDeleteSchema = z.object({ modelId: localModelId }).strict(); + /** * A shell-safe bare word, mirroring `config/cli-registry/schema.ts`'s own `shellToken` — * duplicated rather than imported, since the REAL safety boundary for anything built from diff --git a/test/fixtures/fake-ollama.ts b/test/fixtures/fake-ollama.ts index 3b889027..912b3fed 100644 --- a/test/fixtures/fake-ollama.ts +++ b/test/fixtures/fake-ollama.ts @@ -18,6 +18,7 @@ * | `GET /api/ps` | the model once a chat loaded it (`size`, `size_vram`, `context_length`) | * | `POST /api/pull` | NDJSON progress, see `FakePullSwitches` | * | `DELETE /api/delete` | 200, or 404 for a model that is not installed | + * | | (the model, or one of `otherModels`) | * | `GET /v1/models` | the model's id, or `data: null` when none is installed (as the real one) | * | `POST /v1/chat/completions` | a plain answer, or a tool call when the request carries `tools` | * | `GET /download/ollama-darwin.tgz` | a small real `.tgz` with Range support, see `FakeArchiveSwitches` | @@ -220,6 +221,14 @@ export interface FakeOllamaOptions { spawn?: Partial; /** The files of the fake runtime archive, name to content. Default: one executable `ollama` script. */ archiveFiles?: Record; + /** + * More models the registry has beside `model`: each can be pulled (a short stream that + * succeeds), listed, loaded, checked and deleted on its own. The pull, chat and tool + * switches apply to them too, except the pull's failures and shapes, which are `model`'s. + */ + otherModels?: FakeOllamaModel[]; + /** The ids of `otherModels` that are on disk from the start. */ + othersInstalled?: string[]; } export interface CapturedRequest { @@ -304,6 +313,10 @@ export interface FakeOllama { archiveRequests: number; /** Every child `spawn` made, oldest first. */ children: FakeRuntimeChild[]; + /** The ids of `otherModels` that are on disk: pulled, or installed from the start. */ + others: string[]; + /** The id of the model the last chat loaded. The runtime holds one model at a time. */ + loadedId?: string; }; /** The fake runtime archive: a real gzipped tar. */ readonly archive: { readonly body: Buffer; readonly size: number; readonly sha256: string }; @@ -436,7 +449,26 @@ export function createFakeOllama(options: FakeOllamaOptions = {}): FakeOllama { pulls: 0, archiveRequests: 0, children: [], + others: [...(options.othersInstalled ?? [])], }; + const otherModels = options.otherModels ?? []; + /** One of `otherModels` by its id, whether it is on disk or not. */ + const otherModel = (id: unknown): FakeOllamaModel | undefined => otherModels.find((other) => other.id === id); + /** The model `id` names when it is on disk: `model` or one of the others. */ + const onDisk = (id: unknown): FakeOllamaModel | undefined => { + if (id === model.id) return state.installed ? model : undefined; + const other = otherModel(id); + return other && state.others.includes(other.id) ? other : undefined; + }; + const tagRow = (entry: FakeOllamaModel): Record => ({ + name: entry.id, + model: entry.id, + modified_at: '2026-11-06T15:10:02.465346347+01:00', + size: entry.bytes, + digest: entry.digest, + details: { ...modelDetails(), format: entry.format, context_length: 262144, runner: entry.runner }, + capabilities: entry.capabilities, + }); const requests: CapturedRequest[] = []; const sockets = new Set(); let server: Server | undefined; @@ -475,6 +507,18 @@ export function createFakeOllama(options: FakeOllamaOptions = {}): FakeOllama { }; if (!(await line({ status: 'pulling manifest' }))) return; + // One of the other models: a short stream that succeeds. + const other = otherModel(askedId); + if (other && pull.fail !== 'not-found') { + const layer = { status: 'pulling model', digest: 'sha256:other', total: other.bytes }; + if (!(await line({ ...layer, completed: 0 }))) return; + if (!(await line({ ...layer, completed: other.bytes }))) return; + if (!(await line({ status: 'writing manifest' }))) return; + if (!state.others.includes(other.id)) state.others.push(other.id); + await line({ status: 'success' }); + res.end(); + return; + } // Not captured on a Mac: the wording of the runtime for a tag the registry does not have. if (pull.fail === 'not-found' || askedId !== model.id) { await line({ error: 'pull model manifest: file does not exist' }); @@ -528,7 +572,8 @@ export function createFakeOllama(options: FakeOllamaOptions = {}): FakeOllama { function handleChat(res: ServerResponse, body: unknown): void { const request = (body as { model?: unknown; tools?: unknown } | undefined) ?? {}; - if (!state.installed || request.model !== model.id) { + const served = onDisk(request.model); + if (!served) { sendJson(res, 404, { error: { message: `model '${String(request.model)}' not found`, @@ -544,7 +589,7 @@ export function createFakeOllama(options: FakeOllamaOptions = {}): FakeOllama { id: `chatcmpl-${chatCounter++}`, object: 'chat.completion', created: 1793968038, - model: model.id, + model: served.id, system_fingerprint: 'fp_ollama', choices: [{ index: 0, message: { role: 'assistant', ...message }, finish_reason: finishReason }], usage: { @@ -563,12 +608,18 @@ export function createFakeOllama(options: FakeOllamaOptions = {}): FakeOllama { }); return; } - if (switches.ps.loaded !== false) state.loaded = true; + if (switches.ps.loaded !== false) { + state.loaded = true; + state.loadedId = served.id; + } sendJson(res, 200, envelope({ content: 'pong' }, 'stop')); return; } - if (switches.ps.loaded !== false) state.loaded = true; + if (switches.ps.loaded !== false) { + state.loaded = true; + state.loadedId = served.id; + } const fn = (tools[0] as { function?: { name?: unknown; parameters?: { properties?: unknown } } }).function ?? {}; const name = typeof fn.name === 'string' ? fn.name : 'tool'; const properties = (fn.parameters?.properties ?? {}) as Record; @@ -648,39 +699,31 @@ export function createFakeOllama(options: FakeOllamaOptions = {}): FakeOllama { } if (path === '/api/version' && method === 'GET') return sendJson(res, 200, { version }); if (path === '/api/tags' && method === 'GET') { - const models = state.installed - ? [ - { - name: model.id, - model: model.id, - modified_at: '2026-11-06T15:10:02.465346347+01:00', - size: model.bytes, - digest: model.digest, - details: { ...modelDetails(), context_length: 262144, runner: model.runner }, - capabilities: model.capabilities, - }, - ] - : []; + const models = [ + ...(state.installed ? [tagRow(model)] : []), + ...otherModels.filter((other) => state.others.includes(other.id)).map(tagRow), + ]; return sendJson(res, 200, { models }); } if (path === '/api/ps' && method === 'GET') { - const size = switches.ps.size ?? model.bytes + 100_000_000; - const models = - state.installed && state.loaded && switches.ps.loaded !== false - ? [ - { - name: model.id, - model: model.id, - size, - digest: model.digest, - details: modelDetails(), - expires_at: '2026-11-06T15:20:09.488045+01:00', - size_vram: switches.ps.sizeVram ?? size, - context_length: switches.ps.contextLength ?? contextLength, - runner: model.runner, - }, - ] - : []; + // The runtime holds ONE model: the one the last chat loaded. + const held = state.loaded && switches.ps.loaded !== false ? onDisk(state.loadedId ?? model.id) : undefined; + const size = switches.ps.size ?? (held ?? model).bytes + 100_000_000; + const models = held + ? [ + { + name: held.id, + model: held.id, + size, + digest: held.digest, + details: modelDetails(), + expires_at: '2026-11-06T15:20:09.488045+01:00', + size_vram: switches.ps.sizeVram ?? size, + context_length: switches.ps.contextLength ?? contextLength, + runner: held.runner, + }, + ] + : []; return sendJson(res, 200, { models }); } if (path === '/api/pull' && method === 'POST') return handlePull(res, body); @@ -688,20 +731,35 @@ export function createFakeOllama(options: FakeOllamaOptions = {}): FakeOllama { // Not captured: the answers of a delete (200 with no body, 404 with an error text). const asked = (body as { model?: unknown; name?: unknown } | undefined) ?? {}; const askedId = typeof asked.model === 'string' ? asked.model : asked.name; + const other = otherModel(askedId); + if (other && state.others.includes(other.id)) { + state.others = state.others.filter((id) => id !== other.id); + if (state.loadedId === other.id) { + state.loaded = false; + state.loadedId = undefined; + } + res.writeHead(200); + res.end(); + return; + } if (!state.installed || askedId !== model.id) { return sendJson(res, 404, { error: `model '${String(askedId)}' not found` }); } state.installed = false; state.loaded = false; + state.loadedId = undefined; state.completedBytes = 0; res.writeHead(200); res.end(); return; } if (path === '/v1/models' && method === 'GET') { - const data = state.installed - ? [{ id: model.id, object: 'model', created: 1793967749, owned_by: 'library' }] - : null; + const ids = [ + ...(state.installed ? [model.id] : []), + ...otherModels.filter((other) => state.others.includes(other.id)).map((other) => other.id), + ]; + const data = + ids.length > 0 ? ids.map((id) => ({ id, object: 'model', created: 1793967749, owned_by: 'library' })) : null; return sendJson(res, 200, { object: 'list', data }); } if (path === '/v1/chat/completions' && method === 'POST') return handleChat(res, body); diff --git a/test/local-model-install-e2e.test.ts b/test/local-model-install-e2e.test.ts index f87a5261..ab654705 100644 --- a/test/local-model-install-e2e.test.ts +++ b/test/local-model-install-e2e.test.ts @@ -345,7 +345,7 @@ describe('the install from the first GET to Remove, real modules over a fake run endpointId: 'local-ollama', folder: world.paths.root, loaded: { context: pick.context, onGpu: true }, - actions: ['start-session', 'stop', 'remove'], + actions: ['start-session', 'stop', 'install', 'remove'], runtime: { installed: true, downloadBytes: 0, downloadGb: formatGb(0) }, }); @@ -682,6 +682,154 @@ describe('the install from the first GET to Remove, real modules over a fake run }, 60_000); }); +describe('the library: a second model, the switch back, and the delete of one model', () => { + it('installs A, adds B beside it, switches back to A, and deletes B, with one model in use throughout', async () => { + const { app, get, settled, install: clickInstall } = await routes(); + const hostsModels = async () => + (await readCustomModelHosts(getDataDir())).find((host) => host.id === 'local-ollama')?.models; + const post = (url: string, payload: unknown) => app.inject({ method: 'POST', url, payload: payload as object }); + const deleteModel = (modelId: string) => + app.inject({ method: 'DELETE', url: '/api/local-model/models', payload: { modelId } }); + + // ---- A: the first install ---- + world.agentInstalled = true; + const first = await get(); + const a = first.recommendation.pick!; + const bRow = first.recommendation.alternatives[0]; + expect(bRow).toBeDefined(); + expect(bRow.modelId).not.toBe(a.modelId); + const B_DIGEST = 'b'.repeat(64); + world.runtime = createFakeOllama({ + model: { id: a.modelId, bytes: a.downloadBytes }, + contextLength: a.context, + otherModels: [ + { + id: bRow.modelId, + bytes: bRow.downloadBytes, + digest: B_DIGEST, + format: 'gguf', + runner: 'ggml', + quantization: 'Q4_K_M', + capabilities: ['completion', 'tools'], + }, + ], + }); + const runtime = world.runtime; + expect((await clickInstall(a)).statusCode).toBe(200); + expect((await settled()).state).toBe('installed'); + + let status = await get(); + expect(status.install.library).toEqual([ + { + id: a.modelId, + label: a.modelLabel, + context: a.context, + sizeBytes: a.downloadBytes, + sizeGb: formatGb(a.downloadBytes), + active: true, + verified: true, + status: 'ready', + actions: [], + }, + ]); + // The store of the fake runtime writes no blobs: measured, and empty. + expect(status.install.store).toEqual({ bytes: 0, gb: '0.0' }); + // The chooser says the row is the model in use. + expect(status.recommendation.pick?.library).toBe('active'); + expect(status.install.actions).toEqual(['start-session', 'stop', 'install', 'remove']); + + // ---- B: a second model. Refused while a session uses A. ---- + const b = [status.recommendation.pick!, ...status.recommendation.alternatives].find( + (row) => row.modelId === bRow.modelId + )!; + // The runtime is on disk now, so the server's total for B is the model alone. + expect(b.installBytes).toBe(b.downloadBytes); + const addB = { modelId: b.modelId, cli: 'opencode', context: b.context, acknowledgedBytes: b.installBytes }; + world.sessions.set('s1', { name: 'w1-app', customModel: { endpointId: 'local-ollama' } }); + const busy = await post('/api/local-model/install', addB); + expect(busy.statusCode).toBe(409); + expect(busy.json().data).toMatchObject({ reason: 'sessions-open', sessions: ['w1-app'] }); + expect(runtime.state.pulls).toBe(1); + world.sessions.clear(); + + // The fake runtime reports the context it was "started with": B's from here on. + runtime.switches.ps.contextLength = b.context; + const started = await post('/api/local-model/install', addB); + expect(started.statusCode).toBe(200); + expect(started.json().data).toMatchObject({ state: 'installing', model: { id: b.modelId } }); + const withB = await settled(); + expect(withB.error).toBeUndefined(); + expect(withB).toMatchObject({ + state: 'installed', + model: { id: b.modelId, label: b.modelLabel }, + context: b.context, + endpointId: 'local-ollama', + }); + // Both are on disk, A was not deleted, and the ONE endpoint record lists the model in use. + expect(runtime.state.installed).toBe(true); + expect(runtime.state.others).toEqual([b.modelId]); + expect(await hostsModels()).toEqual([b.modelId]); + expect(runtime.requests.some((request) => request.path === '/api/delete')).toBe(false); + await vi.waitFor(async () => { + const library = (await get()).install.library; + expect(library.map((row) => [row.id, row.active, row.status, row.actions])).toEqual([ + [b.modelId, true, 'ready', []], + [a.modelId, false, 'ready', ['use', 'delete']], + ]); + }); + const stored = await readLocalModelState(); + expect(stored.library?.map((entry) => [entry.id, entry.context, entry.digest])).toEqual([ + [a.modelId, a.context, runtime.model.digest], + [b.modelId, b.context, B_DIGEST], + ]); + // Only the model in use may be launched on the endpoint. + expect(await world.service.launchRefusalMessage('local-ollama', b.modelId)).toBeUndefined(); + expect(await world.service.launchRefusalMessage('local-ollama', a.modelId)).toContain('is in use on this Mac'); + + // ---- The model in use cannot be deleted ---- + const active = await deleteModel(b.modelId); + expect(active.statusCode).toBe(409); + expect(active.json().data).toMatchObject({ reason: 'model-active' }); + expect(runtime.state.others).toEqual([b.modelId]); + + // ---- Back to A: nothing is downloaded ---- + status = await get(); + expect(status.recommendation.pick?.library ?? status.recommendation.alternatives[0].library).toBeDefined(); + world.sessions.set('s1', { name: 'w1-app', customModel: { endpointId: 'local-ollama' } }); + const useBusy = await post('/api/local-model/use', { modelId: a.modelId }); + expect(useBusy.statusCode).toBe(409); + expect(useBusy.json().data).toMatchObject({ reason: 'sessions-open' }); + world.sessions.clear(); + + runtime.switches.ps.contextLength = a.context; + const pullsBefore = runtime.state.pulls; + const switched = await post('/api/local-model/use', { modelId: a.modelId }); + expect(switched.statusCode).toBe(200); + expect(switched.json().data).toMatchObject({ state: 'installing', steps: ['verify', 'connect'] }); + const backOnA = await settled(); + expect(backOnA.error).toBeUndefined(); + expect(backOnA).toMatchObject({ state: 'installed', model: { id: a.modelId }, context: a.context }); + expect(runtime.state.pulls).toBe(pullsBefore); + expect(await hostsModels()).toEqual([a.modelId]); + expect(await world.service.launchRefusalMessage('local-ollama', a.modelId)).toBeUndefined(); + + // ---- Delete B: through the runtime, by its name ---- + const notOurs = await deleteModel('someone-else:7b'); + expect(notOurs.statusCode).toBe(400); + const gone = await deleteModel(b.modelId); + expect(gone.statusCode).toBe(200); + expect(gone.json().data.library.map((row: { id: string }) => row.id)).toEqual([a.modelId]); + expect(runtime.state.others).toEqual([]); + expect(runtime.state.installed).toBe(true); + const deletes = runtime.requests.filter((request) => request.path === '/api/delete'); + expect(deletes.map((request) => request.body)).toEqual([{ model: b.modelId }]); + expect((await readLocalModelState()).library?.map((entry) => entry.id)).toEqual([a.modelId]); + expect((await get()).install.actions).toEqual(['start-session', 'stop', 'install', 'remove']); + // A is in use: it can only go with the whole installation. + expect((await deleteModel(a.modelId)).statusCode).toBe(409); + }); +}); + describe('a server that is killed leaves its runtime running: the next server never deletes under it', () => { /** * Installs up to the model download, then "kills" the server: its job stops and it signals diff --git a/test/local-model-install-job.test.ts b/test/local-model-install-job.test.ts index dec84ee8..29624c27 100644 --- a/test/local-model-install-job.test.ts +++ b/test/local-model-install-job.test.ts @@ -17,13 +17,18 @@ import { allowedActions, buildInstallError, buildInstallView, + buildLibraryRows, formatInstallMessage, INSTALL_STATE_TABLE, INSTALL_STEP_TABLE, INSTALL_TRANSITIONS, installedBlocker, jobSteps, + libraryOf, + markLibraryCandidates, reduceInstallJob, + upsertLibraryEntry, + USE_JOB_STEPS, type InstallJobEvent, type InstallJobEventType, type InstallLiveFacts, @@ -38,12 +43,15 @@ import { type LocalModelErrorCode, type LocalModelInstallState, type LocalModelInstallStep, + type LocalModelLibraryEntry, type LocalModelStateFile, + type Recommendation, } from '../src/types.js'; const STATES: LocalModelInstallState[] = ['idle', 'installing', 'paused', 'failed', 'installed']; const EVENT_TYPES: InstallJobEventType[] = [ 'install', + 'use', 'progress', 'step-done', 'fail', @@ -60,6 +68,48 @@ const RUNTIME = { version: '0.40.15', port: 11435, pid: 4711, enabled: true, mea const CONNECTION = { endpointId: 'local-ollama', flagWasEnabled: false }; const LOADED = { context: 131072, sizeBytes: 26_300_000_000, sizeVramBytes: 26_300_000_000 }; +/** The model in use as the library lists it, and a second checked model beside it. */ +const ENTRY: LocalModelLibraryEntry = { + id: MODEL.id, + label: MODEL.label, + context: MODEL.context, + digest: 'abc123', + bytes: 23_105_798_956, + cli: CLI, +}; +const OTHER: LocalModelLibraryEntry = { + id: 'qwen3.8:27b-mtp-q4_k_m', + label: 'Qwen3.8 27B', + context: 65536, + digest: 'def456', + bytes: 17_741_872_154, + cli: CLI, +}; + +/** The two as rows of the view, while nothing is known from the runtime. */ +const ENTRY_ROW = { + id: ENTRY.id, + label: ENTRY.label, + context: ENTRY.context, + sizeBytes: 23_105_798_956, + sizeGb: '23.1', + active: true, + verified: true, + status: 'ready', + actions: [], +}; +const OTHER_ROW = { + id: OTHER.id, + label: OTHER.label, + context: OTHER.context, + sizeBytes: 17_741_872_154, + sizeGb: '17.7', + active: false, + verified: true, + status: 'ready', + actions: ['use'], +}; + const JOB: LocalModelStateFile = { schema: 1, state: 'installing', @@ -69,6 +119,8 @@ const JOB: LocalModelStateFile = { cli: CLI, runtime: RUNTIME, progress: { completedBytes: 6_200_000_000, totalBytes: 23_105_798_956 }, + // An earlier install left one checked model: what `use` can go back to. + library: [OTHER], }; /** One state file of each state, as the job leaves it. */ @@ -84,6 +136,7 @@ const SAMPLE: Record = { cli: CLI, runtime: RUNTIME, loaded: LOADED, + library: [OTHER], connection: CONNECTION, }, }; @@ -96,6 +149,11 @@ const EVENT: Record = { cli: { id: 'claude', label: 'Claude Code' }, steps: ['runtime', 'model', 'verify', 'connect'], }, + use: { + type: 'use', + model: { id: OTHER.id, label: OTHER.label, context: OTHER.context, digest: OTHER.digest }, + cli: CLI, + }, progress: { type: 'progress', completedBytes: 7_000_000_000, totalBytes: 23_105_798_956 }, 'step-done': { type: 'step-done' }, fail: { type: 'fail', code: 'no-tool-call', vars: { model: 'Qwen3.6 35B-A3B' }, nextModelId: 'gpt-oss:20b' }, @@ -151,12 +209,17 @@ describe('the tables', () => { cancel: 'paused', restart: 'paused', }, - paused: { resume: 'installing', install: 'installing', remove: 'idle', restart: 'paused' }, - failed: { resume: 'installing', install: 'installing', remove: 'idle', restart: 'failed' }, - installed: { remove: 'idle', restart: 'installed' }, + paused: { resume: 'installing', install: 'installing', use: 'installing', remove: 'idle', restart: 'paused' }, + failed: { resume: 'installing', install: 'installing', use: 'installing', remove: 'idle', restart: 'failed' }, + installed: { install: 'installing', use: 'installing', remove: 'idle', restart: 'installed' }, }); }); + it('a switch is the two steps that load and connect a model, and downloads nothing', () => { + expect(USE_JOB_STEPS).toEqual(['verify', 'connect']); + for (const step of USE_JOB_STEPS) expect(INSTALL_STEP_TABLE[step].progress).toBe(false); + }); + it('every step row names error codes that exist, each with a sentence and a next step', () => { for (const step of LOCAL_MODEL_INSTALL_STEPS) { const row = INSTALL_STEP_TABLE[step]; @@ -221,10 +284,10 @@ describe('reduceInstallJob: every state with every event, from the transition ta } } - it('covers all 40 pairs, 18 of them listed', () => { + it('covers all 45 pairs, 22 of them listed', () => { const listed = STATES.flatMap((state) => Object.keys(INSTALL_TRANSITIONS[state])); - expect(STATES.length * EVENT_TYPES.length).toBe(40); - expect(listed).toHaveLength(18); + expect(STATES.length * EVENT_TYPES.length).toBe(45); + expect(listed).toHaveLength(22); }); }); @@ -246,11 +309,15 @@ describe('the state table agrees with the reducer and the view', () => { const row = INSTALL_STATE_TABLE[state]; const accepts = (type: InstallJobEventType) => INSTALL_TRANSITIONS[state][type] !== undefined; expect(row.actions.includes('install')).toBe(accepts('install')); + expect(row.actions.includes('use')).toBe(accepts('use')); expect(row.actions.includes('cancel')).toBe(accepts('cancel')); expect(row.actions.includes('resume')).toBe(accepts('resume')); - // Remove is refused only while a job runs. From idle it only clears leftovers, so the - // window offers no button for it there. - if (state !== 'idle') expect(row.actions.includes('remove')).toBe(accepts('remove')); + // Remove is refused only while a job runs. From idle it only clears what an earlier + // Remove kept, and the view lists it there only while the store holds something. + expect(row.actions.includes('remove')).toBe(accepts('remove')); + // A model is deleted through the runtime, which a state without a job in flight and with + // a runtime set up can have: never idle (no runtime), never while a job runs. + expect(row.actions.includes('delete-model')).toBe(state !== 'idle' && state !== 'installing'); // The runtime and a session are things of an installed model only. for (const action of ['start', 'stop', 'start-session'] as LocalModelAction[]) { expect(row.actions.includes(action)).toBe(state === 'installed'); @@ -292,6 +359,7 @@ describe('reduceInstallJob: what each event writes', () => { replacedModelId: 'qwen3.6:35b-a3b', cli: { id: 'claude', label: 'Claude Code' }, runtime: RUNTIME, + library: [OTHER], connection: CONNECTION, }); // Gone: the error, the progress, what the runtime had loaded. @@ -421,32 +489,65 @@ describe('reduceInstallJob: what each event writes', () => { }); describe('allowedActions', () => { - it('outside installed it is the state row, whatever is live', () => { - for (const state of ['idle', 'installing', 'paused', 'failed'] as const) { - expect(allowedActions(SAMPLE[state], { ...LIVE, running: true, gaveUp: true, portInUse: true })).toEqual([ - ...INSTALL_STATE_TABLE[state].actions, - ]); - } - expect(allowedActions(SAMPLE.idle, LIVE)).toEqual(['install']); + it('outside installed the runtime, the port and the digest narrow nothing', () => { + const busy = { ...LIVE, running: true, gaveUp: true, portInUse: true }; + expect(allowedActions(SAMPLE.installing, busy)).toEqual(['cancel']); expect(allowedActions(SAMPLE.installing, LIVE)).toEqual(['cancel']); - expect(allowedActions(SAMPLE.paused, LIVE)).toEqual(['resume', 'install', 'remove']); - expect(allowedActions(SAMPLE.failed, LIVE)).toEqual(['resume', 'install', 'remove']); + for (const state of ['paused', 'failed'] as const) { + // `use` because a checked model is there; no delete while nothing is known from the runtime. + expect(allowedActions(SAMPLE[state], busy)).toEqual(['resume', 'install', 'use', 'remove']); + expect(allowedActions(SAMPLE[state], LIVE)).toEqual(['resume', 'install', 'use', 'remove']); + } }); - it('installed and running: a session can be started and the runtime stopped', () => { + it('idle: Remove is offered only while the model store still holds something', () => { + expect(allowedActions(SAMPLE.idle, LIVE)).toEqual(['install']); + expect(allowedActions(SAMPLE.idle, { ...LIVE, storeBytes: 0 })).toEqual(['install']); + expect(allowedActions(SAMPLE.idle, { ...LIVE, storeBytes: 23_105_798_956 })).toEqual(['install', 'remove']); + }); + + it('use and delete-model are listed only while a row of the library offers them', () => { + // A first job: no checked model yet, so nothing to switch to and nothing to delete. + const first: LocalModelStateFile = { ...SAMPLE.paused, library: undefined }; + expect(allowedActions(first, LIVE)).toEqual(['resume', 'install', 'remove']); + // The runtime lists the other model: it can be deleted as well as switched to. + const tags = [{ name: OTHER.id, size: 17_741_872_154, digest: OTHER.digest }]; + expect(allowedActions(SAMPLE.paused, { ...LIVE, running: true, tags })).toEqual([ + 'resume', + 'install', + 'use', + 'delete-model', + 'remove', + ]); + // The rows it was given decide, when it is given them. + expect(allowedActions(SAMPLE.paused, { ...LIVE, running: true, tags }, [])).toEqual([ + 'resume', + 'install', + 'remove', + ]); + }); + + it('installed and running: a session can be started, the runtime stopped, a model added', () => { expect(allowedActions(SAMPLE.installed, { ...LIVE, running: true, digest: 'same' })).toEqual([ 'start-session', 'stop', + 'install', + 'use', 'remove', ]); }); it('installed and stopped: it can be started, and no session is offered', () => { - expect(allowedActions(SAMPLE.installed, LIVE)).toEqual(['start', 'remove']); + expect(allowedActions(SAMPLE.installed, LIVE)).toEqual(['start', 'install', 'use', 'remove']); }); it('installed and running a model that changed: no session', () => { - expect(allowedActions(SAMPLE.installed, { ...LIVE, running: true, digest: 'changed' })).toEqual(['stop', 'remove']); + expect(allowedActions(SAMPLE.installed, { ...LIVE, running: true, digest: 'changed' })).toEqual([ + 'stop', + 'install', + 'use', + 'remove', + ]); }); it('a digest that could not be read does not hide the session button: the launch itself reads it again', () => { @@ -456,8 +557,8 @@ describe('allowedActions', () => { it('never returns the table row itself', () => { const actions = allowedActions(SAMPLE.idle, LIVE); - actions.push('remove'); - expect(INSTALL_STATE_TABLE.idle.actions).toEqual(['install']); + actions.push('cancel'); + expect(INSTALL_STATE_TABLE.idle.actions).toEqual(['install', 'remove']); }); }); @@ -535,10 +636,20 @@ describe('buildInstallView', () => { unpackedGb: '0.6', }, folder: '/Users/me/.codeman/local-model', + library: [], actions: ['install'], }); }); + it('idle with a store an earlier Remove kept: its size, and Remove to free it', () => { + const view = buildInstallView(SAMPLE.idle, { ...LIVE, storeBytes: 23_105_798_956 }); + expect(view.store).toEqual({ bytes: 23_105_798_956, gb: '23.1' }); + expect(view.library).toEqual([]); + expect(view.actions).toEqual(['install', 'remove']); + // A store that was measured as empty is said as that, and offers nothing. + expect(buildInstallView(SAMPLE.idle, { ...LIVE, storeBytes: 0 }).store).toEqual({ bytes: 0, gb: '0.0' }); + }); + it('once the runtime is unpacked an install downloads nothing for it', () => { const view = buildInstallView(SAMPLE.idle, { ...LIVE, runtimeInstalled: true }); expect(view.runtime).toEqual({ @@ -564,6 +675,8 @@ describe('buildInstallView', () => { unpackedGb: '0.6', }, folder: '/Users/me/.codeman/local-model', + // The checked model of an earlier install: listed, with nothing to do while a job runs. + library: [{ ...OTHER_ROW, actions: [] }], actions: ['cancel'], model: { id: 'qwen3.6:35b-a3b', label: 'Qwen3.6 35B-A3B' }, context: 131072, @@ -593,7 +706,9 @@ describe('buildInstallView', () => { completedGb: '6.2', totalGb: '23.1', }); - expect(view.actions).toEqual(['resume', 'install', 'remove']); + expect(view.actions).toEqual(['resume', 'install', 'use', 'remove']); + // The way back from a job that stopped: the model that was checked before. + expect(view.library).toEqual([OTHER_ROW]); }); it('a speed of zero has no time left, and a download without a total has no progress at all', () => { @@ -677,7 +792,8 @@ describe('buildInstallView', () => { developerTools: 'present', runtime: { version: '0.40.15', installed: true, downloadBytes: 0, downloadGb: '0.0', unpackedGb: '0.6' }, folder: '/Users/me/.codeman/local-model', - actions: ['start-session', 'stop', 'remove'], + library: [ENTRY_ROW, OTHER_ROW], + actions: ['start-session', 'stop', 'install', 'use', 'remove'], model: { id: 'qwen3.6:35b-a3b', label: 'Qwen3.6 35B-A3B' }, context: 131072, cli: 'opencode', @@ -692,7 +808,9 @@ describe('buildInstallView', () => { const view = buildInstallView(SAMPLE.installed, { ...LIVE, running: true, digest: 'changed' }); expect(view.state).toBe('installed'); expect(view.error?.code).toBe('model-changed'); - expect(view.actions).toEqual(['stop', 'remove']); + expect(view.actions).toEqual(['stop', 'install', 'use', 'remove']); + // The row of the model in use says the same thing the error does. + expect(view.library[0]).toMatchObject({ id: MODEL.id, active: true, status: 'changed' }); }); it('a model that was not all on the GPU says so', () => { @@ -713,6 +831,317 @@ describe('buildInstallView', () => { }); }); +describe('reduceInstallJob: the library', () => { + it('libraryOf: the list of the file, and for an installed file without one its model', () => { + expect(libraryOf(SAMPLE.idle)).toEqual([]); + expect(libraryOf(SAMPLE.paused)).toEqual([OTHER]); + // A file an earlier build wrote: the model in use is the library. + const old: LocalModelStateFile = { ...SAMPLE.installed, library: undefined }; + expect(libraryOf(old)).toEqual([ENTRY]); + // The model in use is always one of them, first, also when the list does not name it. + expect(libraryOf(SAMPLE.installed)).toEqual([ENTRY, OTHER]); + // Never twice, and the list's own entry wins. + const listed: LocalModelStateFile = { ...SAMPLE.installed, library: [OTHER, { ...ENTRY, context: 65536 }] }; + expect(libraryOf(listed)).toEqual([OTHER, { ...ENTRY, context: 65536 }]); + // A model without a stored digest could never be compared: it is not one of them. + const noDigest: LocalModelStateFile = { ...SAMPLE.installed, library: undefined, model: MODEL }; + expect(libraryOf(noDigest)).toEqual([]); + // A job's model is not in the library before it was checked. + expect(libraryOf({ ...SAMPLE.installing, library: undefined })).toEqual([]); + }); + + it('libraryOf hands out a list of its own', () => { + const list = libraryOf(SAMPLE.paused); + list.pop(); + expect(SAMPLE.paused.library).toEqual([OTHER]); + }); + + it('upsertLibraryEntry replaces the entry with the same id in place, else adds at the end', () => { + const next = { ...OTHER, digest: 'fff', context: 131072 }; + expect(upsertLibraryEntry([ENTRY, OTHER], next)).toEqual([ENTRY, next]); + expect(upsertLibraryEntry([ENTRY], OTHER)).toEqual([ENTRY, OTHER]); + expect(upsertLibraryEntry([], OTHER)).toEqual([OTHER]); + }); + + it('an install from installed adds a model: the model in use stays in the library and is NOT deleted', () => { + const next = reduceInstallJob(SAMPLE.installed, EVENT.install); + expect(next).toEqual({ + schema: 1, + state: 'installing', + step: 'runtime', + steps: ['runtime', 'model', 'verify', 'connect'], + model: { id: 'gpt-oss:20b', label: 'GPT-OSS 20B', context: 65536 }, + cli: { id: 'claude', label: 'Claude Code' }, + runtime: RUNTIME, + // The model that was in use is written into the list: its state member is the new job's now. + library: [ENTRY, OTHER], + connection: CONNECTION, + }); + expect(next).not.toHaveProperty('replacedModelId'); + expect(next).not.toHaveProperty('loaded'); + }); + + it('an install from an installed file of an earlier build keeps its one model too', () => { + const old: LocalModelStateFile = { ...SAMPLE.installed, library: undefined }; + const next = reduceInstallJob(old, EVENT.install); + expect(next.library).toEqual([ENTRY]); + expect(next).not.toHaveProperty('replacedModelId'); + }); + + it('a replaced job deletes its model only when that model was never checked', () => { + // The stopped job's model is a checked one (it failed after its check): it stays. + const checked: LocalModelStateFile = { ...SAMPLE.failed, library: [OTHER, ENTRY] }; + expect(reduceInstallJob(checked, EVENT.install)).not.toHaveProperty('replacedModelId'); + // Not checked: what it left is deleted, as before. + expect(reduceInstallJob(SAMPLE.failed, EVENT.install).replacedModelId).toBe(MODEL.id); + // A leftover that is waiting to be deleted is dropped from the wait once it is a checked model. + const waiting: LocalModelStateFile = { ...SAMPLE.paused, replacedModelId: OTHER.id }; + expect(reduceInstallJob(waiting, { ...EVENT.install, model: MODEL } as InstallJobEvent)).not.toHaveProperty( + 'replacedModelId' + ); + }); + + it('use from installed: the two steps for the checked model, with its stored digest', () => { + expect(reduceInstallJob(SAMPLE.installed, EVENT.use)).toEqual({ + schema: 1, + state: 'installing', + step: 'verify', + steps: ['verify', 'connect'], + model: { id: OTHER.id, label: OTHER.label, context: OTHER.context, digest: OTHER.digest }, + cli: CLI, + runtime: RUNTIME, + library: [ENTRY, OTHER], + connection: CONNECTION, + }); + }); + + it('use from a stopped job replaces it, and deletes what that job left of an unchecked model', () => { + for (const state of ['paused', 'failed'] as const) { + const next = reduceInstallJob(SAMPLE[state], EVENT.use); + expect(next.state).toBe('installing'); + expect(next.step).toBe('verify'); + expect(next.model?.id).toBe(OTHER.id); + expect(next.replacedModelId).toBe(MODEL.id); + expect(next).not.toHaveProperty('error'); + expect(next).not.toHaveProperty('progress'); + expect(next.library).toEqual([OTHER]); + } + }); + + it('refuses a use it cannot apply: a model that is not in the library, a state without a runtime', () => { + const unknown = { ...EVENT.use, model: { id: 'gpt-oss:20b', label: 'GPT-OSS 20B', context: 65536, digest: 'x' } }; + expect(reduceInstallJob(SAMPLE.installed, unknown as InstallJobEvent)).toBe(SAMPLE.installed); + const noRuntime: LocalModelStateFile = { ...SAMPLE.paused, runtime: undefined }; + expect(reduceInstallJob(noRuntime, EVENT.use)).toBe(noRuntime); + }); + + it('every event but remove carries the library', () => { + const job = SAMPLE.installing; + expect(reduceInstallJob(job, EVENT.progress).library).toEqual([OTHER]); + expect(reduceInstallJob(job, EVENT['step-done']).library).toEqual([OTHER]); + expect(reduceInstallJob(job, EVENT.fail).library).toEqual([OTHER]); + expect(reduceInstallJob(job, EVENT.cancel).library).toEqual([OTHER]); + expect(reduceInstallJob(job, EVENT.restart).library).toEqual([OTHER]); + expect(reduceInstallJob(SAMPLE.failed, EVENT.resume).library).toEqual([OTHER]); + const last: LocalModelStateFile = { ...job, step: 'connect', library: [OTHER, ENTRY], connection: CONNECTION }; + expect(reduceInstallJob(last, EVENT['step-done'])).toMatchObject({ state: 'installed', library: [OTHER, ENTRY] }); + expect(reduceInstallJob(SAMPLE.installed, EVENT.remove)).toEqual({ schema: 1, state: 'idle' }); + }); +}); + +describe('buildLibraryRows', () => { + const tagOf = (entry: LocalModelLibraryEntry, extra: Partial<{ size: number; digest: string }> = {}) => ({ + name: entry.id, + size: entry.bytes ?? 0, + digest: entry.digest, + ...extra, + }); + + it('is empty in idle, whatever is live', () => { + expect(buildLibraryRows(SAMPLE.idle, { ...LIVE, running: true, tags: [tagOf(OTHER)] })).toEqual([]); + }); + + it('the runtime stopped: the checked models as they were recorded, a switch, and no delete', () => { + expect(buildLibraryRows(SAMPLE.installed, LIVE)).toEqual([ENTRY_ROW, OTHER_ROW]); + // A listing that is still around from before the stop is not trusted. + expect(buildLibraryRows(SAMPLE.installed, { ...LIVE, running: false, tags: [] })).toEqual([ENTRY_ROW, OTHER_ROW]); + }); + + it('the runtime running: its sizes, and a delete for every model but the one in use', () => { + const rows = buildLibraryRows(SAMPLE.installed, { + ...LIVE, + running: true, + tags: [tagOf(ENTRY, { size: 23_105_800_000 }), tagOf(OTHER)], + }); + expect(rows).toEqual([ + { ...ENTRY_ROW, sizeBytes: 23_105_800_000 }, + { ...OTHER_ROW, actions: ['use', 'delete'] }, + ]); + }); + + it('the model in use comes first, wherever the list has it', () => { + const state: LocalModelStateFile = { ...SAMPLE.installed, library: [OTHER, ENTRY] }; + expect(buildLibraryRows(state, LIVE).map((row) => row.id)).toEqual([ENTRY.id, OTHER.id]); + }); + + it('a checked model whose digest the runtime no longer reports: changed, never switched to, deletable', () => { + const rows = buildLibraryRows(SAMPLE.installed, { + ...LIVE, + running: true, + tags: [tagOf(ENTRY), tagOf(OTHER, { digest: 'somethingelse' })], + }); + expect(rows[1]).toMatchObject({ id: OTHER.id, status: 'changed', verified: true, actions: ['delete'] }); + // The digest is compared without its prefix and its case, like everywhere else. + const same = buildLibraryRows(SAMPLE.installed, { + ...LIVE, + running: true, + tags: [tagOf(ENTRY), tagOf(OTHER, { digest: 'sha256:DEF456' })], + }); + expect(same[1].status).toBe('ready'); + }); + + it('a checked model the runtime no longer lists: missing, with its recorded size, and its entry can be dropped', () => { + const rows = buildLibraryRows(SAMPLE.installed, { ...LIVE, running: true, tags: [tagOf(ENTRY)] }); + expect(rows[1]).toEqual({ ...OTHER_ROW, status: 'missing', actions: ['delete'] }); + }); + + it('what the runtime lists beside the checked models: not checked, deletable, never switched to', () => { + const rows = buildLibraryRows(SAMPLE.installed, { + ...LIVE, + running: true, + labels: { 'mimo-v2.6:9b-q4_k_m': 'MiMo V2.6 9B' }, + tags: [ + tagOf(ENTRY), + tagOf(OTHER), + { name: 'zeta:1b', size: 900_000_000, digest: 'z' }, + { name: 'mimo-v2.6:9b-q4_k_m', size: 6_550_811_033, digest: 'm' }, + ], + }); + expect(rows.slice(2)).toEqual([ + { + id: 'mimo-v2.6:9b-q4_k_m', + // The catalogue knows it, so it is named as the chooser names it. + label: 'MiMo V2.6 9B', + sizeBytes: 6_550_811_033, + sizeGb: '6.6', + active: false, + verified: false, + status: 'unverified', + actions: ['delete'], + }, + { + id: 'zeta:1b', + label: 'zeta:1b', + sizeBytes: 900_000_000, + sizeGb: '0.9', + active: false, + verified: false, + status: 'unverified', + actions: ['delete'], + }, + ]); + }); + + it('a name that is not a plain name:tag is listed with its size and offers nothing', () => { + const rows = buildLibraryRows(SAMPLE.installed, { + ...LIVE, + running: true, + tags: [tagOf(ENTRY), { name: 'hf.co/someone/model:Q4', size: 1_000_000_000, digest: 'h' }], + }); + expect(rows.find((row) => row.id === 'hf.co/someone/model:Q4')).toMatchObject({ + status: 'unverified', + sizeGb: '1.0', + actions: [], + }); + }); + + it('the model of a stopped job: listed once it is on disk, and neither switched to nor deleted', () => { + const rows = buildLibraryRows(SAMPLE.failed, { + ...LIVE, + running: true, + tags: [tagOf(OTHER), { name: MODEL.id, size: 23_105_798_956, digest: 'abc123' }], + }); + expect(rows).toEqual([ + { ...OTHER_ROW, actions: ['use', 'delete'] }, + { + id: MODEL.id, + label: MODEL.label, + sizeBytes: 23_105_798_956, + sizeGb: '23.1', + active: false, + verified: false, + status: 'unverified', + actions: [], + }, + ]); + }); + + it('while a job runs nothing is offered on any row', () => { + const rows = buildLibraryRows(SAMPLE.installing, { ...LIVE, running: true, tags: [tagOf(OTHER)] }); + expect(rows.map((row) => row.actions)).toEqual([[]]); + }); + + it('a row without a known size has neither size member', () => { + const state: LocalModelStateFile = { ...SAMPLE.paused, library: [{ ...OTHER, bytes: undefined }] }; + const [row] = buildLibraryRows(state, LIVE); + expect(row).not.toHaveProperty('sizeBytes'); + expect(row).not.toHaveProperty('sizeGb'); + }); +}); + +describe('markLibraryCandidates', () => { + const candidate = (modelId: string, context: number) => ({ modelId, context }) as Recommendation['alternatives'][0]; + const view = buildInstallView(SAMPLE.installed, { ...LIVE, running: true }); + + it('marks the model in use and a model a switch can take, at the context they were checked with', () => { + const recommendation = { + verdict: 'ok', + pick: candidate(MODEL.id, MODEL.context), + alternatives: [candidate(OTHER.id, OTHER.context), candidate('gpt-oss:20b', 65536)], + } as unknown as Recommendation; + const marked = markLibraryCandidates(recommendation, view); + expect(marked.pick?.library).toBe('active'); + expect(marked.alternatives[0].library).toBe('ready'); + expect(marked.alternatives[1]).not.toHaveProperty('library'); + // The input is not written to. + expect(recommendation.pick).not.toHaveProperty('library'); + }); + + it('a row at another context than the one that was checked is an install like any other', () => { + const recommendation = { + verdict: 'ok', + pick: candidate(MODEL.id, 65536), + alternatives: [candidate(OTHER.id, 131072)], + } as unknown as Recommendation; + expect(markLibraryCandidates(recommendation, view)).toBe(recommendation); + }); + + it('hands back the same object when there is nothing to mark', () => { + const none = { verdict: 'none', alternatives: [] } as unknown as Recommendation; + expect(markLibraryCandidates(none, view)).toBe(none); + const idle = buildInstallView(SAMPLE.idle, LIVE); + const recommendation = { verdict: 'ok', pick: candidate(MODEL.id, MODEL.context), alternatives: [] }; + expect(markLibraryCandidates(recommendation as unknown as Recommendation, idle)).toBe(recommendation); + }); + + it('a checked model that changed is not marked ready', () => { + const changed = buildInstallView(SAMPLE.installed, { + ...LIVE, + running: true, + tags: [ + { name: MODEL.id, size: 1, digest: 'abc123' }, + { name: OTHER.id, size: 1, digest: 'other' }, + ], + }); + const recommendation = { + verdict: 'ok', + pick: candidate(OTHER.id, OTHER.context), + alternatives: [], + } as unknown as Recommendation; + expect(markLibraryCandidates(recommendation, changed).pick).not.toHaveProperty('library'); + }); +}); + describe('formatInstallMessage', () => { it('fills the slots of a sentence', () => { expect(formatInstallMessage({ text: LOCAL_MODEL_INSTALL_LABELS.errPortInUse, vars: { port: '11435' } })).toBe( diff --git a/test/local-model-install-service.test.ts b/test/local-model-install-service.test.ts index e1206d99..e2fc64dc 100644 --- a/test/local-model-install-service.test.ts +++ b/test/local-model-install-service.test.ts @@ -13,7 +13,9 @@ * Cancel in every step; Resume; a job a server restart interrupted comes back paused and * waits for a click; every failure is a state with a code and a next step; the coding agent * install (the stock command, the audit line, the resolver caches forgotten, still missing is - * a failure); the digest that refuses a changed model; the runtime verbs; Remove. + * a failure); the digest that refuses a changed model; the runtime verbs; Remove; and the + * library: a second model beside the first, the switch between checked models, the delete of + * one model, what a stopped job leaves to go back to, and the two cached listings of the view. * * Port: N/A (nothing listens). */ @@ -259,6 +261,10 @@ function setup( running: false, gaveUp: false, pid: 5000, + /** What the runtime lists on disk. Default: the model of the state, as it was pulled. */ + tags: undefined as { name: string; size: number; digest: string }[] | undefined, + /** What the model store takes on disk. */ + storeBytes: 0, }; const calls: string[] = []; @@ -325,14 +331,20 @@ function setup( { name: 'qwen3.6:35b-a3b', size: 26_300_000_000, sizeVram: 26_300_000_000, contextLength: 32768 }, ]), getRuntimeVersion: vi.fn(async () => '0.40.15' as string | undefined), - deleteModel: vi.fn(async () => { + deleteModel: vi.fn(async (_target: unknown, _id: string) => { calls.push('deleteModel'); return true; }), + listTags: vi.fn(async () => { + if (world.tags) return world.tags; + const model = store.get().model; + return model ? [{ name: model.id, size: PULL_BYTES, digest: DIGEST }] : []; + }), removePartialModelBlobs: vi.fn(async () => { calls.push('removePartialModelBlobs'); return 0; }), + measureModelStore: vi.fn(async () => world.storeBytes), checkDeveloperTools: vi.fn(async () => 'missing' as const), stockInstallCommand: vi.fn((id: string) => (id === FACTS[0].cli ? INSTALL_COMMAND : undefined)), tryBeginCliInstall: vi.fn((): (() => void) | null => () => { @@ -470,7 +482,7 @@ describe('a job from the click to installed', () => { port: 11435, loaded: { context: 131072, memoryBytes: 26_300_000_000, memoryGb: '26.3', onGpu: true }, endpointId: 'local-ollama', - actions: ['start-session', 'stop', 'remove'], + actions: ['start-session', 'stop', 'install', 'remove'], folder: '/data/local-model', runtime: { version: '0.40.15', installed: true, downloadBytes: 0 }, }); @@ -699,6 +711,8 @@ describe('one job at a time', () => { const jobRunning = { ok: false, status: 409, conflict: { reason: 'job-running' } }; expect(await h.service.install(REQUEST, ADMIN)).toMatchObject(jobRunning); expect(await h.service.resume({}, ADMIN)).toMatchObject(jobRunning); + expect(await h.service.use({ modelId: 'gpt-oss:20b' }, ADMIN)).toMatchObject(jobRunning); + expect(await h.service.deleteLibraryModel({ modelId: 'gpt-oss:20b' }, ADMIN)).toMatchObject(jobRunning); expect(await h.service.runtime({ action: 'stop' })).toMatchObject(jobRunning); expect(await h.service.remove({}, [])).toMatchObject(jobRunning); expect(h.deps.ensureRuntimeInstalled).toHaveBeenCalledTimes(1); @@ -718,7 +732,7 @@ describe('one job at a time', () => { expect(h.deps.ensureRuntimeInstalled).toHaveBeenCalledTimes(1); }); - it('install while a model is installed is 409 already-installed: remove it first', async () => { + it('an install of the model that is in use, at its context, is 409 already-installed', async () => { const h = setup({ state: INSTALLED }); expect(await h.service.install(REQUEST, ADMIN)).toEqual({ ok: false, @@ -1073,7 +1087,11 @@ describe('boot with a model installed', () => { // The pid of the child that runs now replaces the stored one. expect(h.store.get().runtime?.pid).toBe(5000); const view = await h.service.view(); - expect(view).toMatchObject({ state: 'installed', running: true, actions: ['start-session', 'stop', 'remove'] }); + expect(view).toMatchObject({ + state: 'installed', + running: true, + actions: ['start-session', 'stop', 'install', 'remove'], + }); expect(view).not.toHaveProperty('error'); }); @@ -1107,7 +1125,7 @@ describe('boot with a model installed', () => { await h.service.boot(); expect(h.supervisor.start).not.toHaveBeenCalled(); const view = await h.service.view(); - expect(view).toMatchObject({ state: 'installed', running: false, actions: ['start', 'remove'] }); + expect(view).toMatchObject({ state: 'installed', running: false, actions: ['start', 'install', 'remove'] }); // A stopped runtime is not an error. expect(view).not.toHaveProperty('error'); }); @@ -1124,7 +1142,7 @@ describe('boot with a model installed', () => { message: { text: 'The model on this Mac changed since it was installed. Remove it and install it again.' }, next: 'remove', }); - expect(view.actions).toEqual(['stop', 'remove']); + expect(view.actions).toEqual(['stop', 'install', 'remove']); expect(h.store.get().state).toBe('installed'); expect(h.store.get()).not.toHaveProperty('error'); }); @@ -1140,7 +1158,7 @@ describe('boot with a model installed', () => { message: { text: 'Port {port} is in use by another program.', vars: { port: '11435' } }, next: 'other-port', }); - expect(view.actions).toEqual(['start', 'remove']); + expect(view.actions).toEqual(['start', 'install', 'remove']); }); it('never throws, whatever the runtime does', async () => { @@ -1536,7 +1554,7 @@ describe('launchRefusal: the digest and the runtime decide whether a session sta 'The model on this Mac changed since it was installed. Remove it and install it again.' ); // And the window stops offering a session. - expect((await h.service.view()).actions).toEqual(['stop', 'remove']); + expect((await h.service.view()).actions).toEqual(['stop', 'install', 'remove']); }); it('a digest with the sha256 prefix some listings add is the same digest', async () => { @@ -1602,7 +1620,7 @@ describe('launchRefusal: the digest and the runtime decide whether a session sta it('only the model that was installed and checked may be started on the managed endpoint', async () => { const h = await installed(); expect(await h.service.launchRefusalMessage('local-ollama', 'someone-else:7b')).toBe( - 'Only Qwen3.6 35B-A3B is installed on this Mac. Remove it and install another model first.' + 'Only Qwen3.6 35B-A3B is in use on this Mac. Switch models in the local model window first.' ); }); @@ -1641,7 +1659,7 @@ describe('the runtime verbs', () => { expect(stopped.ok && stopped.view).toMatchObject({ state: 'installed', running: false, - actions: ['start', 'remove'], + actions: ['start', 'install', 'remove'], }); expect(h.supervisor.stop).toHaveBeenCalledTimes(1); expect(h.store.get().runtime?.enabled).toBe(false); @@ -1652,7 +1670,10 @@ describe('the runtime verbs', () => { expect(next.supervisor.start).not.toHaveBeenCalled(); const started = await h.service.runtime({ action: 'start' }); - expect(started.ok && started.view).toMatchObject({ running: true, actions: ['start-session', 'stop', 'remove'] }); + expect(started.ok && started.view).toMatchObject({ + running: true, + actions: ['start-session', 'stop', 'install', 'remove'], + }); expect(h.store.get().runtime?.enabled).toBe(true); }); @@ -1747,10 +1768,13 @@ describe('Remove', () => { unpackedGb: '0.6', }, folder: '/data/local-model', + library: [], + // Measured again after the Remove: the store is empty here. + store: { bytes: 0, gb: '0.0' }, actions: ['install'], }); expect(h.store.get()).toMatchObject({ schema: 1, state: 'idle' }); - for (const key of ['model', 'cli', 'runtime', 'connection', 'loaded']) + for (const key of ['model', 'cli', 'runtime', 'connection', 'loaded', 'library']) expect(h.store.get()).not.toHaveProperty(key); expect(h.deps.audit).toHaveBeenCalledWith({ admin: 'root', @@ -2342,7 +2366,7 @@ describe('an installed model whose runtime does not start', () => { h.world.startResult = { ok: false, code: 'runtime-start-failed', detail: 'spawn ENOENT' }; await h.service.boot(); const view = await h.service.view(); - expect(view).toMatchObject({ state: 'installed', running: false, actions: ['start', 'remove'] }); + expect(view).toMatchObject({ state: 'installed', running: false, actions: ['start', 'install', 'remove'] }); expect(view.error).toEqual({ code: 'runtime-start-failed', message: { text: 'The runtime did not start on this Mac.' }, @@ -2396,7 +2420,11 @@ describe('a later build with another runtime pin', () => { // The stored version stays what runs, so the next start finds it again. expect(h.store.get().runtime?.version).toBe(OLD); const view = await h.service.view(); - expect(view).toMatchObject({ state: 'installed', running: true, actions: ['start-session', 'stop', 'remove'] }); + expect(view).toMatchObject({ + state: 'installed', + running: true, + actions: ['start-session', 'stop', 'install', 'remove'], + }); expect(view.error).toBeUndefined(); // A NEW install would still download the pinned build. expect(view.runtime).toMatchObject({ version: OLLAMA_RUNTIME_PIN.version, installed: false }); @@ -2639,3 +2667,663 @@ describe('Stop and "Use another port" while live sessions use the model', () => expect(h.store.get().runtime?.port).toBe(11435); }); }); + +// ---------- The library ---------- + +const GPT = { id: 'gpt-oss:20b', label: 'GPT-OSS 20B', context: 131072 }; +const GPT_BYTES = 13_793_441_427; +const QWEN_ENTRY = { + id: 'qwen3.6:35b-a3b', + label: 'Qwen3.6 35B-A3B', + context: 131072, + digest: DIGEST, + bytes: PULL_BYTES, + cli: { id: 'opencode', label: 'OpenCode' }, +}; +const GPT_ENTRY = { + id: GPT.id, + label: GPT.label, + context: 65536, + digest: DIGEST, + bytes: GPT_BYTES, + cli: { id: 'opencode', label: 'OpenCode' }, +}; +/** Two checked models, the Qwen one in use. */ +const TWO_MODELS: LocalModelStateFile = { ...INSTALLED, library: [QWEN_ENTRY, GPT_ENTRY] }; +const BOTH_TAGS = [ + { name: QWEN_ENTRY.id, size: PULL_BYTES, digest: DIGEST }, + { name: GPT_ENTRY.id, size: GPT_BYTES, digest: DIGEST }, +]; +const ADD_GPT: LocalModelInstallRequest = { + modelId: GPT.id, + cli: 'opencode', + context: GPT.context, + acknowledgedBytes: GPT_BYTES + RUNTIME_BYTES, +}; + +describe('the first install starts the library', () => { + it('the model that passed its check is the one checked model, with its digest, size and coding agent', async () => { + const h = setup(); + await installAndWait(h.service); + expect(h.store.get().library).toEqual([{ ...QWEN_ENTRY, verifiedAt: new Date(1_000_000).toISOString() }]); + const view = await h.service.view(); + expect(view.library).toEqual([ + { + id: QWEN_ENTRY.id, + label: QWEN_ENTRY.label, + context: 131072, + sizeBytes: PULL_BYTES, + sizeGb: '23.1', + active: true, + verified: true, + status: 'ready', + actions: [], + }, + ]); + }); + + it('the entry is written when the check passes, before the coding agent is installed', async () => { + const h = setup({ + overrides: { + runInstallCommand: vi.fn(async () => ({ code: 1, output: 'no network\n', timedOut: false, aborted: false })), + }, + }); + await installAndWait(h.service); + expect(h.store.get()).toMatchObject({ state: 'failed', step: 'agent', library: [{ id: QWEN_ENTRY.id }] }); + // It is the model of the stopped job: Resume goes on with it, so no switch is offered. + const view = await h.service.view(); + expect(view.library.map((row) => row.actions)).toEqual([[]]); + expect(view.actions).toEqual(['resume', 'install', 'remove']); + }); + + it('a size the runtime does not report falls back to what the pull counted', async () => { + const h = setup(); + h.world.tags = []; + await installAndWait(h.service); + expect(h.store.get().library?.[0].bytes).toBe(PULL_BYTES); + }); +}); + +describe('adding a model to an installed one', () => { + it('downloads, checks and connects it, and keeps the earlier model in the library', async () => { + const h = setup({ state: INSTALLED, runtimeOnDisk: true, agentInstalled: true }); + await h.service.boot(); + h.calls.length = 0; + h.world.tags = BOTH_TAGS; + + const started = await h.service.install(ADD_GPT, ADMIN); + expect(started.ok && started.view.state).toBe('installing'); + await h.service.idle(); + + expect(h.calls).toEqual([ + 'ensureRuntimeInstalled', + 'supervisor.start', + 'supervisor.start', + 'pullModel', + 'supervisor.start', + 'verifyModel', + 'supervisor.start', + 'connectLocalModel', + ]); + // Nothing of the earlier model was deleted: it was checked, and it stays. + expect(h.deps.deleteModel).not.toHaveBeenCalled(); + expect(h.deps.removePartialModelBlobs).not.toHaveBeenCalled(); + // The runtime is started for the new model's context. + expect(h.supervisor.start).toHaveBeenLastCalledWith( + expect.objectContaining({ port: 11435, contextLength: 131072 }) + ); + // The one endpoint record is rewritten for the new model; it stays ours. + expect(h.deps.connectLocalModel).toHaveBeenCalledWith({ + port: 11435, + modelId: GPT.id, + context: GPT.context, + ours: true, + flagWasEnabled: false, + }); + expect(h.store.get()).toMatchObject({ + state: 'installed', + model: { id: GPT.id, context: GPT.context, digest: DIGEST }, + connection: { endpointId: 'local-ollama', flagWasEnabled: false }, + library: [QWEN_ENTRY, { id: GPT.id, context: GPT.context, digest: DIGEST, bytes: GPT_BYTES }], + }); + expect(h.store.get()).not.toHaveProperty('replacedModelId'); + + const view = await h.service.view(); + expect(view.model).toEqual({ id: GPT.id, label: GPT.label }); + expect(view.library.map((row) => [row.id, row.active, row.status, row.actions])).toEqual([ + [GPT.id, true, 'ready', []], + [QWEN_ENTRY.id, false, 'ready', ['use', 'delete']], + ]); + expect(view.actions).toEqual(['start-session', 'stop', 'install', 'use', 'delete-model', 'remove']); + // Only the model in use may be launched. + expect(await h.service.launchRefusalMessage('local-ollama', GPT.id)).toBeUndefined(); + expect(await h.service.launchRefusalMessage('local-ollama', QWEN_ENTRY.id)).toBe( + 'Only GPT-OSS 20B is in use on this Mac. Switch models in the local model window first.' + ); + }); + + it('is refused while live sessions use the model, before anything is asked or started', async () => { + const h = setup({ state: INSTALLED, runtimeOnDisk: true, agentInstalled: true }); + await h.service.boot(); + h.calls.length = 0; + const refused = await h.service.install(ADD_GPT, ADMIN, ['w1-app', 'w2-api']); + expect(refused).toMatchObject({ + ok: false, + status: 409, + conflict: { + reason: 'sessions-open', + sessions: ['w1-app', 'w2-api'], + message: { text: LOCAL_MODEL_INSTALL_LABELS.conflictSessionsOpen, vars: { sessions: 'w1-app, w2-api' } }, + }, + }); + expect(h.calls).toEqual([]); + expect(h.deps.readHardware).not.toHaveBeenCalled(); + expect(h.store.get().state).toBe('installed'); + }); + + it('a first install is not held up by sessions elsewhere: no connection of ours exists yet', async () => { + const h = setup(); + const started = await h.service.install(REQUEST, ADMIN, ['w1-app']); + expect(started.ok).toBe(true); + await h.service.cancel(); + }); + + it('the model in use at ANOTHER context is an install like any other: it is checked again at that context', async () => { + const h = setup({ state: INSTALLED, runtimeOnDisk: true, agentInstalled: true }); + h.deps.recommend.mockReturnValue({ + ...recommendation(true), + pick: candidate('qwen3.6:35b-a3b', 'Qwen3.6 35B-A3B', 65536, PULL_BYTES, true), + }); + await h.service.boot(); + const started = await h.service.install({ ...REQUEST, context: 65536 }, ADMIN); + expect(started.ok).toBe(true); + await h.service.idle(); + expect(h.store.get()).toMatchObject({ + state: 'installed', + model: { id: 'qwen3.6:35b-a3b', context: 65536 }, + library: [{ id: 'qwen3.6:35b-a3b', context: 65536 }], + }); + expect(h.store.get().library).toHaveLength(1); + }); + + it('a job that stops leaves the earlier model to go back to, and no session until then', async () => { + const h = setup({ state: INSTALLED, runtimeOnDisk: true, agentInstalled: true }); + await h.service.boot(); + h.world.tags = BOTH_TAGS; + h.deps.verifyModel.mockResolvedValueOnce({ ok: false, code: 'no-tool-call' } as never); + await h.service.install(ADD_GPT, ADMIN); + await h.service.idle(); + + expect(h.store.get()).toMatchObject({ state: 'failed', step: 'verify', model: { id: GPT.id } }); + // The endpoint record still names the earlier model, and nothing may be started on it. + expect(await h.service.launchRefusal('local-ollama')).toEqual({ + code: 'job-unfinished', + message: { text: LOCAL_MODEL_INSTALL_LABELS.errJobUnfinished }, + next: 'retry', + }); + expect(await h.service.launchRefusalMessage('local-ollama', QWEN_ENTRY.id)).toBe( + 'The model on this Mac is being changed and is not ready. Finish or undo that in the local model window first.' + ); + const view = await h.service.view(); + expect(view.actions).toEqual(['resume', 'install', 'use', 'delete-model', 'remove']); + expect(view.library.map((row) => [row.id, row.status, row.actions])).toEqual([ + [QWEN_ENTRY.id, 'ready', ['use', 'delete']], + // Downloaded and not checked: the model of the stopped job, so nothing is offered on it. + [GPT.id, 'unverified', []], + ]); + + // The way back. The model that never passed its check goes: it is what the job left behind. + h.calls.length = 0; + const back = await h.service.use({ modelId: QWEN_ENTRY.id }, ADMIN); + expect(back.ok).toBe(true); + await h.service.idle(); + expect(h.deps.deleteModel).toHaveBeenCalledWith(expect.anything(), GPT.id, expect.anything()); + expect(h.calls).toContain('removePartialModelBlobs'); + expect(h.store.get()).toMatchObject({ state: 'installed', model: { id: QWEN_ENTRY.id, digest: DIGEST } }); + expect(h.store.get()).not.toHaveProperty('replacedModelId'); + expect(h.store.get()).not.toHaveProperty('error'); + expect(await h.service.launchRefusalMessage('local-ollama', QWEN_ENTRY.id)).toBeUndefined(); + }); +}); + +describe('use: the switch to a checked model', () => { + it('loads and checks it again, connects it, and downloads nothing', async () => { + const h = setup({ state: TWO_MODELS, runtimeOnDisk: true, agentInstalled: true }); + await h.service.boot(); + h.calls.length = 0; + h.world.tags = BOTH_TAGS; + + const started = await h.service.use({ modelId: GPT.id }, ADMIN); + expect(started.ok && started.view).toMatchObject({ + state: 'installing', + step: 'verify', + steps: ['verify', 'connect'], + model: { id: GPT.id, label: GPT.label }, + context: 65536, + }); + await h.service.idle(); + + expect(h.calls).toEqual([ + 'recheckCliInstalled', + 'supervisor.start', + 'verifyModel', + 'supervisor.start', + 'connectLocalModel', + ]); + expect(h.deps.pullModel).not.toHaveBeenCalled(); + expect(h.deps.ensureRuntimeInstalled).not.toHaveBeenCalled(); + expect(h.deps.deleteModel).not.toHaveBeenCalled(); + // The runtime is restarted for the context the model was checked with. + expect(h.supervisor.start).toHaveBeenLastCalledWith(expect.objectContaining({ contextLength: 65536 })); + expect(h.deps.verifyModel).toHaveBeenCalledWith(expect.anything(), GPT.id, 65536, expect.anything()); + expect(h.deps.connectLocalModel).toHaveBeenCalledWith( + expect.objectContaining({ modelId: GPT.id, context: 65536, ours: true }) + ); + expect(h.store.get()).toMatchObject({ + state: 'installed', + model: { id: GPT.id, context: 65536, digest: DIGEST }, + cli: { id: 'opencode', label: 'OpenCode' }, + library: [QWEN_ENTRY, { id: GPT.id, digest: DIGEST }], + }); + expect(h.deps.audit).toHaveBeenCalledWith({ + admin: 'root', + action: 'local_model_use', + target: GPT.id, + ip: '127.0.0.1', + detail: { cli: 'opencode', context: 65536 }, + }); + }); + + it('is refused for a model that is not one of the checked ones, and for the one in use', async () => { + const h = setup({ state: TWO_MODELS, runtimeOnDisk: true, agentInstalled: true }); + await h.service.boot(); + h.calls.length = 0; + expect(await h.service.use({ modelId: 'someone-else:7b' }, ADMIN)).toEqual({ + ok: false, + status: 400, + message: { text: LOCAL_MODEL_INSTALL_LABELS.refusedNotInLibrary }, + }); + expect(await h.service.use({ modelId: QWEN_ENTRY.id }, ADMIN)).toMatchObject({ + ok: false, + status: 409, + conflict: { reason: 'already-installed' }, + }); + expect(h.calls).toEqual([]); + expect(h.store.get().state).toBe('installed'); + }); + + it('is refused while live sessions use the model', async () => { + const h = setup({ state: TWO_MODELS, runtimeOnDisk: true, agentInstalled: true }); + await h.service.boot(); + h.calls.length = 0; + expect(await h.service.use({ modelId: GPT.id }, ADMIN, ['w1-app'])).toMatchObject({ + ok: false, + status: 409, + conflict: { reason: 'sessions-open', sessions: ['w1-app'] }, + }); + expect(h.calls).toEqual([]); + }); + + it('is 409 wrong-state where there is nothing to switch: idle', async () => { + const h = setup(); + expect(await h.service.use({ modelId: GPT.id }, ADMIN)).toMatchObject({ + ok: false, + status: 409, + conflict: { reason: 'wrong-state' }, + }); + }); + + it('a model whose digest is no longer the stored one is not loaded: model-changed, and the way back stays', async () => { + const h = setup({ state: TWO_MODELS, runtimeOnDisk: true, agentInstalled: true }); + await h.service.boot(); + h.world.tags = [BOTH_TAGS[0], { ...BOTH_TAGS[1], digest: 'ffff00000000' }]; + h.deps.readModelDigest.mockImplementation(async (_target: unknown, id: string) => + id === GPT.id ? 'ffff00000000' : DIGEST + ); + h.calls.length = 0; + await h.service.use({ modelId: GPT.id }, ADMIN); + await h.service.idle(); + + expect(h.deps.verifyModel).not.toHaveBeenCalled(); + expect(h.deps.connectLocalModel).not.toHaveBeenCalled(); + const view = await h.service.view(); + expect(view.state).toBe('failed'); + expect(view.error).toMatchObject({ + code: 'model-changed', + detail: 'The runtime reports another digest for the model.', + }); + expect(view.library.map((row) => [row.id, row.status, row.actions])).toEqual([ + [QWEN_ENTRY.id, 'ready', ['use', 'delete']], + [GPT.id, 'changed', []], + ]); + // The changed model stays a library entry until the person deletes it; it is never deleted as a leftover. + await h.service.use({ modelId: QWEN_ENTRY.id }, ADMIN); + await h.service.idle(); + expect(h.deps.deleteModel).not.toHaveBeenCalled(); + expect(h.store.get()).toMatchObject({ state: 'installed', model: { id: QWEN_ENTRY.id } }); + }); + + it('a model the runtime no longer lists is model-changed too, said as that', async () => { + const h = setup({ state: TWO_MODELS, runtimeOnDisk: true, agentInstalled: true }); + await h.service.boot(); + h.deps.readModelDigest.mockImplementation(async (_target: unknown, id: string) => + id === GPT.id ? undefined : DIGEST + ); + await h.service.use({ modelId: GPT.id }, ADMIN); + await h.service.idle(); + expect((await h.service.view()).error).toMatchObject({ + code: 'model-changed', + detail: 'The runtime no longer lists the model.', + }); + }); + + it('takes the coding agent the model was checked with when it is installed, else the one of the state', async () => { + const pi = { id: 'pi', label: 'Pi' }; + const state: LocalModelStateFile = { ...TWO_MODELS, library: [QWEN_ENTRY, { ...GPT_ENTRY, cli: pi }] }; + const withPi = setup({ state, runtimeOnDisk: true }); + withPi.deps.recheckCliInstalled.mockImplementation(async () => true); + await withPi.service.boot(); + await withPi.service.use({ modelId: GPT.id }, ADMIN); + await withPi.service.idle(); + expect(withPi.store.get().cli).toEqual(pi); + + const withoutPi = setup({ state, runtimeOnDisk: true }); + withoutPi.deps.recheckCliInstalled.mockImplementation((async (id: string) => id === 'opencode') as never); + await withoutPi.service.boot(); + await withoutPi.service.use({ modelId: GPT.id }, ADMIN); + await withoutPi.service.idle(); + expect(withoutPi.store.get().cli).toEqual({ id: 'opencode', label: 'OpenCode' }); + }); + + it('with no coding agent of the two installed it is refused, in one sentence, and nothing starts', async () => { + const h = setup({ state: TWO_MODELS, runtimeOnDisk: true, agentInstalled: false }); + await h.service.boot(); + expect(await h.service.use({ modelId: GPT.id }, ADMIN)).toEqual({ + ok: false, + status: 400, + message: { text: LOCAL_MODEL_INSTALL_LABELS.refusedAgentMissing, vars: { cli: 'OpenCode' } }, + }); + expect(h.store.get().state).toBe('installed'); + }); + + it('Cancel pauses a switch like any job, and Resume goes on with it', async () => { + const h = setup({ + state: TWO_MODELS, + runtimeOnDisk: true, + agentInstalled: true, + overrides: { + verifyModel: vi + .fn() + .mockImplementationOnce(async (_t: unknown, _id: string, _c: number, signal?: AbortSignal) => { + await untilAborted(signal); + return { ok: false as const, code: 'cancelled' as const }; + }) + .mockResolvedValue({ + ok: true as const, + loaded: { context: 65536, sizeBytes: 15_000_000_000, sizeVramBytes: 15_000_000_000 }, + }), + }, + }); + await h.service.boot(); + await h.service.use({ modelId: GPT.id }, ADMIN); + await vi.waitFor(() => expect(h.deps.verifyModel).toHaveBeenCalled()); + const paused = await h.service.cancel(); + expect(paused.ok && paused.view).toMatchObject({ state: 'paused', step: 'verify', steps: ['verify', 'connect'] }); + await h.service.resume({}, ADMIN); + await h.service.idle(); + expect(h.store.get()).toMatchObject({ state: 'installed', model: { id: GPT.id } }); + }); +}); + +describe('deleteLibraryModel: one model out of the store', () => { + async function twoModelsRunning() { + const h = setup({ state: TWO_MODELS, runtimeOnDisk: true, agentInstalled: true }); + await h.service.boot(); + h.world.tags = [...BOTH_TAGS]; + h.deps.deleteModel.mockImplementation(async (_target: unknown, id: string) => { + h.calls.push('deleteModel'); + h.world.tags = (h.world.tags ?? []).filter((tag) => tag.name !== id); + return true; + }); + h.calls.length = 0; + return h; + } + + it('deletes it through the runtime, drops its entry and writes the audit line', async () => { + const h = await twoModelsRunning(); + const result = await h.service.deleteLibraryModel({ modelId: GPT.id }, ADMIN); + expect(h.deps.deleteModel).toHaveBeenCalledTimes(1); + expect(h.deps.deleteModel).toHaveBeenCalledWith({ baseUrl: 'http://127.0.0.1:11435' }, GPT.id, expect.anything()); + expect(h.store.get().library).toEqual([QWEN_ENTRY]); + expect(h.store.get().state).toBe('installed'); + // The answer is the view after the delete: the runtime was asked again. + expect(result.ok && result.view.library.map((row) => row.id)).toEqual([QWEN_ENTRY.id]); + expect(h.deps.audit).toHaveBeenCalledWith({ + admin: 'root', + action: 'local_model_delete', + target: GPT.id, + ip: '127.0.0.1', + detail: { verified: true, bytes: GPT_BYTES }, + }); + // Nothing else of the feature was touched. + expect(h.calls).toEqual(['deleteModel']); + }); + + it('refuses the model in use: switch first, or remove', async () => { + const h = await twoModelsRunning(); + expect(await h.service.deleteLibraryModel({ modelId: QWEN_ENTRY.id }, ADMIN)).toEqual({ + ok: false, + status: 409, + conflict: { + reason: 'model-active', + message: { text: LOCAL_MODEL_INSTALL_LABELS.conflictModelActive, vars: { model: 'Qwen3.6 35B-A3B' } }, + }, + }); + expect(h.deps.deleteModel).not.toHaveBeenCalled(); + }); + + it('refuses while the runtime is down or does not answer: only the runtime deletes a model', async () => { + const stopped = setup({ state: TWO_MODELS }); + expect(await stopped.service.deleteLibraryModel({ modelId: GPT.id }, ADMIN)).toMatchObject({ + ok: false, + status: 409, + conflict: { reason: 'runtime-not-running', message: { text: LOCAL_MODEL_INSTALL_LABELS.errRuntimeNotRunning } }, + }); + const silent = await twoModelsRunning(); + silent.deps.getRuntimeVersion.mockResolvedValue(undefined); + expect(await silent.service.deleteLibraryModel({ modelId: GPT.id }, ADMIN)).toMatchObject({ + ok: false, + status: 409, + conflict: { reason: 'runtime-not-running' }, + }); + expect(silent.deps.deleteModel).not.toHaveBeenCalled(); + expect(silent.store.get().library).toHaveLength(2); + }); + + it('refuses a name that is neither a checked model nor one the runtime lists, and anything that is not name:tag', async () => { + const h = await twoModelsRunning(); + const refused = { ok: false, status: 400, message: { text: LOCAL_MODEL_INSTALL_LABELS.refusedNotOnThisMac } }; + expect(await h.service.deleteLibraryModel({ modelId: 'someone-else:7b' }, ADMIN)).toEqual(refused); + for (const modelId of ['../../etc/passwd', '/Users/me/models', 'hf.co/someone/model:Q4', 'NoTag', '']) { + expect(await h.service.deleteLibraryModel({ modelId }, ADMIN)).toEqual(refused); + } + expect(h.deps.deleteModel).not.toHaveBeenCalled(); + }); + + it('is 409 wrong-state in idle: there is no runtime to ask', async () => { + const h = setup(); + expect(await h.service.deleteLibraryModel({ modelId: GPT.id }, ADMIN)).toMatchObject({ + ok: false, + status: 409, + conflict: { reason: 'wrong-state' }, + }); + }); + + it('a runtime that does not delete it: said as that, and the entry stays', async () => { + const h = await twoModelsRunning(); + h.deps.deleteModel.mockResolvedValue(false); + expect(await h.service.deleteLibraryModel({ modelId: GPT.id }, ADMIN)).toEqual({ + ok: false, + status: 500, + message: { text: LOCAL_MODEL_INSTALL_LABELS.deleteFailed, vars: { model: 'GPT-OSS 20B' } }, + }); + expect(h.store.get().library).toEqual([QWEN_ENTRY, GPT_ENTRY]); + expect(h.deps.audit).not.toHaveBeenCalled(); + }); + + it('a model the runtime lists and Codeman never checked can be deleted too', async () => { + const h = await twoModelsRunning(); + h.world.tags = [...BOTH_TAGS, { name: 'leftover:9b', size: 6_000_000_000, digest: 'aa' }]; + const before = await h.service.view(); + expect(before.library.find((row) => row.id === 'leftover:9b')).toMatchObject({ + status: 'unverified', + sizeGb: '6.0', + actions: ['delete'], + }); + const result = await h.service.deleteLibraryModel({ modelId: 'leftover:9b' }, ADMIN); + expect(result.ok && result.view.library.map((row) => row.id)).toEqual([QWEN_ENTRY.id, GPT.id]); + expect(h.store.get().library).toEqual([QWEN_ENTRY, GPT_ENTRY]); + expect(h.deps.audit).toHaveBeenCalledWith( + expect.objectContaining({ action: 'local_model_delete', detail: { verified: false, bytes: 6_000_000_000 } }) + ); + }); + + it('a checked model the runtime no longer lists: its entry is dropped once the runtime says it is gone', async () => { + const h = await twoModelsRunning(); + h.world.tags = [BOTH_TAGS[0]]; + const result = await h.service.deleteLibraryModel({ modelId: GPT.id }, ADMIN); + expect(result.ok).toBe(true); + // Asked of the runtime all the same: its "not found" is what says the model is gone. + expect(h.deps.deleteModel).toHaveBeenCalledWith(expect.anything(), GPT.id, expect.anything()); + expect(h.store.get().library).toEqual([QWEN_ENTRY]); + }); + + it('works from a stopped job too, for any model but the one of that job', async () => { + const state: LocalModelStateFile = { + ...jobAt('verify', 'paused'), + model: { ...GPT }, + library: [QWEN_ENTRY], + connection: { endpointId: 'local-ollama', flagWasEnabled: false }, + }; + const h = setup({ state, runtimeOnDisk: true }); + h.world.running = true; + h.world.tags = BOTH_TAGS; + expect(await h.service.deleteLibraryModel({ modelId: GPT.id }, ADMIN)).toMatchObject({ + ok: false, + conflict: { reason: 'model-active' }, + }); + const result = await h.service.deleteLibraryModel({ modelId: QWEN_ENTRY.id }, ADMIN); + expect(result.ok).toBe(true); + expect(h.store.get().library).toEqual([]); + expect(h.store.get().state).toBe('paused'); + }); +}); + +describe('the model store in idle: what an earlier Remove kept', () => { + it('shows what it takes, offers Remove, and Remove with the models frees it', async () => { + const h = setup(); + h.world.storeBytes = PULL_BYTES; + const view = await h.service.view(); + expect(view).toMatchObject({ + state: 'idle', + library: [], + store: { bytes: PULL_BYTES, gb: '23.1' }, + actions: ['install', 'remove'], + }); + + h.deps.removeLocalModelFiles.mockImplementation(async () => { + h.calls.push('removeLocalModelFiles'); + h.world.storeBytes = 0; + }); + const removed = await h.service.remove({ removeModel: true }, [], ADMIN); + expect(h.deps.removeLocalModelFiles).toHaveBeenCalledWith({ models: true, paths: PATHS }); + expect(removed.ok && removed.view).toMatchObject({ + state: 'idle', + store: { bytes: 0, gb: '0.0' }, + actions: ['install'], + }); + }); + + it('Remove that keeps the models leaves them there: the next view says how much', async () => { + const h = setup({ state: TWO_MODELS, runtimeOnDisk: true }); + h.world.storeBytes = PULL_BYTES + GPT_BYTES; + const removed = await h.service.remove({}, [], ADMIN); + expect(removed.ok && removed.view).toMatchObject({ + state: 'idle', + library: [], + store: { bytes: PULL_BYTES + GPT_BYTES, gb: '36.9' }, + actions: ['install', 'remove'], + }); + expect(h.store.get()).not.toHaveProperty('library'); + }); +}); + +describe('the view does not ask the runtime or the disk on every poll', () => { + it('reads the list and the store once, then again only when they are stale', async () => { + const h = setup({ state: TWO_MODELS, runtimeOnDisk: true }); + await h.service.boot(); + h.world.tags = BOTH_TAGS; + h.deps.listTags.mockClear(); + for (let i = 0; i < 5; i++) await h.service.view(); + expect(h.deps.listTags).toHaveBeenCalledTimes(1); + expect(h.deps.measureModelStore).toHaveBeenCalledTimes(1); + + // Five seconds on: the list is read again, in the background. The view does not wait for + // a runtime that is slow to answer: it is built from the list it has. + h.world.clock += 5_000; + let answer: (tags: typeof BOTH_TAGS) => void = () => {}; + h.deps.listTags.mockImplementationOnce(() => new Promise((resolve) => (answer = resolve))); + const stale = await h.service.view(); + expect(stale.library.map((row) => row.status)).toEqual(['ready', 'ready']); + await vi.waitFor(() => expect(h.deps.listTags).toHaveBeenCalledTimes(2)); + // A second poll while that read is out starts no second one. + await h.service.view(); + expect(h.deps.listTags).toHaveBeenCalledTimes(2); + answer([BOTH_TAGS[0]]); + await vi.waitFor(async () => + expect((await h.service.view()).library.map((row) => row.status)).toEqual(['ready', 'missing']) + ); + expect(h.deps.measureModelStore).toHaveBeenCalledTimes(1); + + // Thirty seconds on: the store is measured again. + h.world.clock += 30_000; + await h.service.view(); + await vi.waitFor(() => expect(h.deps.measureModelStore).toHaveBeenCalledTimes(2)); + }); + + it('a runtime that does not answer keeps the last list: no model reads as missing for a moment', async () => { + const h = setup({ state: TWO_MODELS, runtimeOnDisk: true }); + await h.service.boot(); + h.world.tags = BOTH_TAGS; + await h.service.view(); + h.deps.getRuntimeVersion.mockResolvedValue(undefined); + h.deps.listTags.mockClear(); + h.world.clock += 5_000; + await h.service.view(); + await new Promise((resolve) => setTimeout(resolve, 20)); + expect(h.deps.listTags).not.toHaveBeenCalled(); + expect((await h.service.view()).library.map((row) => row.status)).toEqual(['ready', 'ready']); + }); + + it('a stopped runtime is not asked at all, and offers no delete', async () => { + const h = setup({ state: { ...TWO_MODELS, runtime: { ...INSTALLED.runtime!, enabled: false } } }); + await h.service.boot(); + const view = await h.service.view(); + expect(h.deps.listTags).not.toHaveBeenCalled(); + expect(view.library.map((row) => [row.id, row.sizeGb, row.actions])).toEqual([ + [QWEN_ENTRY.id, '23.1', []], + [GPT.id, '13.8', ['use']], + ]); + }); + + it('a listing or a measurement that fails is not an error of the view', async () => { + const h = setup({ state: TWO_MODELS, runtimeOnDisk: true }); + await h.service.boot(); + h.deps.listTags.mockRejectedValue(new Error('socket hang up')); + h.deps.measureModelStore.mockRejectedValue(new Error('EIO')); + const view = await h.service.view(); + expect(view.state).toBe('installed'); + expect(view).not.toHaveProperty('store'); + expect(view.library.map((row) => row.id)).toEqual([QWEN_ENTRY.id, GPT.id]); + }); +}); diff --git a/test/local-model-runtime.test.ts b/test/local-model-runtime.test.ts index 46c68908..d5925475 100644 --- a/test/local-model-runtime.test.ts +++ b/test/local-model-runtime.test.ts @@ -37,6 +37,7 @@ import { OLLAMA_RUNTIME_PIN, parseInferenceComputeTotal, removeLocalModelFiles, + measureModelStore, removePartialModelBlobs, RUNTIME_CTX_CHECKPOINTS, RUNTIME_DOWNLOAD_RETRIES, @@ -1103,3 +1104,56 @@ describe('removePartialModelBlobs', () => { expect(existsSync(join(outside, 'sha256-eee-partial'))).toBe(true); }); }); + +describe('measureModelStore', () => { + const blob = (name: string): string => join(paths.modelsDir, 'blobs', name); + + it('is the sizes of the files in the blob folder, a download that was interrupted included', async () => { + await mkdir(join(paths.modelsDir, 'blobs'), { recursive: true }); + await mkdir(join(paths.modelsDir, 'manifests', 'registry.ollama.ai'), { recursive: true }); + await writeFile(blob('sha256-aaa'), 'x'.repeat(1000)); + await writeFile(blob('sha256-bbb'), 'y'.repeat(250)); + await writeFile(blob('sha256-ccc-partial'), 'z'.repeat(40)); + // The manifests are a few kilobytes beside gigabytes of layers: left out. + await writeFile(join(paths.modelsDir, 'manifests', 'registry.ollama.ai', 'latest'), '{"layers":[]}'); + expect(await measureModelStore(paths)).toBe(1290); + }); + + it('is 0 without a model store, without a blob folder and for an empty one, and never throws', async () => { + expect(await measureModelStore(paths)).toBe(0); + await mkdir(paths.modelsDir, { recursive: true }); + expect(await measureModelStore(paths)).toBe(0); + await mkdir(join(paths.modelsDir, 'blobs'), { recursive: true }); + expect(await measureModelStore(paths)).toBe(0); + }); + + it('reads nothing and changes nothing: the store is as it was afterwards', async () => { + await mkdir(join(paths.modelsDir, 'blobs'), { recursive: true }); + await writeFile(blob('sha256-aaa'), 'weights'); + await writeFile(blob('sha256-bbb-partial'), 'half'); + await measureModelStore(paths); + expect(await readFile(blob('sha256-aaa'), 'utf8')).toBe('weights'); + expect(await readFile(blob('sha256-bbb-partial'), 'utf8')).toBe('half'); + }); + + it('counts only regular files directly in the blob folder, and follows no link', async () => { + const outside = await outsideDir(); + await writeFile(join(outside, 'huge'), 'h'.repeat(5000)); + await mkdir(join(paths.modelsDir, 'blobs', 'a-folder'), { recursive: true }); + await writeFile(join(paths.modelsDir, 'blobs', 'a-folder', 'inside'), 'i'.repeat(700)); + await symlink(join(outside, 'huge'), blob('sha256-link')); + await writeFile(blob('sha256-aaa'), 'x'.repeat(10)); + // The folder's file and the link's target are somebody else's: not counted. + expect(await measureModelStore(paths)).toBe(10); + }); + + it('a blob folder, a model store or a root that is a symlink counts as empty', async () => { + const outside = await outsideDir(); + await writeFile(join(outside, 'sha256-eee'), 'e'.repeat(900)); + await mkdir(paths.modelsDir, { recursive: true }); + await symlink(outside, join(paths.modelsDir, 'blobs')); + expect(await measureModelStore(paths)).toBe(0); + // A path that is not inside the local model folder is refused before anything is read. + expect(await measureModelStore({ ...paths, modelsDir: outside })).toBe(0); + }); +}); diff --git a/test/local-model-state-store.test.ts b/test/local-model-state-store.test.ts index f6137336..f51c8bfc 100644 --- a/test/local-model-state-store.test.ts +++ b/test/local-model-state-store.test.ts @@ -196,6 +196,89 @@ describe('parseLocalModelState', () => { }); }); +describe('parseLocalModelState: the library', () => { + const QWEN = { + id: 'qwen3.6:35b-a3b', + label: 'Qwen3.6 35B-A3B', + context: 131072, + digest: '0ce5ff81f9ffdf89dd8192ca7b5d34cefd8996a875b3aaaaafaf5c4813569eba', + bytes: 23_105_798_956, + cli: { id: 'opencode', label: 'OpenCode' }, + verifiedAt: '2026-11-10T09:00:00.000Z', + }; + const MIMO = { id: 'mimo-v2.6:9b-q4_k_m', label: 'MiMo V2.6 9B', context: 65536, digest: 'abc123' }; + const read = (state: unknown) => parseLocalModelState(JSON.stringify(state)); + + it('reads back the checked models of an installed state and of a job, in their order', () => { + expect(read({ ...INSTALLED, library: [QWEN, MIMO] })).toEqual({ ...INSTALLED, library: [QWEN, MIMO] }); + expect(read({ ...PAUSED, library: [MIMO] })).toEqual({ ...PAUSED, library: [MIMO] }); + expect(read({ ...FAILED, library: [MIMO, QWEN] }).library).toEqual([MIMO, QWEN]); + }); + + it('a file an earlier build wrote has no list, and reads back without one', () => { + expect(read(INSTALLED)).toEqual(INSTALLED); + expect(read(INSTALLED)).not.toHaveProperty('library'); + expect(read(PAUSED)).not.toHaveProperty('library'); + }); + + it('an empty list stays an empty list: every checked model was deleted', () => { + expect(read({ ...PAUSED, library: [] }).library).toEqual([]); + }); + + it('a list that is not a list is dropped, the state is kept', () => { + for (const library of ['qwen', 7, { 0: QWEN }, null, true]) { + const state = read({ ...INSTALLED, library }); + expect(state.state).toBe('installed'); + expect(state).not.toHaveProperty('library'); + } + }); + + it('drops an entry that could never be switched to: without its id, label, context or digest', () => { + const library = [ + { ...QWEN, id: '' }, + { ...QWEN, label: 7 }, + { ...QWEN, context: 0 }, + { ...QWEN, context: '131072' }, + { ...QWEN, digest: undefined }, + 'qwen3.6:35b-a3b', + null, + ['qwen3.6:35b-a3b'], + MIMO, + ]; + expect(read({ ...INSTALLED, library }).library).toEqual([MIMO]); + }); + + it('keeps one entry per model: the first', () => { + const library = [QWEN, { ...QWEN, context: 65536 }, MIMO]; + expect(read({ ...INSTALLED, library }).library).toEqual([QWEN, MIMO]); + }); + + it('drops what it does not know inside an entry, and a member of the wrong type: an entry holds no path', () => { + const library = [ + { + ...QWEN, + path: '/Users/me/.codeman/local-model/models', + blobs: ['/etc/passwd'], + bytes: -5, + cli: { id: 'opencode' }, + verifiedAt: 7, + }, + ]; + const [entry] = read({ ...INSTALLED, library }).library ?? []; + expect(entry).toEqual({ id: QWEN.id, label: QWEN.label, context: QWEN.context, digest: QWEN.digest }); + expect(JSON.stringify(read({ ...INSTALLED, library }))).not.toContain('/'); + }); + + it('reads at most 64 entries of a list, however long it is', () => { + const library = Array.from({ length: 500 }, (_unused, i) => ({ ...MIMO, id: `model-${i}:9b` })); + expect(read({ ...INSTALLED, library }).library).toHaveLength(64); + }); + + it('an idle file has no list, whatever it says', () => { + expect(read({ schema: 1, state: 'idle', library: [QWEN] })).toEqual(IDLE_LOCAL_MODEL_STATE); + }); +}); + describe('readLocalModelState', () => { it('is idle when the file is missing, and never throws', async () => { expect(existsSync(FILE())).toBe(false); diff --git a/test/local-model-ui.browser.test.ts b/test/local-model-ui.browser.test.ts index d4def082..01656323 100644 --- a/test/local-model-ui.browser.test.ts +++ b/test/local-model-ui.browser.test.ts @@ -11,7 +11,11 @@ * the fill follows the selection; * - the selected row carries the feature's colour on its reading edge; * - the welcome button is really gone while it is `hidden`, and the window paints above App - * Settings. + * Settings; + * - the models on this Mac: the sizes on disk end on one edge under their caption, a row's + * buttons end on the list's edge, the sizes do not move when a row's Delete question opens, + * a long list scrolls from its top (it is never cut off above the frame), and under 560px a + * row is two lines with nothing running off the side. * * The REAL index.html is served with its scripts taken out and the two shipping stylesheets * inlined (mobile.css under the media query its `` carries); the real module runs on a @@ -124,10 +128,54 @@ const STATUS = { developerTools: 'present', runtime: { version: '0.40.15', installed: false, downloadBytes: RUNTIME, downloadGb: '0.2', unpackedGb: '0.6' }, folder: '/Users/sam/.codeman/local-model', + library: [], actions: ['install'], }, }; +const libraryRow = (id: string, label: string, sizeGb: string, over: object = {}) => ({ + id, + label, + context: 131072, + sizeBytes: Number(sizeGb) * 1e9, + sizeGb, + active: false, + verified: true, + status: 'ready', + actions: ['use', 'delete'], + ...over, +}); + +/** An installed model with two more models beside it: one checked, one the runtime lists and Codeman never checked. */ +const INSTALLED = { + ...STATUS, + install: { + ...STATUS.install, + state: 'installed', + running: true, + runtime: { version: '0.40.15', installed: true, downloadBytes: 0, downloadGb: '0.0', unpackedGb: '0.6' }, + model: { id: 'qwen3.6:35b-a3b', label: 'Qwen3.6 35B-A3B' }, + cli: 'opencode', + cliLabel: 'OpenCode', + context: 131072, + port: 11435, + endpointId: 'local-ollama', + loaded: { context: 131072, memoryBytes: 26300000000, memoryGb: '26.3', onGpu: true }, + library: [ + libraryRow('qwen3.6:35b-a3b', 'Qwen3.6 35B-A3B', '23.1', { active: true, actions: [] }), + libraryRow('qwen3.8:27b-mtp-q4_k_m', 'Qwen3.8 27B', '17.7'), + libraryRow('mimo-v2.6:9b-q4_k_m', 'MiMo V2.6 9B', '6.6', { + context: undefined, + verified: false, + status: 'unverified', + actions: ['delete'], + }), + ], + store: { bytes: 47400000000, gb: '47.4' }, + actions: ['start-session', 'stop', 'install', 'use', 'delete-model', 'remove'], + }, +}; + type Box = { left: number; right: number; top: number; bottom: number; width: number; height: number }; /** What the page holds once the module ran on the stand-in class. */ @@ -160,7 +208,7 @@ describe('the local model window (real Chromium)', () => { }); /** The real page at a width, the module loaded, the answer in, the window closed. */ - async function load(width: number, height = 900) { + async function load(width: number, height = 900, answer: object = STATUS) { p = await browser.newPage({ viewport: { width, height }, deviceScaleFactor: 1 }); // No motion: the bar is at its width as soon as it is painted, so nothing here waits on a clock. await p.emulateMedia({ reducedMotion: 'reduce' }); @@ -178,7 +226,7 @@ describe('the local model window (real Chromium)', () => { w.app = new w.CodemanApp(); w.app._api = async () => ({ ok: true, status: 200, json: async () => ({ success: true, data: status }) }); await w.app.loadLocalModel(); - }, STATUS); + }, answer); } /** Two animation frames: whatever was just written is laid out and painted. */ @@ -343,6 +391,125 @@ describe('the local model window (real Chromium)', () => { expect(overflow).toBeLessThanOrEqual(0); }); + it('the models on this Mac: sizes on one edge, a row one line, its buttons on the list edge', async () => { + await load(1440, 900, INSTALLED); + await open(); + const rows = await boxes('.lm-lib-row'); + expect(rows).toHaveLength(3); + const names = await boxes('.lm-lib-name'); + const tags = await boxes('.lm-lib-tag'); + const sizes = await boxes('.lm-lib-size'); + const [caption] = await boxes('.lm-lib-caption-size'); + expect(same(sizes.map((box) => box.right))).toBe(true); + expect(same([caption.right, sizes[0].right])).toBe(true); + expect(same(names.map((box) => box.left))).toBe(true); + expect(same(tags.map((box) => box.left))).toBe(true); + // One line a row: the name, the tag, the size and the buttons share its middle. + const middle = (box: Box) => (box.top + box.bottom) / 2; + const actions = await boxes('.lm-lib-row .lm-lib-actions'); + for (let i = 0; i < rows.length; i++) { + expect(Math.abs(middle(names[i]) - middle(sizes[i]))).toBeLessThan(3); + expect(Math.abs(middle(tags[i]) - middle(sizes[i]))).toBeLessThan(3); + expect(names[i].right).toBeLessThanOrEqual(tags[i].left + 0.6); + expect(sizes[i].right).toBeLessThanOrEqual(actions[i].left + 0.6); + } + // The last button of a row ends where every line of the window ends: on "Add a model"'s edge. + const rowButtons = await boxes('.lm-lib-row .lm-lib-actions button:last-child'); + const [add] = await boxes('.lm-lib-foot button'); + expect(same([...rowButtons.map((box) => box.right), add.right])).toBe(true); + // The model in use carries the feature's colour on its reading edge; the others do not. + const paint = await p.evaluate(() => { + const probe = document.body.appendChild(document.createElement('i')); + probe.style.color = 'var(--lm-brand)'; + const brand = getComputedStyle(probe).color; + probe.remove(); + const edge = (sel: string) => getComputedStyle(document.querySelector(sel)!).borderLeftColor; + return { brand, on: edge('.lm-lib-row-on'), off: edge('.lm-lib-row:not(.lm-lib-row-on)') }; + }); + expect(paint.on).toBe(paint.brand); + expect(paint.off).not.toBe(paint.brand); + // The screen starts at the top of the frame, right under the header. + const [body] = await boxes('#localModelWindowBody'); + const [title] = await boxes('.lm-title'); + expect(title.top - body.top).toBeLessThan(40); + }); + + it('the Delete question opens under its row without moving the sizes', async () => { + await load(1440, 900, INSTALLED); + await open(); + const before = await boxes('.lm-lib-size'); + await p.click('.lm-lib-row:nth-of-type(3) .lm-lib-actions button:last-child'); + await painted(); + const [ask] = await boxes('.lm-lib-ask'); + const rows = await boxes('.lm-lib-row'); + const after = await boxes('.lm-lib-size'); + // Sideways nothing moved; the rows after the question moved down by it. + expect(after.map((box) => Math.round(box.right))).toEqual(before.map((box) => Math.round(box.right))); + expect(ask.top).toBeGreaterThanOrEqual(rows[1].bottom - 1); + expect(rows[2].top).toBeGreaterThanOrEqual(ask.bottom - 1); + // The row's own buttons are unseen while it is asked about, and the red button is the question's. + const seen = await p.evaluate(() => ({ + away: getComputedStyle(document.querySelector('.lm-lib-actions-away')!).visibility, + red: [...document.querySelectorAll('.local-model-window .wt-btn-danger')].map((el) => el.textContent), + focus: document.activeElement?.textContent, + })); + expect(seen).toEqual({ away: 'hidden', red: ['Delete'], focus: 'Cancel' }); + }); + + it('a long list of models scrolls from its top: the first lines are never cut off above the frame', async () => { + const many = Array.from({ length: 14 }, (_unused, i) => libraryRow(`model-${i}:9b`, `Model ${i}`, '6.6')); + const answer = { + ...INSTALLED, + install: { ...INSTALLED.install, library: [...INSTALLED.install.library, ...many] }, + }; + for (const [width, height] of [ + [1440, 900], + [390, 844], + ]) { + await load(width, height, answer); + await open(); + const scroll = await p.evaluate(() => { + const body = document.getElementById('localModelWindowBody')!; + const title = body.querySelector('.lm-title')!.getBoundingClientRect(); + const box = body.getBoundingClientRect(); + return { + overflows: body.scrollHeight > body.clientHeight, + top: body.scrollTop, + titleInside: title.top >= box.top - 0.5, + sideways: body.scrollWidth - body.clientWidth, + }; + }); + expect(scroll).toEqual({ overflows: true, top: 0, titleInside: true, sideways: 0 }); + // The buttons of the screen stay in the frame's foot, under the part that scrolls. + const [foot] = await boxes('#localModelWindowFoot'); + const [win] = await boxes('.local-model-window'); + expect(foot.bottom).toBeLessThanOrEqual(win.bottom + 0.6); + await p.close(); + } + }); + + it('the models on this Mac under 560px: two lines a row, nothing off the side', async () => { + await load(390, 844, INSTALLED); + await open(); + const names = await boxes('.lm-lib-name'); + const tags = await boxes('.lm-lib-tag'); + const sizes = await boxes('.lm-lib-size'); + for (let i = 0; i < names.length; i++) { + // The name and its size, then the state and what can be done. + expect(tags[i].top).toBeGreaterThanOrEqual(names[i].bottom - 1); + expect(sizes[i].top).toBeLessThan(names[i].bottom); + expect(same([names[i].left, tags[i].left])).toBe(true); + } + expect(same(sizes.map((box) => box.right))).toBe(true); + const buttons = await boxes('.lm-lib-row .lm-lib-actions button'); + for (const button of buttons) expect(button.height).toBeGreaterThanOrEqual(36); + const overflow = await p.evaluate(() => { + const body = document.getElementById('localModelWindowBody')!; + return body.scrollWidth - body.clientWidth; + }); + expect(overflow).toBeLessThanOrEqual(0); + }); + it('paints above App Settings when it is opened from there', async () => { await load(1440); await p.evaluate(() => document.getElementById('appSettingsModal')!.classList.add('active')); diff --git a/test/local-model-ui.test.ts b/test/local-model-ui.test.ts index e2b866ae..e0d50bd6 100644 --- a/test/local-model-ui.test.ts +++ b/test/local-model-ui.test.ts @@ -18,6 +18,10 @@ * screen, and a 409 `size-changed` shows the new total and sends that one next; * - the poll: once a second while the window is open, never after it closes, and a tick that * moved only the download leaves the buttons in place; + * - the models on this Mac: the list with its sizes, the state of each row, "Use" (a switch + * with no confirm screen), "Delete" (asked once, in the row), "Add a model" (the chooser, + * where a row that is on this Mac already is switched to), the way back from a stopped job, + * and what an earlier Remove left on disk; * - every payload string lands as text: an `` in a model, agent or chip name, an * error's detail, a session name, a folder or a command creates no element; * - a button exists only for an action the server lists. @@ -48,6 +52,7 @@ import type { LocalModelConflict, LocalModelErrorCode, LocalModelInstallView, + LocalModelLibraryRow, LocalModelMessage, LocalModelStatus, NoneReason, @@ -383,11 +388,26 @@ function install(over: Partial = {}): LocalModelInstallVi developerTools: 'present', runtime: RUNTIME_MISSING, folder: FOLDER, + library: [], actions: ['install'], ...over, }; } +/** The installed model as the row of the library it is: in use, checked, with nothing to do on it. */ +const QWEN_ROW: LocalModelLibraryRow = { + id: 'qwen3.6:35b-a3b', + label: 'Qwen3.6 35B-A3B', + context: 131072, + sizeBytes: 23105798956, + sizeGb: '23.1', + active: true, + verified: true, + status: 'ready', + actions: [], +}; +const STORE_ONE = { bytes: 23105798956, gb: '23.1' }; + /** The members a job carries from `installing` on. */ const JOB: Partial = { model: { id: 'qwen3.6:35b-a3b', label: 'Qwen3.6 35B-A3B' }, @@ -453,7 +473,9 @@ const INSTALLED = status( running: true, endpointId: 'local-ollama', loaded: { context: 131072, memoryBytes: 26300000000, memoryGb: '26.3', onGpu: true }, - actions: ['start-session', 'stop', 'remove'], + library: [QWEN_ROW], + store: STORE_ONE, + actions: ['start-session', 'stop', 'install', 'remove'], } ); const STOPPED = status( @@ -464,7 +486,9 @@ const STOPPED = status( running: false, endpointId: 'local-ollama', loaded: { context: 131072, memoryBytes: 26300000000, memoryGb: '26.3', onGpu: true }, - actions: ['start', 'remove'], + library: [QWEN_ROW], + store: STORE_ONE, + actions: ['start', 'install', 'remove'], } ); @@ -1705,6 +1729,8 @@ describe('an installed model', () => { // row's own estimate, so the two figures are never read as a contradiction. expect(texts(body, '.lm-aside')).toEqual([ 'Runs with OpenCode. Context 131,072 tokens. Takes 26.3 GB of memory now, and up to about 36 GB at its peak, with all of the context in use. All of it is on the GPU.', + // Under the list of models: what the downloads take on disk. + 'Downloaded models use 23.1 GB on this Mac.', ]); expect(buttons(body)).toEqual(['Remove', 'Stop', 'Start a session']); // One main action. @@ -2369,3 +2395,536 @@ describe('an installed model whose runtime did not start', () => { expect(verbs(app)).toEqual([['POST', '/api/local-model/runtime', { action: 'start' }]]); }); }); + +// ---------- The models on this Mac ---------- + +const GPT_ROW: LocalModelLibraryRow = { + id: 'gpt-oss:20b', + label: 'GPT-OSS 20B', + context: 65536, + sizeBytes: 13793441427, + sizeGb: '13.8', + active: false, + verified: true, + status: 'ready', + actions: ['use', 'delete'], +}; +const STORE_TWO = { bytes: 36899240383, gb: '36.9' }; + +/** Two models on this Mac, the Qwen one in use and running. */ +const TWO = status( + { budgetBytes: 40157944217, budgetGb: '40.2', budgetSource: 'measured' }, + { + ...INSTALLED.install, + library: [QWEN_ROW, GPT_ROW], + store: STORE_TWO, + actions: ['start-session', 'stop', 'install', 'use', 'delete-model', 'remove'], + } +); + +/** The buttons of the rows of the list (not the buttons of the screen), by their label. */ +const rowButtons = (page: Mounted) => texts(page.body, '.lm-lib-row .lm-lib-actions:not(.lm-lib-actions-away) button'); + +function pressIn(page: Mounted, selector: string, label: string) { + const found = [...page.frame.querySelectorAll(`${selector} button`)].find( + (el) => el.textContent === label + ); + expect(found, `no button "${label}" in ${selector}`).toBeTruthy(); + found!.click(); +} + +describe('the models on this Mac', () => { + it('lists the one installed model with its context, its state and its size on disk, and offers another', async () => { + const page = mount(); + await opened(page, INSTALLED); + const { body } = page; + expect(texts(body, '.lm-lib-caption-label')).toEqual(['Models on this Mac']); + expect(texts(body, '.lm-lib-caption-size')).toEqual(['On disk']); + expect(texts(body, '.lm-lib-label')).toEqual(['Qwen3.6 35B-A3B']); + expect(texts(body, '.lm-lib-meta')).toEqual(['131,072 tokens']); + expect(texts(body, '.lm-lib-tag .lm-tag')).toEqual(['In use']); + expect(texts(body, '.lm-lib-size')).toEqual(['23.1 GB']); + // The model in use wears the selected look, and nothing can be done ON it here. + expect(body.querySelector('.lm-lib-row')!.classList.contains('lm-lib-row-on')).toBe(true); + expect(rowButtons(page)).toEqual([]); + expect(texts(body, '.lm-lib-foot button')).toEqual(['Add a model']); + // A real list for assistive technology, named by its caption. + const list = body.querySelector('.lm-lib-list')!; + expect(list.getAttribute('role')).toBe('list'); + expect(list.getAttribute('aria-labelledby')).toBe('localModelLibraryLabel'); + expect(body.querySelectorAll('[role="listitem"]')).toHaveLength(1); + // The screen scrolls from its top: it is no short screen any more. + expect(body.dataset.long).toBe('true'); + // The buttons of the screen are what they were. + expect(buttons(body)).toEqual(['Remove', 'Stop', 'Start a session']); + }); + + it('two models: the one in use first, the other with Use and Delete, and what both take on disk', async () => { + const page = mount(); + await opened(page, TWO); + const { body } = page; + expect(texts(body, '.lm-lib-label')).toEqual(['Qwen3.6 35B-A3B', 'GPT-OSS 20B']); + expect(texts(body, '.lm-lib-meta')).toEqual(['131,072 tokens', '65,536 tokens']); + expect(texts(body, '.lm-lib-tag .lm-tag')).toEqual(['In use', 'Ready']); + expect(texts(body, '.lm-lib-size')).toEqual(['23.1 GB', '13.8 GB']); + expect(rowButtons(page)).toEqual(['Use', 'Delete']); + // A short label on screen, the model's name for a screen reader. + const [use, remove] = [...body.querySelectorAll('.lm-lib-row .lm-lib-actions button')]; + expect(use.getAttribute('aria-label')).toBe('Use GPT-OSS 20B'); + expect(remove.getAttribute('aria-label')).toBe('Delete GPT-OSS 20B'); + // Quiet buttons: the screen keeps its one main action, and nothing here is red yet. + expect(body.querySelectorAll('.lm-library .wt-btn-primary, .lm-library .wt-btn-danger')).toHaveLength(0); + expect(texts(body, '.lm-lib-notes .lm-aside')).toEqual(['Downloaded models use 36.9 GB on this Mac.']); + }); + + it('a row has a button only for an action the server lists for THAT row', async () => { + const page = mount(); + const rows: LocalModelLibraryRow[] = [ + QWEN_ROW, + { ...GPT_ROW, actions: ['use'] }, + { ...GPT_ROW, id: 'a:1b', label: 'A', status: 'changed', actions: ['delete'] }, + { ...GPT_ROW, id: 'b:1b', label: 'B', status: 'missing', actions: ['delete'] }, + { ...GPT_ROW, id: 'c:1b', label: 'C', context: undefined, verified: false, status: 'unverified', actions: [] }, + { id: 'd:1b', label: 'D', active: false, verified: false, status: 'unverified', actions: ['delete'] }, + ]; + await opened(page, status({}, { ...TWO.install, library: rows })); + const perRow = [...page.body.querySelectorAll('.lm-lib-row')].map((row) => [ + row.querySelector('.lm-lib-label')!.textContent, + row.querySelector('.lm-tag')!.textContent, + texts(row, '.lm-lib-actions button').join('+'), + ]); + expect(perRow).toEqual([ + ['Qwen3.6 35B-A3B', 'In use', ''], + ['GPT-OSS 20B', 'Ready', 'Use'], + ['A', 'Changed', 'Delete'], + ['B', 'Missing', 'Delete'], + ['C', 'Not checked', ''], + ['D', 'Not checked', 'Delete'], + ]); + // A row without a context or a size prints neither: no "undefined", no empty unit. + const last = [...page.body.querySelectorAll('.lm-lib-row')].at(-1)!; + expect(last.querySelector('.lm-lib-meta')).toBeNull(); + expect(last.querySelector('.lm-lib-size')!.textContent).toBe(''); + expect(page.body.textContent).not.toContain('undefined'); + // Each state has a colour of its own. + expect([...page.body.querySelectorAll('.lm-lib-tag .lm-tag')].map((tag) => tag.className)).toEqual([ + 'lm-tag lm-tag-inuse', + 'lm-tag lm-tag-ready', + 'lm-tag lm-tag-changed', + 'lm-tag lm-tag-missing', + 'lm-tag lm-tag-unverified', + 'lm-tag lm-tag-unverified', + ]); + }); + + it('Use switches at once: no confirm screen, and the screen says a switch is running', async () => { + const page = mount(); + const switching: LocalModelInstallView = { + ...TWO.install, + state: 'installing', + step: 'verify', + steps: ['verify', 'connect'], + model: { id: 'gpt-oss:20b', label: 'GPT-OSS 20B' }, + context: 65536, + library: [ + { ...QWEN_ROW, active: false }, + { ...GPT_ROW, actions: [] }, + ], + actions: ['cancel'], + }; + const { app } = await opened(page, TWO, () => ok(switching)); + pressIn(page, '.lm-lib-row', 'Use'); + await settle(); + expect(verbs(app)).toEqual([['POST', '/api/local-model/use', { modelId: 'gpt-oss:20b' }]]); + expect(page.body.dataset.screen).toBe('progress'); + expect(texts(page.body, '.lm-title')).toEqual(['Switching to GPT-OSS 20B']); + // Nothing is downloaded: no download bar, and the two steps of a switch. + expect(page.body.querySelector('.lm-meter')).toBeNull(); + expect(texts(page.body, '.lm-step-label')).toEqual(['Loading and checking', 'Connecting']); + expect(texts(page.body, '.lm-aside')).toEqual([ + 'You can close this window. The switch continues while Codeman is running.', + ]); + expect(buttons(page.body)).toEqual(['Cancel']); + }); + + it('a switch that is refused keeps the screen and prints the server sentence with the session names', async () => { + const page = mount(); + const { app } = await opened(page, TWO, () => + conflict({ + reason: 'sessions-open', + message: { text: LOCAL_MODEL_INSTALL_LABELS.conflictSessionsOpen, vars: { sessions: 'w1-app, w2-api' } }, + sessions: ['w1-app', 'w2-api'], + }) + ); + pressIn(page, '.lm-lib-row', 'Use'); + await settle(); + expect(page.body.dataset.screen).toBe('installed'); + expect(texts(page.body, '.lm-notice-text')).toEqual([ + 'Sessions are still using this model: w1-app, w2-api. Close them first.', + ]); + expect(verbs(app)).toHaveLength(1); + expect(rowButtons(page)).toEqual(['Use', 'Delete']); + }); + + it('Delete asks once, in the row, and sends nothing until the red button is pressed', async () => { + const page = mount(); + const after: LocalModelInstallView = { + ...TWO.install, + library: [QWEN_ROW], + store: STORE_ONE, + actions: ['start-session', 'stop', 'install', 'remove'], + }; + const { app } = await opened(page, TWO, () => ok(after)); + pressIn(page, '.lm-lib-row', 'Delete'); + await settle(); + expect(verbs(app)).toEqual([]); + const ask = page.body.querySelector('.lm-lib-ask')!; + expect(texts(ask, '.lm-lead')).toEqual(['Delete GPT-OSS 20B from this Mac?']); + expect(texts(ask, '.lm-aside')).toEqual(['This frees 13.8 GB.']); + expect(texts(ask, 'button')).toEqual(['Cancel', 'Delete']); + // Red only here, in its own question. + expect(page.frame.querySelectorAll('.wt-btn-danger')).toHaveLength(1); + expect(ask.querySelector('.wt-btn-danger')!.textContent).toBe('Delete'); + // The question sits right under the row it is about. That row's own buttons keep their + // room (the sizes must not jump) and are out of reach: unseen, disabled, hidden from a reader. + const asked = ask.previousElementSibling!; + expect(asked.querySelector('.lm-lib-label')!.textContent).toBe('GPT-OSS 20B'); + expect(rowButtons(page)).toEqual([]); + const away = asked.querySelector('.lm-lib-actions')!; + expect(away.classList.contains('lm-lib-actions-away')).toBe(true); + expect(away.getAttribute('aria-hidden')).toBe('true'); + expect([...away.querySelectorAll('button')].every((button) => button.disabled)).toBe(true); + // The focus is on the safe answer. + expect((page.document.activeElement as HTMLElement).textContent).toBe('Cancel'); + + pressIn(page, '.lm-lib-ask', 'Cancel'); + await settle(); + expect(page.body.querySelector('.lm-lib-ask')).toBeNull(); + expect(rowButtons(page)).toEqual(['Use', 'Delete']); + expect(verbs(app)).toEqual([]); + // Back on the button that asked. + expect((page.document.activeElement as HTMLElement).dataset.lmKey).toBe('delete:gpt-oss:20b'); + + pressIn(page, '.lm-lib-row', 'Delete'); + await settle(); + pressIn(page, '.lm-lib-ask', 'Delete'); + await settle(); + expect(verbs(app)).toEqual([['DELETE', '/api/local-model/models', { modelId: 'gpt-oss:20b' }]]); + expect(texts(page.body, '.lm-lib-label')).toEqual(['Qwen3.6 35B-A3B']); + expect(page.body.querySelector('.lm-lib-ask')).toBeNull(); + expect(texts(page.body, '.lm-lib-notes .lm-aside')).toEqual(['Downloaded models use 23.1 GB on this Mac.']); + }); + + it('a delete the server refuses leaves the row and prints why', async () => { + const page = mount(); + await opened(page, TWO, () => + conflict({ + reason: 'model-active', + message: { text: LOCAL_MODEL_INSTALL_LABELS.conflictModelActive, vars: { model: 'GPT-OSS 20B' } }, + }) + ); + pressIn(page, '.lm-lib-row', 'Delete'); + await settle(); + pressIn(page, '.lm-lib-ask', 'Delete'); + await settle(); + expect(texts(page.body, '.lm-notice-text')).toEqual([ + 'GPT-OSS 20B is the model in use. Switch to another model first, or remove the local model.', + ]); + expect(texts(page.body, '.lm-lib-label')).toEqual(['Qwen3.6 35B-A3B', 'GPT-OSS 20B']); + }); + + it('the Delete question of a row and the Remove question are never open together', async () => { + const page = mount(); + await opened(page, TWO); + pressIn(page, '.lm-lib-row', 'Delete'); + await settle(); + expect(page.body.querySelector('.lm-lib-ask')).not.toBeNull(); + press(page.body, 'Remove'); + await settle(); + expect(page.frame.querySelector('.lm-remove')).not.toBeNull(); + expect(page.frame.querySelector('.lm-lib-ask')).toBeNull(); + }); + + it('with the runtime stopped a row offers no delete, and one line says how to get it', async () => { + const page = mount(); + const stopped = status( + {}, + { + ...STOPPED.install, + library: [QWEN_ROW, { ...GPT_ROW, actions: ['use'] }], + store: STORE_TWO, + actions: ['start', 'install', 'use', 'remove'], + } + ); + await opened(page, stopped); + expect(rowButtons(page)).toEqual(['Use']); + expect(texts(page.body, '.lm-lib-notes .lm-aside')).toEqual([ + 'Downloaded models use 36.9 GB on this Mac.', + 'Press Start to delete a single model.', + ]); + // With one model there is no single model to delete, so the line is not there. + const one = mount(); + await opened(one, STOPPED); + expect(one.body.textContent).not.toContain('Press Start to delete'); + }); + + it('the screen that ends an install says one thing: no list, one button', async () => { + const page = mount(); + const { app, serve } = await opened(page, INSTALLING); + serve(TWO); + await app.loadLocalModel({ force: true }); + expect(page.body.dataset.screen).toBe('installed'); + expect(page.body.querySelector('.lm-library')).toBeNull(); + expect(page.body.dataset.long).toBe('false'); + expect(buttons(page.body)).toEqual(['Start a session']); + }); + + it('"Add a model" opens the chooser on an installed model, and Back returns to it', async () => { + const page = mount(); + const { app } = await opened(page, TWO); + pressIn(page, '.lm-lib-foot', 'Add a model'); + await settle(); + expect(page.body.dataset.screen).toBe('choose'); + expect(page.body.querySelectorAll('[role="radio"]').length).toBeGreaterThan(1); + expect(buttons(page.body)).toEqual(['Back', 'Install on this Mac']); + press(page.body, 'Back'); + await settle(); + expect(page.body.dataset.screen).toBe('installed'); + expect(verbs(app)).toEqual([]); + // No button without the server offering an install (no row fits, or it is not listed). + const none = mount(); + await opened(none, status({}, { ...TWO.install, actions: ['start-session', 'stop', 'remove'] })); + expect(texts(none.body, '.lm-lib-foot button')).toEqual([]); + }); + + it('in the chooser a model that is on this Mac says so, and is switched to without a download', async () => { + const page = mount(); + const answer = status( + { + pick: { ...PICK, library: 'active' }, + alternatives: [{ ...ALT_SLOW, library: 'ready' }, ALT_SMALL], + }, + TWO.install + ); + const { app } = await opened(page, answer, () => ok({ ...TWO.install, state: 'installing', step: 'verify' })); + pressIn(page, '.lm-lib-foot', 'Add a model'); + await settle(); + const rows = [...page.body.querySelectorAll('.lm-model')]; + const tagsOf = (row: Element) => texts(row, '.lm-tag'); + // The model in use: its own tag beside the server's, and nothing to do with it here. + expect(tagsOf(rows[0])).toContain('In use'); + const primary = () => page.frame.querySelector('.lm-buttons .wt-btn-primary')!; + expect(primary().textContent).toBe('In use'); + expect(primary().disabled).toBe(true); + + // A model that is on this Mac and checked: one click switches to it. + const ready = rows.find((row) => tagsOf(row).includes('On this Mac'))!; + expect(ready).toBeTruthy(); + (ready as HTMLElement).click(); + await settle(); + expect(primary().textContent).toBe('Use this model'); + expect(primary().disabled).toBe(false); + primary().click(); + await settle(); + expect(verbs(app)).toEqual([['POST', '/api/local-model/use', { modelId: ALT_SLOW.modelId }]]); + // No confirm screen was shown on the way. + expect(page.body.dataset.screen).toBe('progress'); + }); + + it('in the chooser a model that is not on this Mac is installed the usual way, with its sizes confirmed', async () => { + const page = mount(); + const answer = status({ pick: { ...PICK, library: 'active' }, alternatives: [ALT_SMALL] }, TWO.install); + const { app } = await opened(page, answer, () => ok({ ...TWO.install, state: 'installing', step: 'model' })); + pressIn(page, '.lm-lib-foot', 'Add a model'); + await settle(); + const other = [...page.body.querySelectorAll('.lm-model')].find( + (row) => row.dataset.modelId === ALT_SMALL.modelId + )!; + other.click(); + await settle(); + press(page.body, 'Install on this Mac'); + await settle(); + expect(page.body.dataset.screen).toBe('confirm'); + press(page.body, 'Download and install'); + await settle(); + expect(verbs(app)).toEqual([ + [ + 'POST', + '/api/local-model/install', + { + modelId: ALT_SMALL.modelId, + cli: ALT_SMALL.harnesses[0].cli, + context: ALT_SMALL.context, + acknowledgedBytes: ALT_SMALL.installBytes, + }, + ], + ]); + }); + + it('a job that stopped beside a checked model shows the way back to that model', async () => { + const back: LocalModelLibraryRow = { ...QWEN_ROW, active: false, actions: ['use', 'delete'] }; + for (const first of [ + status( + {}, + { ...PAUSED.install, library: [back], actions: ['resume', 'install', 'use', 'delete-model', 'remove'] } + ), + status( + {}, + { + ...failed('no-tool-call', { model: 'GPT-OSS 20B' }).install, + library: [back], + actions: ['resume', 'install', 'use', 'delete-model', 'remove'], + } + ), + ]) { + const page = mount(); + const { app } = await opened(page, first, () => ok({ ...TWO.install, state: 'installing', step: 'verify' })); + expect(texts(page.body, '.lm-lib-label')).toEqual(['Qwen3.6 35B-A3B']); + expect(texts(page.body, '.lm-lib-tag .lm-tag')).toEqual(['Ready']); + expect(rowButtons(page)).toEqual(['Use', 'Delete']); + // No "Add a model" here: the job's own buttons offer another model. + expect(texts(page.body, '.lm-lib-foot button')).toEqual([]); + pressIn(page, '.lm-lib-row', 'Use'); + await settle(); + expect(verbs(app)).toEqual([['POST', '/api/local-model/use', { modelId: 'qwen3.6:35b-a3b' }]]); + } + }); + + it('a first job that stopped has nothing to go back to, and shows no list', async () => { + const page = mount(); + // Its own model is on disk and checked, with nothing offered on it: Resume goes on with it. + await opened(page, status({}, { ...PAUSED.install, library: [{ ...QWEN_ROW, active: false }] })); + expect(page.body.querySelector('.lm-library')).toBeNull(); + expect(page.body.dataset.long).toBe('false'); + const stopped = mount(); + await opened(stopped, failed('load-failed', { model: 'Qwen3.6 35B-A3B' })); + expect(stopped.body.querySelector('.lm-library')).toBeNull(); + }); + + it('a paused switch says so, and waits', async () => { + const page = mount(); + await opened( + page, + status({}, { ...PAUSED.install, step: 'verify', steps: ['verify', 'connect'], progress: undefined }) + ); + expect(texts(page.body, '.lm-title')).toEqual(['The switch to Qwen3.6 35B-A3B is paused']); + expect(texts(page.body, '.lm-aside')).toEqual(['The switch waits until you continue.']); + expect(page.body.querySelector('.lm-meter')).toBeNull(); + }); + + it('the App Settings row names a switch as a switch', async () => { + const page = mount(); + const job = { ...JOB, steps: ['verify', 'connect'] as LocalModelInstallView['steps'], step: 'verify' as const }; + for (const [state, text] of [ + ['installing', 'Switching to Qwen3.6 35B-A3B'], + ['paused', 'The switch to Qwen3.6 35B-A3B is paused'], + ['failed', 'The switch to Qwen3.6 35B-A3B stopped'], + ] as const) { + const app = page.newApp(ok(status({}, { ...job, state, actions: [] }))); + await app.loadLocalModel({ force: true }); + expect(texts(page.row, '.set-row-label')).toEqual([text]); + } + }); +}); + +describe('what an earlier Remove left on disk', () => { + const LEFT = status({}, { store: STORE_ONE, actions: ['install', 'remove'] }); + + it('the chooser says what the downloads still take, and deletes them after one question', async () => { + const page = mount(); + const { app } = await opened(page, LEFT, () => ok(install({ store: { bytes: 0, gb: '0.0' } }))); + expect(texts(page.body, '.lm-leftovers .lm-aside')).toEqual([ + 'Models from an earlier install still use 23.1 GB on this Mac.', + ]); + pressIn(page, '.lm-leftovers', 'Delete them'); + await settle(); + expect(verbs(app)).toEqual([]); + expect(texts(page.body, '.lm-leftovers .lm-lead')).toEqual(['Delete the downloaded models from this Mac?']); + expect(texts(page.body, '.lm-leftovers .lm-lib-ask .lm-aside')).toEqual(['This frees 23.1 GB.']); + expect(page.body.querySelector('.lm-leftovers .wt-btn-danger')!.textContent).toBe('Delete'); + pressIn(page, '.lm-leftovers', 'Cancel'); + await settle(); + expect(texts(page.body, '.lm-leftovers button')).toEqual(['Delete them']); + pressIn(page, '.lm-leftovers', 'Delete them'); + await settle(); + pressIn(page, '.lm-leftovers', 'Delete'); + await settle(); + expect(verbs(app)).toEqual([['DELETE', '/api/local-model', { removeModel: true }]]); + expect(page.body.querySelector('.lm-leftovers')).toBeNull(); + // Still the chooser: installing is what this screen is for. + expect(page.body.dataset.screen).toBe('choose'); + expect(buttons(page.body)).toEqual(['Install on this Mac']); + }); + + it('is not there without something on disk, or without the server offering the removal', async () => { + for (const first of [ + IDLE, + status({}, { store: { bytes: 0, gb: '0.0' }, actions: ['install', 'remove'] }), + status({}, { store: STORE_ONE, actions: ['install'] }), + ]) { + const page = mount(); + await opened(page, first); + expect(page.body.querySelector('.lm-leftovers')).toBeNull(); + } + }); + + it('shows on a Mac no model fits too: the space can still be freed', async () => { + const page = mount(); + const answer = none('memory'); + await opened(page, { ...answer, install: install({ store: STORE_ONE, actions: ['remove'] }) }); + expect(page.body.dataset.screen).toBe('none'); + expect(texts(page.body, '.lm-leftovers .lm-aside')).toEqual([ + 'Models from an earlier install still use 23.1 GB on this Mac.', + ]); + }); +}); + +describe('the models on this Mac: text of someone else, another language, an unchanged answer', () => { + it('a model name is text, in the row, in its question and in the labels of its buttons', async () => { + const HOSTILE = ''; + const page = mount(); + const rows: LocalModelLibraryRow[] = [QWEN_ROW, { ...GPT_ROW, id: `evil:1b`, label: `Model ${HOSTILE}` }]; + await opened(page, status({}, { ...TWO.install, library: rows, folder: `/tmp/${HOSTILE}` })); + pressIn(page, '.lm-lib-row', 'Delete'); + await settle(); + expect(page.document.querySelectorAll('img, script, iframe')).toHaveLength(0); + expect((page.win as unknown as { __pwned?: number }).__pwned).toBeUndefined(); + expect(texts(page.body, '.lm-lib-ask .lm-lead')).toEqual([`Delete Model ${HOSTILE} from this Mac?`]); + }); + + it('is translated when the language changes, the names staying as sent', async () => { + const page = mount({ i18n: true }); + page.win.CodemanI18n.start(); + await opened(page, TWO); + page.win.CodemanI18n.configure({ language: 'zh-CN' }); + await settle(); + expect(texts(page.body, '.lm-lib-caption-label')).toEqual(['此 Mac 上的模型']); + expect(texts(page.body, '.lm-lib-tag .lm-tag')).toEqual(['使用中', '就绪']); + expect(rowButtons(page)).toEqual(['使用', '删除']); + expect(texts(page.body, '.lm-lib-label')).toEqual(['Qwen3.6 35B-A3B', 'GPT-OSS 20B']); + expect(texts(page.body, '.lm-lib-notes .lm-aside')).toEqual(['已下载的模型在此 Mac 上占用 36.9 GB。']); + expect(texts(page.body, '.lm-lib-foot button')).toEqual(['添加模型']); + }); + + it('a poll that changes nothing leaves the rows and their buttons in place', async () => { + const page = mount(); + await opened(page, TWO); + const before = page.body.querySelector('.lm-lib-row .lm-lib-actions button'); + await page.tick(); + await page.tick(); + expect(page.body.querySelector('.lm-lib-row .lm-lib-actions button')).toBe(before); + }); + + it('the focus stays on the row button it was on when the list is repainted', async () => { + const page = mount(); + const { app, serve } = await opened(page, TWO); + const remove = [...page.body.querySelectorAll('.lm-lib-row .lm-lib-actions button')][1]; + remove.focus(); + serve(status({}, { ...TWO.install, store: { bytes: 36899240384, gb: '36.9' }, port: 11436 })); + await app.loadLocalModel({ force: true }); + const active = page.document.activeElement as HTMLElement; + expect(active.textContent).toBe('Delete'); + expect(active.dataset.lmKey).toBe('delete:gpt-oss:20b'); + expect(active).not.toBe(remove); + }); +}); diff --git a/test/routes/local-model-routes.test.ts b/test/routes/local-model-routes.test.ts index 11ecb354..ac59b8b6 100644 --- a/test/routes/local-model-routes.test.ts +++ b/test/routes/local-model-routes.test.ts @@ -155,6 +155,7 @@ const IDLE_VIEW: LocalModelInstallView = { developerTools: 'missing', runtime: { version: '0.40.15', installed: false, downloadBytes: 185971671, downloadGb: '0.2', unpackedGb: '0.6' }, folder: '/Users/me/.codeman/local-model', + library: [], actions: ['install'], }; @@ -182,6 +183,8 @@ function fakeService(): ServiceMock { launchRefusalMessage: vi.fn(async () => undefined), recommendOptions: vi.fn(async () => ({ runtimeDownloadBytes: 185971671 })), install: vi.fn(async () => OK_RESULT), + use: vi.fn(async () => OK_RESULT), + deleteLibraryModel: vi.fn(async () => OK_RESULT), cancel: vi.fn(async () => OK_RESULT), resume: vi.fn(async () => OK_RESULT), runtime: vi.fn(async () => OK_RESULT), @@ -555,6 +558,13 @@ describe('the install verbs', () => { /** Every verb as a request, with a body the route accepts. */ const VERBS = [ { name: 'install', method: 'POST', url: '/api/local-model/install', payload: INSTALL_BODY }, + { name: 'use', method: 'POST', url: '/api/local-model/use', payload: { modelId: 'qwen3.8:27b' } }, + { + name: 'deleteLibraryModel', + method: 'DELETE', + url: '/api/local-model/models', + payload: { modelId: 'qwen3.8:27b' }, + }, { name: 'cancel', method: 'POST', url: '/api/local-model/cancel', payload: undefined }, { name: 'resume', method: 'POST', url: '/api/local-model/resume', payload: {} }, { name: 'runtime', method: 'POST', url: '/api/local-model/runtime', payload: { action: 'stop' } }, @@ -654,7 +664,18 @@ describe('the install verbs', () => { const f = fakes(); const { app } = await harness(f.deps, { username: 'alice', role: 'admin' }); await app.inject({ method: 'POST', url: '/api/local-model/install', payload: INSTALL_BODY }); - expect(f.service.install).toHaveBeenCalledWith(INSTALL_BODY, { username: 'alice', ip: '127.0.0.1' }); + expect(f.service.install).toHaveBeenCalledWith(INSTALL_BODY, { username: 'alice', ip: '127.0.0.1' }, []); + }); + + it('hands the service the names of the live sessions on the model: another model would take the runtime from them', async () => { + const f = fakes(); + const { app } = await harness(f.deps, undefined, [ + { name: 'w1-app', customModel: { endpointId: 'local-ollama' } }, + { name: 'w2-app' }, + { name: 'w3-lib', customModel: { endpointId: 'office-gpu' } }, + ]); + await app.inject({ method: 'POST', url: '/api/local-model/install', payload: INSTALL_BODY }); + expect(f.service.install.mock.calls[0][2]).toEqual(['w1-app']); }); it('a row the server does not offer is a 400 with the service own sentence, as text and as data', async () => { @@ -925,6 +946,177 @@ describe('the install verbs', () => { }); }); +describe('the library verbs', () => { + const SESSIONS: SessionLike[] = [ + { name: 'w1-app', customModel: { endpointId: 'local-ollama' } }, + { name: 'w2-app' }, + { name: 'w3-lib', customModel: { endpointId: 'office-gpu' } }, + ]; + + describe('POST /api/local-model/use', () => { + it('hands the service the model, who asked and the live sessions on the model', async () => { + const f = fakes(); + const { app } = await harness(f.deps, { username: 'alice', role: 'admin' }, SESSIONS); + await app.inject({ method: 'POST', url: '/api/local-model/use', payload: { modelId: 'gpt-oss:20b' } }); + expect(f.service.use).toHaveBeenCalledWith({ modelId: 'gpt-oss:20b' }, { username: 'alice', ip: '127.0.0.1' }, [ + 'w1-app', + ]); + }); + + it('a model that is not one of the checked ones is a 400 with the sentence, as text and as data', async () => { + const f = fakes(); + f.service.use.mockResolvedValue({ + ok: false, + status: 400, + message: { text: LOCAL_MODEL_INSTALL_LABELS.refusedNotInLibrary }, + }); + const { app } = await harness(f.deps); + const res = await app.inject({ method: 'POST', url: '/api/local-model/use', payload: { modelId: 'x:1b' } }); + expect(res.statusCode).toBe(400); + expect(res.json()).toEqual({ + success: false, + error: 'This model is not one of the checked models on this Mac.', + errorCode: 'INVALID_INPUT', + data: { message: { text: 'This model is not one of the checked models on this Mac.' } }, + }); + }); + + it.each([ + ['no body', undefined], + ['no model', {}], + ['a path', { modelId: '../../etc/passwd' }], + ['another registry', { modelId: 'hf.co/someone/model:Q4' }], + ['a member it does not know', { modelId: 'gpt-oss:20b', context: 65536 }], + ])('refuses %s before the service is asked', async (_name, payload) => { + const f = fakes(); + const { app } = await harness(f.deps); + const res = await app.inject({ method: 'POST', url: '/api/local-model/use', ...(payload ? { payload } : {}) }); + expect(res.statusCode).toBe(400); + expect(f.service.use).not.toHaveBeenCalled(); + }); + }); + + describe('DELETE /api/local-model/models', () => { + it('hands the service the model name and who asked', async () => { + const f = fakes(); + const { app } = await harness(f.deps, { username: 'alice', role: 'admin' }); + await app.inject({ method: 'DELETE', url: '/api/local-model/models', payload: { modelId: 'gpt-oss:20b' } }); + expect(f.service.deleteLibraryModel).toHaveBeenCalledWith( + { modelId: 'gpt-oss:20b' }, + { username: 'alice', ip: '127.0.0.1' } + ); + // The whole installation is another route: it was not asked. + expect(f.service.remove).not.toHaveBeenCalled(); + }); + + it.each([ + ['no body', undefined], + ['a path', { modelId: '/Users/me/.codeman/local-model/models' }], + ['a path that climbs', { modelId: '../../etc/passwd' }], + ['a name with a slash', { modelId: 'library/qwen3.8:27b' }], + ['a name without a tag', { modelId: 'qwen3.8' }], + ['a path member', { modelId: 'gpt-oss:20b', path: '/' }], + ])('takes a model name and nothing else: refuses %s', async (_name, payload) => { + const f = fakes(); + const { app } = await harness(f.deps); + const res = await app.inject({ + method: 'DELETE', + url: '/api/local-model/models', + ...(payload ? { payload } : {}), + }); + expect(res.statusCode).toBe(400); + expect(f.service.deleteLibraryModel).not.toHaveBeenCalled(); + }); + + it('the model in use: 409 with the reason and the sentence', async () => { + const f = fakes(); + f.service.deleteLibraryModel.mockResolvedValue({ + ok: false, + status: 409, + conflict: { + reason: 'model-active', + message: { text: LOCAL_MODEL_INSTALL_LABELS.conflictModelActive, vars: { model: 'Qwen3.8 27B' } }, + }, + }); + const { app } = await harness(f.deps); + const res = await app.inject({ + method: 'DELETE', + url: '/api/local-model/models', + payload: { modelId: 'qwen3.8:27b' }, + }); + expect(res.statusCode).toBe(409); + expect(res.json()).toEqual({ + success: false, + error: 'Qwen3.8 27B is the model in use. Switch to another model first, or remove the local model.', + errorCode: 'CONFLICT', + data: { + reason: 'model-active', + message: { + text: '{model} is the model in use. Switch to another model first, or remove the local model.', + vars: { model: 'Qwen3.8 27B' }, + }, + }, + }); + }); + + it('a runtime that did not delete it: 500 with the sentence, as text and as data', async () => { + const f = fakes(); + f.service.deleteLibraryModel.mockResolvedValue({ + ok: false, + status: 500, + message: { text: LOCAL_MODEL_INSTALL_LABELS.deleteFailed, vars: { model: 'GPT-OSS 20B' } }, + }); + const { app } = await harness(f.deps); + const res = await app.inject({ + method: 'DELETE', + url: '/api/local-model/models', + payload: { modelId: 'gpt-oss:20b' }, + }); + expect(res.statusCode).toBe(500); + expect(res.json()).toEqual({ + success: false, + error: 'GPT-OSS 20B could not be deleted from this Mac.', + errorCode: 'OPERATION_FAILED', + data: { message: { text: '{model} could not be deleted from this Mac.', vars: { model: 'GPT-OSS 20B' } } }, + }); + }); + }); + + describe('GET /api/local-model marks the rows that are already on this Mac', () => { + it('the model in use and a model a switch can take, at the context they were checked with', async () => { + const second = { ...OK.pick!, modelId: 'gpt-oss:20b', modelLabel: 'GPT-OSS 20B', context: 65536 }; + const third = { ...OK.pick!, modelId: 'mimo-v2.6:9b-q4_k_m', modelLabel: 'MiMo V2.6 9B' }; + const f = fakes(MAC, { ...OK, alternatives: [second, third] }); + const row = (id: string, context: number, active: boolean) => ({ + id, + label: id, + context, + active, + verified: true, + status: 'ready' as const, + actions: active ? [] : ['use' as const], + }); + f.service.view.mockResolvedValue({ + ...IDLE_VIEW, + state: 'installed', + library: [row(OK.pick!.modelId, OK.pick!.context, true), row('gpt-oss:20b', 65536, false)], + actions: ['start-session', 'stop', 'install', 'use', 'remove'], + }); + const data = (await get(f.deps)).json().data; + expect(data.recommendation.pick.library).toBe('active'); + expect(data.recommendation.alternatives[0].library).toBe('ready'); + expect(data.recommendation.alternatives[1]).not.toHaveProperty('library'); + // What recommend() answered is not written to. + expect(OK.pick).not.toHaveProperty('library'); + }); + + it('with nothing on this Mac no row carries the mark', async () => { + const data = (await get(fakes().deps)).json().data; + expect(data.recommendation.pick).not.toHaveProperty('library'); + }); + }); +}); + describe('the routes over the real install service', () => { const STATE = () => dataPath('local-model.json');