mirror of
https://github.com/Ark0N/Codeman.git
synced 2026-11-17 11:49:33 +01:00
fix: apply the review items for #714 at merge
- Session update no longer resets "How often" while typing: updateGitFetchStatus (session-ui.js) leaves a control alone while it is document.activeElement, and autoSaveGitFetch writes the clamped interval back itself (Enter saves with the field still focused). - Partial override shows the app values: enabled = session ?? app switch, interval = session ?? app interval ?? 300 (session-ui.js updateGitFetchStatus). - runFetch (git-fetch.ts) arms the spawn with what the core.sshCommand read left of timeoutMs, and answers ETIMEDOUT without spawning when nothing is left, so a git that never answers costs one timeout, not two. - fetchEnvFor keeps a GIT_SSH from the server's environment (repoSshCommand || base.GIT_SSH), fileoverview and CLAUDE.md line updated to say so. - i18n.js: the zh-CN "Git fetch on an interval" description scopes the only writing git command to the Git window. - styles.css: the disabled/busy rules are scoped to .git-status-actions .btn-icon-sm (moved beside .git-status-actions), and the busy pulse stops under prefers-reduced-motion. - Comments that called the override per case now say per session: session.ts (field, restore and getter docs, setGitFetchSettings), git-fetch-scheduler.ts:2, server-timing.ts:78, server.ts (cleanup and restore), app.js _onSessionUpdated, session-ui.js (openSessionOptions and updateGitFetchStatus). - Tests: test/git-fetch-session-options-ui.test.ts (new, JSDOM: typing survives an SSE update, the Enter write-back, both partial cases); test/git-fetch.test.ts (GIT_SSH kept; one bound for the read and the fetch, stub git on PATH). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
3411d7f35a
commit
6539bc6c82
12 files changed
+299
-68
No files matched your search
+36
-27
@@ -7151,33 +7151,6 @@ html[data-skin="og"] .welcome-primary:hover {
|
||||
background: var(--bg-hover);
|
||||
}
|
||||
|
||||
/* A Fetch button cannot be clicked twice while its fetch is running, and is not offered for a session
|
||||
there is nothing to fetch for (no repository, remote or Docker). */
|
||||
.btn-icon-sm[disabled] {
|
||||
color: var(--text-dim);
|
||||
opacity: 0.45;
|
||||
cursor: default;
|
||||
}
|
||||
|
||||
.btn-icon-sm[disabled]:hover {
|
||||
background: none;
|
||||
}
|
||||
|
||||
.btn-icon-sm[aria-busy='true'] {
|
||||
color: var(--text);
|
||||
animation: btn-icon-busy 1.1s ease-in-out infinite;
|
||||
}
|
||||
|
||||
@keyframes btn-icon-busy {
|
||||
0%,
|
||||
100% {
|
||||
opacity: 0.55;
|
||||
}
|
||||
50% {
|
||||
opacity: 0.9;
|
||||
}
|
||||
}
|
||||
|
||||
.settings-section {
|
||||
margin-bottom: 1.25rem;
|
||||
padding-bottom: 1rem;
|
||||
@@ -22175,6 +22148,42 @@ html .toolbar .btn-git-status[aria-expanded='true'] {
|
||||
gap: 0.25rem;
|
||||
}
|
||||
|
||||
/* A Fetch button cannot be clicked twice while its fetch is running, and is not offered for a session
|
||||
there is nothing to fetch for (no repository, remote or Docker). Scoped to the Git panel's header: the
|
||||
File Viewer's Back/Forward and the folder grid's Up button are .btn-icon-sm too, and keep their own look. */
|
||||
.git-status-actions .btn-icon-sm[disabled] {
|
||||
color: var(--text-dim);
|
||||
opacity: 0.45;
|
||||
cursor: default;
|
||||
}
|
||||
|
||||
.git-status-actions .btn-icon-sm[disabled]:hover {
|
||||
background: none;
|
||||
}
|
||||
|
||||
.git-status-actions .btn-icon-sm[aria-busy='true'] {
|
||||
color: var(--text);
|
||||
animation: btn-icon-busy 1.1s ease-in-out infinite;
|
||||
}
|
||||
|
||||
@keyframes btn-icon-busy {
|
||||
0%,
|
||||
100% {
|
||||
opacity: 0.55;
|
||||
}
|
||||
50% {
|
||||
opacity: 0.9;
|
||||
}
|
||||
}
|
||||
|
||||
/* No pulse under reduced motion: the button holds the pulse's brighter step, still dimmer than at rest. */
|
||||
@media (prefers-reduced-motion: reduce) {
|
||||
.git-status-actions .btn-icon-sm[aria-busy='true'] {
|
||||
animation: none;
|
||||
opacity: 0.7;
|
||||
}
|
||||
}
|
||||
|
||||
.git-status-body {
|
||||
flex: 1;
|
||||
overflow-y: auto;
|
||||
|
||||
Reference in new issue
Block a user