mirror of
https://github.com/Ark0N/Codeman.git
synced 2026-11-16 19:29:33 +01:00
fix: keep foreign discovery from throwing, and correct the adoption docs (release review)
candidatesFrom had moved outside the try when the transports moved to runForeignProbe, so a classifier failure would have reached the route as a 500. The module promises it never throws, so the guard is back for local and docker. Docs: - The api reference said `blocked` waits are always refused, and listed Ralph as refused while two of its file routes were not (they are now). - The invariants doc and CLAUDE.md gain the rules this review turned up: target syntax in names, the ping before list-panes, nothing typed into an adopted pane, quoteAdoptLaunch. - CLAUDE.md no longer says every claude session gets hooks or a stop wait. - ForeignTmuxSession's mode and workingDir describe the first listed pane, not the active one. - The wiki had no page on adoption: The Dashboard gains an Opened outside Codeman section, and the remote and docker pages point at it. docs/docker-cases.md now separates an adopted container from an adopted tmux session. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
25214fcc5f
commit
2d7cd49449
11 files changed
+104
-30
No files matched your search
@@ -176,6 +176,12 @@ when the tab closes.
|
||||
session. `remoteSessionName` holds its existing tmux name. Closing the tab
|
||||
**detaches**, never kills.
|
||||
|
||||
⚠️ This covers `codeman-*` sessions on the `codeman-remote` socket, the ones another
|
||||
Codeman runs. A tmux session a HUMAN started on the host is a separate path:
|
||||
`GET /api/mux/foreign?remote=1` finds it and `POST /api/sessions/adopt` wraps it, with
|
||||
the connection on `Session.adopt.remote` and `session.remote` undefined. Closing that tab
|
||||
detaches too. See `docs/architecture-invariants.md#adopted-foreign-tmux-sessions`.
|
||||
|
||||
### Discovery
|
||||
|
||||
`listRemoteCodemanSessions(host)` lists the remote's `codeman-*` sessions:
|
||||
|
||||
Reference in new issue
Block a user