mirror of
https://github.com/Ark0N/Codeman.git
synced 2026-11-20 04:59:34 +01:00
fix(deepseek): make the Harness web tab render, not just authenticate
`dsh web` gates its own index behind a per-process launch token it prints on boot, and only that URL mints the `dsh-auth-*` cookie every later request needs. The managed tab stores the clean URL, so nothing on the browser side could present the token: the iframe rendered dsh's 401 text, a blank tab. Read the token out of the captured boot output, trade it for the cookie once at startup (`redirect: 'manual'`, since the 303 is what carries Set-Cookie), and let the proxy present it on both the HTTP and WebSocket legs. Scoped to the exact loopback authority the cookie was minted for; a token-less banner (an older dsh) keeps the previous behaviour untouched. The banner is scanned on its own 256 KB budget rather than the 16 KB error-tail buffer: a chatty profile can fill that cap before the banner prints. Authentication alone was not enough. dsh ships `<base href="./">`, which a browser resolves against the DOCUMENT url — and the proxy's runtime shim rewrites that url to strip the `/webview/<cap>/` prefix. The base therefore landed on Codeman's root: every module script 404'd and the page painted its inline `#151517` background with nothing on it (the black screen that replaced the white one). `rewriteHtml` now resolves a relative base against the proxy prefix before the mask can run, leaving a cross-origin base exactly as written. Verified against dsh 0.2.1-rc.5 and a live Codeman build: bare GET 401, captured cookie 200, proxied `/api` WebSocket 101, and a headless-Chrome load of the proxied tab boots the full Harness UI with no console errors.
This commit is contained in:
1 parent
e99b42c387
commit
0b3087918f
8 files changed
+474
-9
No files matched your search
@@ -238,6 +238,27 @@ describe('buildUpstreamRequestHeaders', () => {
|
||||
expect(headers.authorization).toBeUndefined();
|
||||
});
|
||||
|
||||
// `dsh web` mints its session cookie for the loopback authority the proxy
|
||||
// dials, which the browser has never visited and cannot store anything for.
|
||||
// The supervisor holds it instead, and it must win over the browser's copy.
|
||||
it('replaces the browser cookies with a server-held credential', () => {
|
||||
const headers = buildUpstreamRequestHeaders({ cookie: 'codeman_session=SECRET; stale=1' }, upstream, {
|
||||
forwardCookies: true,
|
||||
sessionCookieName: 'codeman_session',
|
||||
injectedCookie: 'dsh-auth-p=v1.payload.sig',
|
||||
});
|
||||
expect(headers.cookie).toBe('dsh-auth-p=v1.payload.sig');
|
||||
});
|
||||
|
||||
it('sends the server-held credential even when browser cookies are not forwarded', () => {
|
||||
const headers = buildUpstreamRequestHeaders({}, upstream, {
|
||||
forwardCookies: false,
|
||||
sessionCookieName: 'codeman_session',
|
||||
injectedCookie: 'dsh-auth-p=v1.payload.sig',
|
||||
});
|
||||
expect(headers.cookie).toBe('dsh-auth-p=v1.payload.sig');
|
||||
});
|
||||
|
||||
it('presents Origin/Referer as if the browser talked to the dashboard directly', () => {
|
||||
const headers = buildUpstreamRequestHeaders({ origin: 'https://codeman.local' }, upstream, {
|
||||
forwardCookies: false,
|
||||
@@ -345,6 +366,25 @@ describe('rewriteHtml', () => {
|
||||
expect(out.match(/<base/g)).toHaveLength(1);
|
||||
});
|
||||
|
||||
// A Vite build ships `<base href="./">`, and the runtime shim rewrites the
|
||||
// document URL to strip the prefix — so "./" would resolve to Codeman's root
|
||||
// and every module script would 404 behind an otherwise-painted page.
|
||||
it('resolves a page-relative <base> against the prefix before the shim masks the URL', () => {
|
||||
const out = rewriteHtml('<html><head><base href="./"></head></html>', CAP);
|
||||
expect(out).toContain(`<base href="${PREFIX}">`);
|
||||
expect(out.match(/<base/g)).toHaveLength(1);
|
||||
});
|
||||
|
||||
it('keeps a sub-path in a relative <base> inside the proxy prefix', () => {
|
||||
const out = rewriteHtml('<html><head><base target="_blank" href="./sub/"></head></html>', CAP);
|
||||
expect(out).toContain(`<base target="_blank" href="${PREFIX}sub/">`);
|
||||
});
|
||||
|
||||
it('leaves a cross-origin <base> exactly as the author wrote it', () => {
|
||||
const out = rewriteHtml('<html><head><base href="https://cdn.example/x/"></head></html>', CAP);
|
||||
expect(out).toContain('<base href="https://cdn.example/x/">');
|
||||
});
|
||||
|
||||
it('still injects the runtime shim when the page ships its own <base>', () => {
|
||||
// The shim is the only layer that catches runtime-built URLs, so an early
|
||||
// return on an existing <base> would silently break those pages.
|
||||
|
||||
Reference in new issue
Block a user