From 007ea8cfb338f9c430e6991d8388d6626d0c0300 Mon Sep 17 00:00:00 2001 From: Codeman maintainer Date: Sun, 18 Oct 2026 08:05:34 +0200 Subject: [PATCH] fix(#592): a docker case signs Copilot in inside the container, never by token Both Docker sections said "or set COPILOT_GITHUB_TOKEN for the session", which cannot work: a docker quick-start refuses envOverrides (session-routes.ts), and Copilot's dockerExecEnvNames is empty, so a token in the server environment is not forwarded into the container either. The sentence now says to sign in inside the container and why the token route does not exist. Co-Authored-By: Claude Opus 5.5 (1M context) --- docs/copilot-integration.md | 4 +++- docs/wiki/Docker-Cases.md | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/docs/copilot-integration.md b/docs/copilot-integration.md index c9c64a86..4a0c383b 100644 --- a/docs/copilot-integration.md +++ b/docs/copilot-integration.md @@ -126,7 +126,9 @@ work from inside a Copilot tab and against Copilot workers: The agent image installs `@github/copilot`, and a docker case runs Copilot like any mode. **No credential directory is seeded**: without a keyring the sign-in token is plain text in `config.json`, and `CRED_STORES` (`src/docker-hosts.ts`) deliberately has no `.copilot` row. -Sign in inside the container (`copilot login`), or set `COPILOT_GITHUB_TOKEN` for the session. +Sign in inside the container (`copilot login`). Setting `COPILOT_GITHUB_TOKEN` for the session does +not reach it: a docker quick-start refuses `envOverrides`, and Copilot's `dockerExecEnvNames` is +empty, so a token in the server environment is not forwarded either. ## Remote SSH cases diff --git a/docs/wiki/Docker-Cases.md b/docs/wiki/Docker-Cases.md index 50317b93..4c6e85da 100644 --- a/docs/wiki/Docker-Cases.md +++ b/docs/wiki/Docker-Cases.md @@ -120,7 +120,9 @@ Codeman reads it host-side for history and resume. GitHub Copilot CLI is not seeded: on a host without a keyring its sign-in token sits in plain text in `~/.copilot/config.json`, and there is no Docker credential row for it. Sign in inside -the container (`copilot login`), or set `COPILOT_GITHUB_TOKEN` for the session. +the container (`copilot login`). A `COPILOT_GITHUB_TOKEN` cannot be handed in instead: a docker +case refuses per-session environment overrides, and Copilot forwards no server variable into +the container. **Git hosts.** The agent image can also include the GitHub CLI (`gh`) and the Azure CLI (`az`, with the `azure-devops` extension), off by default, and its git then uses them as credential